12.1.201906170020-493d26e4f3e.d98d7f835ad QA Issue
Process
Each engineer validates and checks off each of their assigned QA task(s).
- Check off each Merge Request changes that you've tested successfully and note any issues you've created and check them off as they are resolved.
- If a problem is found:
- Create an issue for it and add a sub bullet item under the corresponding validation checklist task. Link the issue there.
- Add the severity label
- Raise the problem in the discussion and tag relevant Engineering and Product managers.
- If a regression is found:
- Create an issue for it
- Add the severity label and the regression label
- Raise the regression in the discussion and tag relevant Engineering and Product managers.
General Quality info can be found in the Quality Handbook.
Deadline
QA testing on staging.gitlab.com for this issue should be completed by 2019-06-17 18:15 UTC. After this deadline has passed, Release Managers will proceed with the canary and production deployment.
Merge Requests tested in 12.1.201906170020-493d26e4f3e.d98d7f835ad
Community contribution
Community contribution-
@eread | Clarify that GitLab CI token does not have write permissions Community contribution ~"Documentation" ~"Verify" devopsverify -
@filipa | Externalize strings of email page in user profile Community contribution Hackathon frontend ~"internationalization" -
@filipa | Externalize strings of email page in user profile Community contribution frontend ~"internationalization" -
@smcgivern | Clarify that performance bar is not always on Community contribution ~"Plan" auto updated -
@nick.thomas | List ssh-ed25519 example Community contribution ~"Manage" devopsmanage -
@nick.thomas | EE port of "list ssh-ed25519 example" Community contribution ~"Manage" devopsmanage -
@smcgivern | Adding labels to note event payload. 1st contribution Community contribution ~"Plan" api ~"webhooks" -
@eread | Improve details about acceptable number of unicorn workers Community contribution ~"Distribution" ~"Documentation" -
@rpaik | Remove extra word on Health Check page Community contribution ~"Documentation" ~"docs-fix" -
@marcia | Use correct alert box Community contribution ~"Documentation" ~"Monitor" -
@axil | Docs: enable numeric UIDs and GIDs for NFS Community contribution ~"Documentation" -
@axil | Alertmanager on omnibus requires configuration Community contribution ~"Documentation" -
@marcia | Docs: Updating issue data and actions doc Community contribution ~"Documentation" devopsplan -
@eread | Fixed documentationmarkdown link in Docker compose note 1st contribution Community contribution ~"Documentation" ~"Verify" devopsverify ~"docs-fix" -
@eread | Update docs to reflect MR#1386 changes to gitlab-runner 1st contribution Community contribution ~"Documentation" ~"Verify" devopsverify ~"runner" -
@mikelewis | Docs: SSOT edits to docs that are alone in root directories Community contribution ~"Documentation" -
@kushalpandya | Apply tooltip on truncated commit title 1st contribution Community contribution Hackathon UX debt frontend -
@rymai | Update Serverless.gitlab-ci-yml to fix lint warning Community contribution ~"Verify" devopsverify -
@marcia | Fix Typos Community contribution ~"Documentation" ~"docs-fix" -
@ClemMakesApps | Adding break-word css to home-panel-description class to correctly word wrap long words Community contribution ~"Manage" devopsmanage frontend -
@eread | Docs: Convert absolute links to relative in /ci docs Community contribution ~"Documentation" ~"docs:improvement" -
@DouweM | Process up to 100 commit messages for references when pushing to a new default branch Community contribution devopscreate -
@tkuah | AutoDevops fix ensure_namespace() does not explicitly test namespace 1st contribution Community contribution ~"Configure" ~"auto devops" ~"devops::configure" -
@tkuah | inherit require 2fa for all subgroups and projects 2FA Community contribution ~"Manage" customer devopsmanage -
@eread | Clarify ED25519 SSH key support Community contribution ~"Documentation" auto updated -
@ashmckenzie | Don't import pull request comments from Gitea repos 1st contribution Community contribution ~"Manage" ~"bug" devopsmanage ~"group::access" ~"importers" project ~"project import" -
@jameslopez | Add support for AsciiDoc include directive 1st contribution Community contribution asciidoc devopscreate repository -
@filipa | Fix styling for app/assets/stylesheets/pages/detail_page.scss
CSS cleanup Community contribution ~"backstage" frontend -
@stanhu | Fix broken hyperlink in reducing_the_repo_size_using_git.md Community contribution ~"Documentation"
Plan ~"Plan"
-
@smcgivern | Allow references to labels and milestones to contain emoji ~"Plan" backend ~"feature" labels milestones -
@weimeng | Make burndown chart timezone aware ~"Plan" customer ~"feature" ~"support-fix" -
@dzaporozhets | Resolve "Specs using No+Label
filter are failing on EE master" ~"Plan" ~"backstage" devopsplan master:broken -
@jprovaznik | API issues - minor cleanup of permission check ~"Plan" api backend ~"backstage" -
@acroitor | Document when milestones and labels links are missing ~"Accepting merge requests" ~"Documentation" ~"Plan" backend devopsplan docs-only ~"feature" issues labels milestones -
@egrieff | Resolve "Email notifications do not work properly (issue due date)" ~"P3" ~"Plan" ~"S3" backend ~"bug" devopsplan issues notifications -
@kushalpandya | Use fragments in Epic Tree query and include __typename
~"Category::Agile Portfolio Management" GraphQL ~"Plan" epics frontend ~"technical debt" -
@kushalpandya | Reorder CSS to prevent hitting compound selector limit ~"Category::Agile Portfolio Management" GraphQL ~"Plan" ~"backstage" epics frontend ~"technical debt" -
@cablett | Use serializers for project / group boards ~"Category::Issue Boards" ~"Plan" Stretch backend ~"backstage" ~"technical debt" -
@cablett | Use serialization for project boards ~"Category::Issue Boards" ~"Plan" backend ~"backstage" ~"technical debt" -
@digitalmoksha | Fix Calculation of Epic Ancestor Links ~"P2" ~"Plan" ~"S2" backend ~"bug" devopsplan epics -
@digitalmoksha | Fix broken master for Mysql EE and EpicPresenter failure ~"Plan" ~"backstage" epics master:broken
Create ~"Create"
-
@pslaughter | [Part 3] 5276 Update file mirror and diff modules ~"Create" Deliverable ~"P1" ~"Requires e2e tests" ~"backstage" devopscreate frontend ~"group::editor" ~"web ide" -
@pslaughter | [CE for Part 3] Update IDE file mirror service (ce utils) ~"Create" ~"backstage" devopscreate frontend ~"group::editor" ~"web ide" -
@mvanremmerden | Make margin between buttons consistent ~"Create" UI polish UX ~"bug" groupsource code -
@oswaldo | Avoid DB timeouts when scheduling migrations ~"Create" ~"bug" database merge requests regression -
@mvanremmerden | User link styling for commits ~"Create" Deliverable UI polish UX accessibility ~"bug" devopscreate frontend groupsource code repository -
@sming-gitlab | Add word break style to branch name in dropdown ~"Create" Progress:Half-done ~"S4" UI polish ~"bug" frontend -
@oswaldo | Handle encoding errors for MergeToRefService ~"Create" backend ~"bug" regression -
@iamphill | Add LFS blob IDs to GraphQL tree type ~"Create" ~"feature" frontend -
@oswaldo | [EE] Revert "Automatically update MR merge-ref along merge status" ~"Create" backend ~"backstage" ~"bug" regression -
@oswaldo | Revert "Automatically update MR merge-ref along merge status" ~"Create" backend ~"backstage" ~"bug" regression -
@pslaughter | Fix gl_dropdown scrolling to top on assignee click ~"Create" ~"Pick into 11.10" ~"Pick into 11.11" UI polish ~"bug" devopscreate frontend issues merge requests regression regression:11.10 regression:11.11 -
@nick.thomas | Remove a now-unneeded ES rake task ~"Create" ~"backstage" devopscreate ~"elasticsearch" ~"group::editor" ~"search" ~"technical debt" -
@nick.thomas | Remove docs for a removed ES rake task ~"Create" ~"backstage" devopscreate ~"group::editor" ~"search" -
@pslaughter | [Part 4] 5276 Create terminal sync Vuex module and update plugin ~"Create" Deliverable ~"P1" devopscreate ~"feature" frontend ~"group::editor" ~"web ide" -
@reprazent | Rename BatchCommitLoader
toBatchLfsOidLoader
~"Create" GraphQL ~"feature" groupsource code ~"technical debt" -
@pslaughter | [Part 5] Terminal sync service status label in IDE status bar ~"Create" Deliverable ~"P1" ~"UX ready" devopscreate ~"feature" frontend ~"group::editor" ~"web ide" -
@pslaughter | [CE for Part 5] 5276 Extract ide_status_list from ide_status_bar ~"Create" ~"backstage" devopscreate frontend ~"group::editor" ~"web ide" -
@nick.thomas | Partially revert d9cb907c: "Avoid loading objects from DB in ES results" ~"Create" ~"P2" ~"S2" ~"bug" ~"elasticsearch" ~"group::editor" regression regression:12.0 -
@iamphill | Click file row in repository Vue app to view file ~"Create" ~"bug" frontend -
@nick.thomas | Raise an error if creating the MergeRequestDiff fails ~"Create" ~"P2" ~"S2" ~"bug" groupsource code needs investigation -
@igor.drozdov | Use fallback approval rule if no eligible rules exist ~"Create" backend ~"bug" devopscreate groupsource code -
@nick.thomas | Fix a broken link in PROCESS.md ~"Create" ~"Documentation" ~"bug" ~"docs-fix" -
@tristan | Docs: Add note clarifying the free status of pull mirroring ~"Create" ~"Documentation" ~"backstage" devopscreate ~"support-fix" -
@iamphill | Added diff suggestion popover ~"Create" ~"feature" frontend -
@nick.thomas | Renumber a new UserCallout enum for EE compatibility ~"Create" groupsource code master:broken -
@reprazent | Expose comments for designs in GraphQL ~"Create" GraphQL ~"design management" -
@reprazent | Expose comments on Noteables in GraphQL ~"Create" GraphQL ~"design management" devopscreate -
@sbigelow | Resolve "Merge request tabs do not handle ctrl+click correctly" ~"Create" ~"bug" devopscreate frontend merge requests ~"workflow::In review"
Manage ~"Manage"
-
@stanhu | Add OpenID Connect troubleshooting docs ~"Documentation" ~"Manage" -
@tristan | Add more info to deleted user documentation ~"Documentation" ~"Manage" customer devopsmanage ~"support-fix" -
@stanhu | Fix Fogbugz Importer not working ~"Manage" ~"Pick into 11.11" ~"bug" regression regression:11.11 -
@dosuken123 | Ignore legacy artifact columns in Project Import/Export ~"Manage" ~"Pick into 12.0" ~"bug" ~"project import" regression:12.0 -
@lbennett | Tracking attrs no dev ~"Manage" ~"backstage" frontend snowplow tracking events -
@wortschi | Add content for onboarding tour Deliverable ~"Growth" ~"Manage" ~"P1" direction frontend -
@mksionek | Resolve "Only allow non-admins to archive projects, not delete them" CS Top 10 (2018CQ2) Deliverable GitLab Premium ~"Manage" ~"P1" backend customer+ database devopsmanage direction ~"feature" permissions project settings -
@mksionek | Add EE backport for the admin view ~"Manage" -
@lbennett | Fix diverged branch locals ~"Manage" ~"bug" frontend regression regression:12.0 -
@stanhu | Bump omniauth_openid_connect to 0.3.1 ~"Manage" ~"backstage" ~"dependency update" - [] @lbennett | Fix diverged branch locals ~"Manage" ~"P1" ~"S1" ~"bug" frontend regression:12.0
-
@wortschi | Onboarding app component Deliverable ~"Growth" ~"Manage" ~"P1" direction frontend -
@blabuschagne | Resolve "Polish SAML SSO configuration page" Deliverable ~"Manage" ~"P2" UI polish devopsmanage frontend ~"group::access" ~"ready for review" saml -
@blabuschagne | i18n EE JS burndown chart Deliverable ~"Manage" ~"P2" ~"backstage" frontend ~"internationalization" -
@blabuschagne | "Add ESLint i18n plugin" Deliverable ~"Manage" ~"P2" ~"backstage" frontend ~"internationalization" -
@gitlab-crowdin-bot | New Crowdin translations ~"Manage" ~"Pick into 12.0" frontend ~"internationalization" -
@lbennett | Master i18n ~"Manage" ~"Pick into 12.0" frontend ~"internationalization" -
@blabuschagne | "Add ESLint i18n plugin - EE" Deliverable ~"Manage" ~"P2" ~"backstage" frontend ~"internationalization" -
@wortschi | Fix syntax errors in translations Deliverable ~"Growth" ~"Manage" ~"P1" direction frontend -
@lbennett | Fix sidebar flyout navigation ~"Manage" ~"P4" ~"Pick into 12.0" ~"S4" ~"bug" frontend navigation regression regression:12.0 -
@wortschi | Onboarding helper: Display loading icon when user clicks "Skip step" Deliverable ~"Growth" ~"Manage" ~"P1" direction frontend -
@gitlab-crowdin-bot | New Crowdin translations ~"Manage" ~"Pick into 12.0" frontend ~"internationalization" -
@lbennett | Master i18n ~"Manage" ~"Pick into 12.0" frontend ~"internationalization" -
@lbennett | Regen locale gitlab.pot file ~"Manage" ~"backstage" frontend ~"internationalization" -
@pshutsin | Add global LDAP membership lock setting CS Top 10 (2018CQ3) Deliverable ~"Manage" ~"P1" ~"S3" backend customer customer+ database devopsmanage direction ~"estimation:completed" ~"feature" ~"group::access" ldap ~"promised" -
@lbennett | Regen locale gitlab.pot file ~"Manage" ~"backstage" frontend ~"internationalization" master:broken
Verify ~"Verify"
-
@sming-gitlab | Make option dropdown button to match adjacent button ~"Category::Continuous Integration" ~"P4" ~"S4" ~"Verify" ~"bug" devopsverify frontend -
@fabiopitino | Move project default git depth behind feature flags ~"Verify" ~"backstage" devopsverify feature flag -
@sarahghp | Fix pipeline dropdown overflow ~"Category::Continuous Integration" UI polish ~"Verify" ~"backstage" devopsverify frontend -
@mikelewis | Remove unnecessary notes from AutoDevOps documentation ~"Category::Continuous Integration" ~"Documentation" ~"Verify" devopsverify -
@matteeyah | Metrics reports documentation is incomplete Deliverable ~"Documentation" ~"Verify" devopsverify ~"metrics" -
@fabiopitino | Expose default_git_depth via project API ~"Verify" devopsverify ~"feature" -
@sarahghp | Review toolbar modularization ~"Verify" ~"backstage" frontend ~"technical debt"
Release ~"Release"
-
@dosuken123 | Cancel Auto Merge when target branch is changed ~"Category::Continuous Integration" Deliverable GitLab Premium Product Vision FY20 ~"Release" UX backend breadth ~"continuous delivery" customer ~"devops" direction ~"feature" frontend internal customer ~"rebuild in GitLab" -
@dosuken123 | Notify events when auto merge is enabled or merge param is updated ~"Category::Continuous Integration" Deliverable GitLab Premium Product Vision FY20 ~"Release" UX backend ~"backstage" breadth ~"continuous delivery" customer ~"devops" direction frontend internal customer ~"rebuild in GitLab" -
@dosuken123 | Persist target project id and target branch in merge trains table ~"Category::Continuous Integration" Deliverable GitLab Premium Product Vision FY20 ~"Release" UX ~"UX ready" auto updated backend ~"backstage" ~"continuous delivery" customer ~"devops::release" direction ~"feature" frontend internal customer ~"rebuild in GitLab" -
@dosuken123 | Persist target project id and target branch in merge trains table ~"Category::Continuous Integration" Deliverable GitLab Premium Product Vision FY20 ~"Release" UX backend ~"backstage" breadth ~"continuous delivery" customer ~"devops" direction frontend internal customer ~"rebuild in GitLab" -
@dosuken123 | Update merge options for auto merge strategies ~"Category::Continuous Integration" Deliverable GitLab Premium Product Vision FY20 ~"Release" UX backend ~"backstage" breadth ~"continuous delivery" customer ~"devops" direction frontend internal customer ~"rebuild in GitLab" -
@nfriend | Update the merge request widget's "Merge" button to support merge trains ~"Category::Continuous Integration" Deliverable GitLab Premium Product Vision FY20 ~"Release" UX ~"UX ready" backend blocked ~"continuous delivery" customer ~"devops::release" direction ~"feature" frontend internal customer ~"rebuild in GitLab" -
@nfriend | CE backport for gitlab-org/gitlab-ee!12156: Update the merge request widget's "Merge" button to support merge trains ~"Category::Continuous Integration" Deliverable GitLab Premium Product Vision FY20 ~"Release" UX ~"UX ready" backend ~"continuous delivery" customer ~"devops::release" direction ~"feature" frontend internal customer ~"rebuild in GitLab" -
@dosuken123 | Remove merge request pipeline check in mergeable method ~"Category::Continuous Integration" Deliverable GitLab Premium Product Vision FY20 ~"Release" UX ~"UX ready" backend ~"continuous delivery" customer ~"devops::release" direction ~"feature" frontend internal customer ~"rebuild in GitLab" -
@nfriend | CE backport for gitlab-org/gitlab-ee!12309: Remove merge request pipeline check in mergeable method ~"Category::Continuous Integration" Deliverable GitLab Premium Product Vision FY20 ~"Release" UX ~"UX ready" backend ~"continuous delivery" customer ~"devops::release" direction ~"feature" frontend internal customer ~"rebuild in GitLab" -
@dosuken123 | (CE Port) [New Auto Merge Strategy] Merge Train ~"Category::Continuous Integration" Deliverable GitLab Premium Product Vision FY20 ~"Release" UX backend ~"backstage" breadth ~"continuous delivery" customer ~"devops" direction frontend internal customer ~"rebuild in GitLab" -
@vshushlin | Upgrade pages to v1.6.1 ~"Release" ~"backstage" ~"devops::release" -
@dosuken123 | [New Auto Merge Strategy] Merge Train ~"Category::Continuous Integration" Deliverable GitLab Premium Product Vision FY20 ~"Release" UX ~"UX ready" auto updated backend ~"continuous delivery" customer ~"devops::release" direction ~"feature" frontend internal customer ~"rebuild in GitLab" -
@dosuken123 | [New Auto Merge Strategy] Add To Merge Train When Pipeline Succeeds ~"Category::Continuous Integration" Deliverable GitLab Premium ~"Pick into 12.0" Product Vision FY20 ~"Release" UX ~"UX ready" auto updated backend ~"continuous delivery" customer ~"devops::release" direction ~"feature" frontend internal customer ~"rebuild in GitLab" -
@afontaine | Add Button for Maintainers to Rotate Instance Id ~"Release" ~"devops::release" ~"feature" frontend security
Gitaly ~"Gitaly"
-
@jacobvosmaer-gitlab | Use Go 1.11.10 in source installations ~"Documentation" ~"Gitaly" -
@jacobvosmaer-gitlab | Update git object deduplication overview ~"Documentation" ~"Gitaly" -
@johncai | Fix null source_project_id in pool_repositories ~"Gitaly" auto updated ~"bug" database
Package ~"Package"
-
@dzaporozhets | Allow developers to configure dependency proxy ~"Dependency Proxy" ~"Package" backend
Configure ~"Configure"
-
@tigerwnz | Add a default reactive cache key ~"Configure" backend ~"backstage" -
@ealcantara | Style popovers according to the design specs ~"Configure" Deliverable UX ~"backstage" ~"component::popovers" frontend ~"pajamas::style" -
@DylanGriffith | Remove incorrect docs from deploy_boards.md ~"Configure" ~"Documentation" ~"bug" ~"devops::configure" ~"group::autodevops and kubernetes"
Monitor ~"Monitor"
-
@rpereira2 | Add docs for linking to external dashboard Deliverable ~"Documentation" ~"Monitor" Persona: DevOps Engineer Persona: Software developer Persona: Systems Administrator ~"Pick into 12.0" ~"UX ready" backend devopsmonitor direction ~"feature" frontend release post item -
@syasonik | EE Port: gitlab-ce!29186 Update server API to enable switch prometheus endpoint APM Deliverable ~"Monitor" backend devopsmonitor ~"feature" -
@psimyn | Update server API to enable switch prometheus endpoint Deliverable ~"Monitor" backend devopsmonitor ~"feature" -
@psimyn | Resolve "Target area for dropdown list items is too small on Metrics Dashboard" APM Deliverable ~"Monitor" ~"P2" ~"S3" ~"bug" devopsmonitor frontend ~"group::apm" -
@psimyn | Resolve "Remove unnecessary decimal places on chart axes" APM Charts ~"Monitor" UX debt ~"enhancement" ~"feature" frontend -
@splattael | Resolve "Usage ping for Incident Management" Deliverable Health ~"Monitor" backend database devopsmonitor ~"feature" ~"incident management" -
@psimyn | Switch charts to Prometheus API endpoint EE-2 Deliverable ~"Monitor" devopsmonitor frontend ~"metrics" -
@psimyn | Switch charts to Prometheus API endpoint EE-3 Deliverable ~"Monitor" devopsmonitor frontend ~"metrics" -
@psimyn | Switch charts to Prometheus API endpoint CE-3 Deliverable ~"Monitor" devopsmonitor frontend ~"metrics" -
@rpereira2 | Remove the grafana_dashboard_link feature flag ~"Monitor" backend ~"backstage" devopsmonitor ~"feature" feature flag frontend -
@syasonik | Refactor for cleaner caching in dashboards Health ~"Monitor" backend ~"backstage" devopsmonitor ~"metrics" -
@dbalexandre | Send only pod logs usage total on the usage data ~"Monitor" backend ~"backstage" devopsmonitor ~"group::telemetry" -
@dbodicherla | Fix missing deployment rockets in monitor dashboard ~"Monitor" ~"S2" ~"bug" frontend -
@syasonik | Specify a dropdown name for dashboards APM ~"Monitor" backend devopsmonitor ~"feature" ~"metrics" -
@psimyn | Resolve "Embed Zoom Call in Issue MVC" Deliverable Health ~"Monitor" ~"feature" frontend ~"incident management"
Secure ~"Secure"
-
@markrian | Dependency List - Connect frontend to backend - rails view Deliverable GitLab Ultimate ~"Secure" ~"Secure::Software Composition Analysis" UX backend ~"bill of materials" devopssecure ~"feature" frontend -
@markrian | Add project Dependency List sidebar entry Deliverable GitLab Ultimate ~"Secure" ~"Secure::Software Composition Analysis" UX backend ~"bill of materials" devopssecure ~"feature" frontend -
@brytannia | Add DependencyList usage ping Deliverable ~"Secure" ~"Secure::Software Composition Analysis" backend ~"bill of materials" devopssecure ~"feature" ~"workflow::In dev" -
@avielle | Resolve "Add enum suffix to Feedback type" ~"Secure" ~"Secure::Static and Dynamic Analysis" Stretch backend ~"backstage" devopssecure -
@theoretick | Add ApprovalMRRule fallback for legacy code_owner rules ~"Pick into 12.0" ~"Secure" approvals ~"bug" groupsource code regression regression:12.0 -
@vzagorodny | [CE backport] Document SAST and Dependency Scanning report JSON format ~"Documentation" ~"Secure" ~"Secure::Static and Dynamic Analysis" devopssecure ~"docs:improvement" -
@vzagorodny | Fix typos, grammar and wording for SAST and DS report JSON docs ~"Documentation" ~"Secure" ~"Secure::Static and Dynamic Analysis" devopssecure ~"docs-fix" ~"docs:fix"
-
-
@theoretick | Add report_approver to approval_merge_request_rules ~"Secure" ~"Secure::Static and Dynamic Analysis" backend database devopssecure -
@avielle | Bring propagated SAST ENV vars into parity with docs Deliverable ~"P2" ~"S2" ~"Secure" ~"Secure::Static and Dynamic Analysis" ~"bug" customer devopssecure ~"sast" -
@pgascouvaillancourt | Upgrade gitlab-ui and migrate gl-pagination ~"Secure" ~"backstage" ~"component::pagination" frontend -
@caneldem | referring environment variables ~"Documentation" ~"Secure" ~"Secure::Software Composition Analysis" devopssecure ~"license management" -
@fcatteau | Document CI variable LM_PYTHON_VERSION ~"Documentation" ~"Secure" ~"Secure::Software Composition Analysis" ~"feature" ~"license management"
frontend
frontend-
@annabeldunstone | Use grid and correct border radius for status badge UI polish frontend -
@msnow1 | Update geo.rake - need to remove Sales@ email alias UX debt auto updated frontend -
@annabeldunstone | Fix system note alignment within diff UI polish ~"bug" frontend -
@filipa | Creates pagination component graphql GraphQL UI component frontend ~"technical debt" -
@filipa | EE: Moves table pagination component ~"backstage" frontend ~"technical debt" -
@filipa | Moves table pagination component GraphQL UI component ~"backstage" frontend ~"technical debt" -
@psimyn | Switch charts to Prometheus API endpoint CE-2 APM Deliverable auto updated devopsmonitor ~"feature" feature flag frontend ~"metrics" -
@stanhu | Fix "Resolve conflicts" button not appearing for some users devopscreate frontend merge requests -
@psimyn | Resolve "Visual regression in 12.0: line numbers not lining up in file view" ~"bug" devopscreate frontend regression regression:12.0 -
@rdavila | Notify users when their CI minutes quota has run out Deliverable ~"P2" ~"UX ready" backend database ~"devops::enablement" direction ~"feature" frontend ~"transactions 🎁 " -
@ntepluhina | Added naming convention for .graphql files ~"Documentation" GraphQL frontend -
@ashmckenzie | Add trackEvent when accessing the Register tab ~"Growth" ~"backstage" devopsgrowth frontend snowplow tracking events -
@filipa | Moves sp.js to CE repo ~"backstage" frontend single codebase -
@nolith | Fix group usage quota menu item backend ~"bug" frontend regression -
@dzaporozhets | Use scoped routes for labels and milestones ~"backstage" frontend ~"technical debt" -
@dzaporozhets | Use scoped routes for labels and milestones [EE] ~"backstage" frontend ~"technical debt" -
@annabeldunstone | Update height of $mr-tabs-height ~"bug" frontend regression -
@leipert | Update to node@12 ~"Documentation" ~"backstage" frontend -
@leipert | Update dependency @gitlab/eslint-plugin-i18n to ^1.1.0 ~"backstage" ~"dependency update" frontend -
@leipert | Update dependency @gitlab/svgs to ^1.65.0 ~"backstage" ~"dependency update" frontend -
@leipert | Update default CI image to use node@12 ~"backstage" frontend -
@leipert | Update dependency @gitlab/ui to ^4.1.0 ~"backstage" ~"dependency update" frontend -
@donaldcook | Pendo POC auto updated frontend ~"group::telemetry" -
@donaldcook | Backport: Pendo POC snippet frontend ~"group::telemetry"
database
database-
@yguo | Issue 62684 database -
@pshutsin | EE migration port: add app-wide LDAP membership lock field ~"backstage" database
uncategorized ~"uncategorized"
-
@stanhu | Revert "Merge branch '50070-legacy-attachments' into 'master'" ~"backstage" devopsplan -
@stanhu | Add backtraces to Peek performance bar for SQL calls ~"backstage" ~"performance" -
@annabeldunstone | Fix border radius of collapse discussion btn UI polish ~"backstage" -
@nolith | Fix nil coercion updating storage size on project statistics ~"P1" ~"S1" backend ~"backstage" ~"bug" data integrity -
@jprovaznik | Add puma killer observer ~"Memory" Multithreaded App Server ~"backstage" -
@stanhu | Fix UTF-8 conversion issues when resolving conflicts ~"bug" devopscreate merge requests -
@dzaporozhets | Remove some deprecated code backend ~"backstage" ~"technical debt" -
@eread | Add eread as CODEOWNER for doc dir ~"backstage" -
@dosuken123 | Fix pipeline schedule when owner is nil ~"P2" ~"Pick into 12.0" ~"S2" ~"bug" regression -
@godfat | Use Time.zone.now for Ci::PipelineSchedule#ideal_next_run_at ~"P1" ~"S1" devopsverify master:broken -
@jprovaznik | Moved RackTimeout observer to a different location and ignore transition states Multithreaded App Server ~"backstage" -
@ashmckenzie | Add trackEvent when accessing the Register tab ~"Growth" ~"backstage" -
@nick.thomas | Backport changes from 'Partially revert d9cb907c: "Avoid loading objects from DB in ES results"' ~"bug" regression regression:12.0 -
@brytannia | Fix null blob_path ~"Secure::Software Composition Analysis" ~"bug" devopssecure -
@drewcimino | disable CI variable complex expressions by default auto updated devopsverify -
@stanhu | Omit blocked admins from repository check e-mails ~"bug" devopsmanage -
@stanhu | Speed up commit loads by disabling BatchLoader replace_methods ~"P1" ~"S1" devopscreate ~"performance" -
@rcobb | Add back sidekiq metrics exporter devopsmonitor -
@mikelewis | Update CODEOWNERS to add mikelewis for doc path ~"backstage"
Automated QA for 12.1.201906170020-493d26e4f3e.d98d7f835ad
No QA job could be found for this release!
You will need to set up a dedicated environment for 12.1.201906170020-493d26e4f3e.d98d7f835ad by following the following steps:
Prepare the environments for testing the security fixes
Instructions to prepare environment
- In Google Cloud Console (access to this
should have been granted during on-boarding), create a new VM instance (in the
gitlab-internal
project) from theqa-security-1cpu-3-75gb-ram-ubuntu-16-04-lts
instance template for each version of GitLab. - Find the
.deb
package to install:- First find the pipeline for the
12.1.201906170020+ee.0
tag in the pipelines page. - Then on the pipeline page, click the
Ubuntu-16.04-staging
job in theUpload:gitlab_com
stage (or theStaging_upload
stage for versions prior to 11.5), you will need the job ID later.
- First find the pipeline for the
- Install the
.deb
package from the job artifact:- SSH into the VM via the GCP console.
- Create a
install-gitlab.sh
script in your home folder:TEMP_DEB="$(mktemp)" GITLAB_PACKAGE="https://dev.gitlab.org/api/v4/projects/gitlab%2Fomnibus-gitlab/jobs/${JOB_ID}/artifacts/pkg/ubuntu-xenial/gitlab-ee_${GITLAB_VERSION}-ee.0_amd64.deb" curl -H "PRIVATE-TOKEN: $DEV_TOKEN" "$GITLAB_PACKAGE" -o "$TEMP_DEB" && sudo dpkg -i "$TEMP_DEB" rm -f "$TEMP_DEB"
-
$DEV_TOKEN
needs to be set with adev.gitlab.org
personal access token so that the script can download the package -
$JOB_ID
needs to be set with theUbuntu-16.04-staging
job ID -
$GITLAB_VERSION
needs to be set with the version (without the-ee
prefix, e.g.11.4.10
).
-
- Change the script's permission with
chmod +x install-gitlab.sh
. - Run the script with
./install-gitlab.sh
. - Once GitLab installed, set the
external_url
in/etc/gitlab/gitlab.rb
withsudo vim /etc/gitlab/gitlab.rb
. You can find the VM's IP in the GCP console. - Reconfigure and restart GitLab with
sudo gitlab-ctl reconfigure && sudo gitlab-ctl restart
. - You may need to wait a few minutes after the above command finishes before the instance is actually accessible.
- Set the
root
's user password:- Visit http://IP_OF_THE_GCP_VM and change
root
's password. - Once the environments are ready, capture the information to add to the QA issue.
- Visit http://IP_OF_THE_GCP_VM and change
Automated QA
Instructions to perform automated QA
-
(Optional) If the QA Docker image doesn't exist, you will need to build it manually on your machine, e.g.
# In gitlab-ee › git fetch dev › git checkout v12.1.201906170020-493d26e4f3e.d98d7f835ad-ee › cd qa › docker build -t dev.gitlab.org:5005/gitlab/omnibus-gitlab/gitlab-ee-qa:12.1.201906170020-493d26e4f3e.d98d7f835ad-ee .
-
Make sure to export the following environment variables (you can find the token under the GitLab QA - Access tokens
1Password items)-
$QA_IMAGE
the URL of the QA image -
$QA_ENV_URL
with the URL of the environment where the package has been deployed (usually https://staging.gitlab.com for the current version, andhttp://IP_OF_THE_GCP_VM
for back-ported versions). -
$GITLAB_USERNAME
withroot
. -
$GITLAB_ADMIN_USERNAME
with$GITLAB_USERNAME
. -
$GITLAB_PASSWORD
with the password you've set for theroot
user. -
$GITLAB_ADMIN_PASSWORD
with$GITLAB_PASSWORD
. -
$GITHUB_ACCESS_TOKEN
with a valid GitHub API token that can access the https://github.com/gitlab-qa/test-project project -
$DEV_USERNAME
with yourdev
username -
$DEV_TOKEN
with a validdev
personal access token that has theread_registry
scope
› export QA_IMAGE="dev.gitlab.org:5005/gitlab/omnibus-gitlab/gitlab-ee-qa:12.1.201906170020-493d26e4f3e.d98d7f835ad-ee" › export QA_ENV_URL="<QA_ENV_URL>" › export GITLAB_USERNAME="root" › export GITLAB_ADMIN_USERNAME="$GITLAB_USERNAME" › export GITLAB_PASSWORD="<GITLAB_PASSWORD>" › export GITLAB_ADMIN_PASSWORD="$GITLAB_PASSWORD" › export GITHUB_ACCESS_TOKEN="<GITHUB_ACCESS_TOKEN>" › export DEV_USERNAME="<DEV_USERNAME>" › export DEV_TOKEN="<DEV_TOKEN>"
-
-
Update gitlab-qa
if needed› gem install gitlab-qa
-
Log into the dev
container registry› docker login --username "$DEV_USERNAME" --password "$DEV_TOKEN" dev.gitlab.org:5005
-
Automated QA completed. QA can be parallelized manually (for now): # Tab 1: This should take approximately 4.5 minutes › gitlab-qa Test::Instance::Any $QA_IMAGE $QA_ENV_URL -- qa/specs/features/api/ qa/specs/features/login/ qa/specs/features/merge_request/
# Tab 2: This should take approximately 6 minutes › gitlab-qa Test::Instance::Any $QA_IMAGE $QA_ENV_URL -- qa/specs/features/project/
# Tab 3: This should take approximately 5 minutes › gitlab-qa Test::Instance::Any $QA_IMAGE $QA_ENV_URL -- qa/specs/features/repository/
-
Post results as comments of this issue -
Create Automation Triage RELEASE_MAJOR_VERSION RC#
issues for all the automated QA failures (with failures logs + screenshots) and link it to this issue
Coordinate the Manual QA validation of the release
Click for details
- Notify the Security Engineer to verify the security fixes for the release.
- The manner in which the security fixes are verified can be done in two ways.
- By the Quality Engineer executing the validation with close collaboration and guidance from the Security Engineer.
- By the Security Engineer executing the validation with the Quality Engineer monitoring the steps.
- Note: When encountered with deadline and resource constraints, the work should be assigned for efficiency. Security Engineer should own verifying complex security validations while Quality Engineer is encouraged to help out with simpler validations. However it is important that the Security team signs off on the result of the validation.
- The manner in which the security fixes are verified can be done in two ways.
- Ensure that all the items for validation are validated and checked off before moving forward.
- Hand off the release assignment.
- Once all the validation is completed, Quality Engineer un-assigns themselves from the release issue leaving only the Security Engineer and the Release Manager.
/cc @gl-quality