Moved RackTimeout observer to a different location and ignore transition states
What does this MR do?
Because there will be similar observer for PumaWorkerKiller - https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/28992, it makes sense to keep both on better place.
This MR also changes behavior of the observer - ready and active states (which are not final) are now ignored because these are not needed for getting ratio of completed vs failed requests. And its presence would make usage of this metric more complicated - see examples in https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/29214#note_179633350. For easier review this change is done in a separate commit:
- first commit - only change of location
- second commit - ignored transition states
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation created/updated or follow-up review issue created -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Performance and testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team