Foundations Engineering Async Updates (2023-04-24 – 2023-04-30)

Announcements

Trending Charts

MR Sparkline

The trend of the the merged MRs in the past few weeks. We're not tracking numbers here, just general trends.

Milestone Tracking

Completed this week

Issues

• Follow-up from "Resolve "Navigation closes when... (gitlab-org/gitlab#408651 - closed) • James Rushford typemaintenance
• Invite modal doesn't open in the create menu (gitlab-org/gitlab#403736 - closed) • James Rushford • 16.0 typebug workflowcanary
• Navigation closes when focusing on search area ... (gitlab-org/gitlab#403510 - closed) • James Rushford • 16.0 typebug workflowcanary
• Super sidebar toggle button when HAML breadcrum... (gitlab-org/gitlab#406520 - closed) • Olena Horal-Koretska • 16.0 typefeature workflowin review
• Update homepage button styling (gitlab-org/gitlab#404784 - closed) • Olena Horal-Koretska • 16.0 typemaintenance workflowcomplete
• Dry up show_super_sidebar? and gon.use_new_navi... (gitlab-org/gitlab#391875 - closed) • Lukas Eipert • 16.0 typemaintenance workflowproduction
• Storyshots > Increase failure threshold for cha... (gitlab-org/gitlab-ui#2215 - closed) • Paul Gascou-Vaillancourt • 16.0 typemaintenance workflowin review
• POC: Move the context switcher into a `<GlDiscl... (gitlab-org/gitlab#408226 - closed) • Paul Gascou-Vaillancourt • 16.0 typemaintenance workflowcomplete
• NotImplementedError when using new navigation w... (gitlab-org/gitlab#407885 - closed) • Paul Gascou-Vaillancourt • 16.0 typebug workflowcomplete
• Add the trial status widget to the new navigation (gitlab-org/gitlab#406756 - closed) • Paul Gascou-Vaillancourt • 16.0 typefeature workflowcomplete
• Code for stories isn't consistently available (gitlab-org/gitlab-ui#2196 - closed) • Paul Gascou-Vaillancourt • 16.0 typebug workflowin review
• Consider upgrading to Storybook 7 (and webpack@5) (gitlab-org/gitlab-ui#2110 - closed) • Paul Gascou-Vaillancourt • 16.0 typemaintenance workflowin review
• Code blocks with only one line render as one or... (gitlab-org/gitlab-ui#2102 - closed) • Paul Gascou-Vaillancourt • 16.0 typebug
• Update styles to use calculated height variables (gitlab-org/gitlab#403579 - closed) • Scott de Jonge • 16.0 typemaintenance workflowcomplete
• Update Admin link to match context (gitlab-org/gitlab#406274 - closed) • Thomas Hutterer • 16.0 typemaintenance workflowcomplete
• Simplify editing shortcuts to projects and groups (gitlab-org/gitlab#406270 - closed) • Thomas Hutterer • 16.0 typemaintenance workflowcomplete
• Follow-up from "Make menu items in new navigati... (gitlab-org/gitlab#404431 - closed) • Thomas Hutterer typemaintenance workflowcomplete

MRs

• Fix test naming (gitlab-org/gitlab!118748 - merged) • James Rushford • 16.0
• Resolve "Inset the focus state by 1px for navig... (gitlab-org/gitlab!118598 - merged) • James Rushford • 16.0
• Resolve "Navigation closes when focusing on sea... (gitlab-org/gitlab!117647 - merged) • James Rushford • 16.0
• Bugfix invite members modal (gitlab-org/gitlab!117538 - merged) • James Rushford • Next 1-3 releases
• Fixed breadcrumbs layout on MRs tab switch (gitlab-org/gitlab!118501 - merged) • Sam Beckham, Olena Horal-Koretska • 16.0
• Fix Tanuki hover/focus styles in the new nav (gitlab-org/gitlab!117138 - merged) • Olena Horal-Koretska • 16.0
• Fix persisted tooltip on the search modal trigger (gitlab-org/gitlab!115980 - merged) • Olena Horal-Koretska • 16.0
• Fix incompatibility of gopsutil dependency with... (gitlab-org/gitlab!118476 - merged) • Lukas Eipert • 16.0
• Update dependency @gitlab/ui to v61.3.0 (gitlab-org/gitlab!118520 - merged) • Mark Florian, GitLab Dependency Bot • 16.0
• Clean up and refactor global shortcuts (gitlab-org/gitlab!117666 - merged) • Mark Florian • 16.0
• chore: remove file-loader (gitlab-org/gitlab-ui!3421 - merged) • Paul Gascou-Vaillancourt • 16.0
• test(visual): increase failure threshold for ch... (gitlab-org/gitlab-ui!3419 - merged) • Paul Gascou-Vaillancourt • 16.0
• Fix expanded avatars list display in the MR widget (gitlab-org/gitlab!118516 - merged) • Paul Gascou-Vaillancourt • 16.0
• Update dependency @gitlab/ui to v62 (gitlab-org/gitlab!118512 - merged) • Paul Gascou-Vaillancourt, GitLab Dependency Bot
• test: add e2e tests for Storybook (gitlab-org/gitlab-ui!3412 - merged) • Paul Gascou-Vaillancourt • 16.0
• Ensure project is persisted when generating new... (gitlab-org/gitlab!118372 - merged) • Paul Gascou-Vaillancourt • 16.0
• Move the context switcher to a disclosure dropdown (gitlab-org/gitlab!118217 - merged) • Paul Gascou-Vaillancourt • 16.0
• chore(deps): update storybook to v7 (major) (gitlab-org/gitlab-ui!3378 - merged) • Paul Gascou-Vaillancourt, GitLab Dependency Bot
• Adds the item-icon class to the menu-section icon (gitlab-org/gitlab!118932 - merged) • Sam Beckham • 16.0
• Resolve "Add Snowplow tracking to pins" (gitlab-org/gitlab!118536 - merged) • Sam Beckham • 16.0
• Allow pages to set super sidebar expanded by de... (gitlab-org/gitlab!118141 - merged) • Scott de Jonge • 16.0
• Update import table with height variable for to... (gitlab-org/gitlab!117816 - merged) • Scott de Jonge • 16.0
• Resolve "Update Admin link to match context" (gitlab-org/gitlab!118346 - merged) • Thomas Hutterer • 16.0
• Split off a new MenuSection component from NavI... (gitlab-org/gitlab!116712 - merged) • Thomas Hutterer • 16.0

Almost Completed

Issues that are complete, but not yet verified on production

• Inset the focus state by 1px for navigation items (gitlab-org/gitlab#404857 - closed) • James Rushford • 16.0 typemaintenance workflowproduction
• Tooltip persists when opening modal on mobile (gitlab-org/gitlab#396961 - closed) • Olena Horal-Koretska • 16.0 typefeature workflowverification

In Progress

• Super sidebar accessibility review (gitlab-org/gitlab#394793 - closed) • Scott de Jonge • 16.0 typemaintenance workflowin dev
• Audit events for navigation for metric and rollout (gitlab-org/gitlab#389046 - closed) • Sam Beckham, Christen Dybenko+ • 16.1 typefeature workflowin dev
• Tracking user adoption throughout the (internal... (gitlab-org/gitlab#407163 - closed) • Sam Beckham • 16.2 typeignore workflowin dev
• Consider upgrading from Popper.js to Floating UI (gitlab-org/gitlab-ui#2213 - closed) • Paul Gascou-Vaillancourt • 16.1 typemaintenance workflowin dev
• Add support for admin mode to the new navigation (gitlab-org/gitlab#406757 - closed) • Joseph Wambua • 16.0 typefeature workflowin dev
• Allow pages to expand the super sidebar by default (gitlab-org/gitlab#391285 - closed) • Scott de Jonge • 16.0 typefeature workflowin review
• Super sidebar menu section button aria-expanded (gitlab-org/gitlab#408938 - closed) • Scott de Jonge • 16.0 typebug workflowin review
• Foundations review Database and Error Budget ow... (gitlab-org/gitlab#361622 - closed) • Sam Beckham, Christen Dybenko • 16.0 typeignore workflowin review
• Add Snowplow tracking to pins (gitlab-org/gitlab#404915 - closed) • Sam Beckham • 16.0 typefeature workflowin review
• `Settings => Merge Requests` is pinned as `Merg... (gitlab-org/gitlab#407139 - closed) • Lukas Eipert • 16.0 typebug workflowin review
• Switching from overview to changes in a merge r... (gitlab-org/gitlab#408247 - closed) • Olena Horal-Koretska • 16.0 typebug workflowin review
• Slash commands should identify project by full ... (gitlab-org/gitlab#386430) • Unassigned • Backlog • Needs attention typefeature workflowin review
• Use PajamasComponent in admin nav header (gitlab-org/gitlab#404964 - closed) • Joseph Wambua • 16.0 typemaintenance workflowin review
• Frequent items edit mode delete button overlaps... (gitlab-org/gitlab#404644 - closed) • James Rushford • 16.0 typebug workflowin review
• Fix focus states on shortcuts (gitlab-org/gitlab#404859 - closed) • James Rushford • Next 1-3 releases typemaintenance workflowin review
• Focus background change broken on buttons in su... (gitlab-org/gitlab#409090 - closed) • James Rushford typebug workflowin review

OKRs

Foundations Engineering Objective (1): Strengthen the team 47%

Foundations Engineering Objective (2): Deliver the new navigation 89%

cc: @cdybenko @jrushford @joseph @ohoral @leipert @markrian @pgascouvaillancourt @samdbeckham @sdejonge @thutterer If any of y'all prefer to stop being notified here, let me know and I'll remove you from the template.