Resolve "Inset the focus state by 1px for navigation items"
What does this MR do and why?
Describe in detail what your merge request does and why.
Sets focus behaviour to be same for both links and buttons
Screenshots or screen recordings
before | after |
---|---|
![]() |
![]() |
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #404857 (closed)
Merge request reports
Activity
changed milestone to %Next 1-3 releases
assigned to @jrushford
added 41 commits
-
926c7530...076d4239 - 40 commits from branch
master
- b409298b - Make nav links have same focus offset as buttons
-
926c7530...076d4239 - 40 commits from branch
- A deleted user
added frontend label
1 Warning You've made some app changes, but didn't add any tests.
That's OK as long as you're refactoring existing code,
but please consider adding any of the maintenancepipelines, maintenancerefactor, maintenanceworkflow, documentation, QA labels.1 Message CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, add the
Changelog
trailer to the commit message you want to add to the changelog.If you want to create a changelog entry for GitLab EE, also add the
EE: true
trailer to your commit message.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer frontend Rahul Chanila (
@rchanila
) (UTC+10, 8 hours ahead of@jrushford
)Olena HK. (
@ohoral
) (UTC+3, 1 hour ahead of@jrushford
)UX Emily Bauman (
@emilybauman
) (UTC-4, 6 hours behind@jrushford
)Maintainer review is optional for UX To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerBundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 5cf2d155 and 8eba21dc
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 3.69 MB 3.69 MB - 0.0 % mainChunk 2.16 MB 2.16 MB - 0.0 %
Note: We do not have exact data for 5cf2d155. So we have used data from: f4f66d25.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
Dangermarked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed
- Resolved by James Rushford
Allure report
allure-report-publisher
generated test report!e2e-review-qa:
test report for 8eba21dcexpand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Create | 28 | 0 | 1 | 0 | 29 | ✅ | | Plan | 49 | 0 | 1 | 0 | 50 | ✅ | | Data Stores | 22 | 0 | 0 | 0 | 22 | ✅ | | Govern | 24 | 0 | 0 | 0 | 24 | ✅ | | Manage | 8 | 0 | 3 | 0 | 11 | ✅ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | | Verify | 10 | 0 | 0 | 0 | 10 | ✅ | | Framework sanity | 9 | 0 | 1 | 0 | 10 | ✅ | | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 154 | 0 | 7 | 0 | 161 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+
added 315 commits
-
de2b74ad...ff450996 - 314 commits from branch
master
- 8eba21dc - Make focus rules same for links and buttons
-
de2b74ad...ff450996 - 314 commits from branch
removed review request for @aregnery
@aregnery
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
added pipeline:mr-approved label
requested review from @aturinske and removed review request for @rchanila
enabled an automatic merge when the pipeline for 81848bea succeeds
mentioned in commit 480c83f6
added workflowstaging-canary label and removed workflowready for development label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
mentioned in issue #404857 (closed)
mentioned in issue #409090 (closed)
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
mentioned in issue gitlab-org/manage/foundations/team-tasks#245
changed milestone to %16.0
mentioned in issue #391523 (closed)
added releasedcandidate label
mentioned in issue gitlab-org/manage/foundations/team-tasks#248
added UI polish label