This was broken again by d14d8ee2,
this commits re-applies the fix from 12fea82e

buildelement.py: remove double logging (again) as in #507

See merge request !730

Some whitespace changes to follow the style regarding empty
lines between sections.

A preventative measure against people committing the generated
html files to the wrong location.

Fixing some fallout in the workspace documentation additions

Closes #553

See merge request !732

Tristan Van Berkom authored Aug 25, 2018 and Tristan Van Berkom committed Aug 25, 2018

This main section is just a choice of subsections, lets
make this more clear with a single level depth toctree.

Tristan Van Berkom authored Aug 25, 2018 and Tristan Van Berkom committed Aug 25, 2018

This is referred to from the artifact install guide, and was
previously pointing directly to the source install guide.

Tristan Van Berkom authored Aug 25, 2018 and Tristan Van Berkom committed Aug 25, 2018

Instead of having all of this on one page, we now have a much
simpler page for installing on distros where BuildStream is packaged
and a separate page for installing distro specific system dependencies
and installing from source code (either from PyPI or git).

Tristan Van Berkom authored Aug 25, 2018 and Tristan Van Berkom committed Aug 25, 2018

This is not ideal as the releases are hardcoded, but I think is better
than nothing until we got a solution to automate this

This commit was originally by Javier Jardón <jjardon@gnome.org> from
merge request !661, and then later reworked into an install guide refactor.

Tristan Van Berkom authored Aug 25, 2018 and Tristan Van Berkom committed Aug 25, 2018

This obsoletes Laurence's explanation in merge request !657, and
is a part of the initiative of issue #528 to clarify which versions
users should be installing.

Install guide refactoring

See merge request !733

Javier Jardón authored Aug 24, 2018 and Tristan Van Berkom committed Aug 26, 2018

This fixes the following:
"
/home/jjardon/buildstream/buildstream/doc/bst2html.py:32: DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated, and in 3.8 it will stop working
  from collections import Mapping
"

doc/bst2html.py: Fix deprecation warning

See merge request !727

Tristan Van Berkom authored Aug 26, 2018 and Tristan Van Berkom committed Aug 26, 2018

This hasnt been working for a while, it might be because GitLab
doesnt quite grasp that we have multiple branches to merge MRs to,
or it might be because they have change the API and broken back compat
in some way.

See: https://docs.gitlab.com/ee/ci/examples/code_quality.html

.gitlab-ci.yml: Trying to fix code quality reports

See merge request !735

And also refer to the user guide section instead of directly to the
tutorial, the tutorial will still be the first section of the user
guide so this is a better link target for getting started.

This is related to #528

README.rst: Use stronger language to follow the installation guide.

See merge request !736

This reverts commit bea01531.

This reverts commit da19bcf1.

This job always takes a long time and does not really depend
on the artifacts in the 'test' phase, moving it to the 'test'
phase will reduce overall CI time.

Tristan/restore post merge ci

See merge request !737

The previous wording was misleading and caused one to think you can run
BuildStream on Windows, this commit fixes that and rewords the main section
heading to be a bit more abstract.

Fixes issue #608

doc/source/main_install.rst: Clarify that BuildStream cannot be run on Windows

Closes #608

See merge request !739

For uncached workspaced elements, assemble is required even just to
calculate the cache key. As dynamic scheduling relies on cache keys,
schedule assemble for uncached workspace elements even if they have not
been marked as required yet.

Fixes #461.

Valentin David authored Aug 15, 2018 and Jürg Billeter committed Aug 28, 2018

This adds a regression test for #461.

Fix key invalidation for workspaced dependencies

Closes #461

See merge request !740

Tristan Van Berkom authored Aug 28, 2018 and Jürg Billeter committed Aug 28, 2018

Removed redundant tests from recently merged !740, this new
test does not need to run for every different source kind.

tests/frontend/workspaces.py: Removing some redundant tests

See merge request !741

Some pycodestyle (PEP8) fixes

See merge request !746

Tristan Van Berkom authored Aug 28, 2018 and Tristan Van Berkom committed Aug 29, 2018

This adds a step to the docs generation Makefile to generate
release.svg and snapshot.svg badges, modelled after the gitlab
badges.

This also adds the generated badges directory in docs to .gitignore

Tristan Van Berkom authored Aug 28, 2018 and Tristan Van Berkom committed Aug 29, 2018

This is a part of #528

Tristan Van Berkom authored Aug 28, 2018 and Tristan Van Berkom committed Aug 29, 2018

This is a part of #528

Release badges

See merge request !742

Chandan Singh authored Aug 24, 2018 and Tristan Van Berkom committed Aug 29, 2018

- setup.py: List useful links using `project_urls`

- setup.py: Specify minumum python vresion using `python_requires`

  `python_requires` is the new way of specifying requirements for python
  version, as documented @
  https://packaging.python.org/guides/distributing-packages-using-setuptools/#python-requires.

  This will also make this requirement appear nicely on the PyPI project
  page.

- setup.py: Add project classifiers

  PyPI will use these classifiers to categorize projects while searching
  or browsing. Full list of classifiers can be found at
  https://pypi.org/classifiers.

setup.py: Add more metadata useful for PyPI

See merge request !718

Qinusty authored Aug 29, 2018 and Tristan Van Berkom committed Aug 29, 2018

Fixes #597

Fix ValueError traceback for URL without alias or URI scheme

Closes #597

See merge request !700

Disable round-tripping when element is not modified

See merge request !748

Log not-found objects in the cache as SKIPPED

See merge request !729

Qinusty authored Aug 23, 2018 and Qinusty committed Aug 29, 2018

This aims to address #600, this will raise an exception when a resolved
variable contains a reference to the variable.

Qinusty authored Aug 29, 2018 and Qinusty committed Aug 29, 2018

Note: This modifies the docker containers used for testing to supply the
pytest-timeout package.

Add cyclic check within variable resolution

See merge request !712

There is no reason that the filter element codepaths can behave
differently depending on the Source implementation used in the test,
as the Source implementation does not have any filter specific
virtual methods.

Removing the redundant tests and just performing these tests with the git source.

tests/plugins/filter.py: Don't run redundant tests

See merge request !753

This test was skipped because of issue #538, but #538 was fixed
and the test was still not reenabled.

tests/frontend/mirror.py: Reenable test_mirror_fetch_upstream_absent[ostree]

See merge request !755

Added some comments to make the flow easier to follow, and
removed an annoying 'success' variabled in favor of a for / else
loop statement.

This was sitting in the section for abstract methods, but this
is most definitely not an abstract method to be implemented by
Sources.

This was displaying the aliased URL which is pretty useless,
use the translated URL for the timed activity.

Minor code changes revolving around source mirroring

See merge request !758

Failures to write files when tracking were not reported.

Fixes #533.

Report processing errors from tracking

Closes #533

See merge request !747

This is causing issues while the size file is being read and written
simultaneously.

The proper fix will be to read/add/save the file atomically and that
will require locking, but this fix is a good stop gap to existing crashes.

_artifactcache/artifactcache.py: Write the cache_size file atomically

See merge request !762

Replacing string 'bzr' with value from host tools

See merge request !764

Explicitly check that project.conf contains a name. This resolves
the issue of the provenance check from _yaml.py incorrectly reporting
the offending file as the default_config_node projectconfig.yaml
when no name key exists in the pre_config_node dict.

buildstream/_project.py: Report if project.conf is missing name

See merge request !680

This adjusts the message handler for the child processes to no longer
override the message type.

This also removes the ability for unhandled non BstError exceptions to
retry.

Retries log as failures

See merge request !766

This prevents the cache_size.pid.log files from cluttering the root
log directory.

Move cache_size.pid.log files into a subdirectory of logs

See merge request !769

Also highlight the fact that the plugin can rely on the fetcher's
fetch() method getting called before consuming the next item in the
list, which is the magick behavior that the git plugin relies on.

This is a part of #620

A download URL must be interpreted by the core at `Plugin.configure()`
time, even if only employed later on.

This is a part of #620

Keeps track of whether the plugin is currently being configured.

Adjusted Element and Source classes to call _configure() in place
of calling configure() directly.

This is a part of #620

The Source must now mention whether the marked or translated
URL is "primary" or not. Even when a Source may have multiple
URLs, the auxilliary URLs are derived from the primary one, not
only is this true for git, but it is mandated by our tracking
API which assumes there is a primary URL.

This adjusts the `git` source and the test `fetch_source.py` source
to behave properly and advertize it's primary URL properly.

This is a part of #620

This cannot test for unaliased URLs, as those can be discovered later
on outside of user provided element configuration; at least we
assert that if an alias was used, we have seen it at load time.

This will cause a BUG to occur for a plugin which marks an aliased
URL (or attempts to translate one) outside of `Plugin.configure()`,
if that URL was not previously seen.

This is a part of #620

Source fetcher changes

See merge request !772

Add a helper function assert_ref_in_track to git.py GitMirror()
which is used when staging & initing the source workspace. It
checks the element's ref exists in the track (branch/tag) if it
has been specified, raising a warning if necessary. The warning makes
use of the warning token 'REF_NOT_IN_TRACK' from the configurable
CoreWarnings. If the element has been tracked with bst, it is assumed
that the value of ref exists in the track as it was generated from it
& as such is not asserted.

Add tests that cover assert_ref_in_track & the configurable
CoreWarnings REF_NOT_IN_TRACK warnings token.

plugins/git.py: Warn if ref is not in given track

See merge request !564

This example allows you to build in a folder out side of the folder that
contains your source code.

It dose this by moving your source code to a sub directory of build-root
and then running the build commands in a different sub directory of
build-root.

The hello.o and hello files can be rebuild while the libhello.o file is
preserved and reused.

Trying to get autotools element to use standard variables for out of
source builds.