Make Sstern a frontend maintainer
Reasons For
- Experience with Graphql features on FE.
- Experience working on security issues
- Always learning and trying to improve personally to make my reviews and areas of the codebase I touch better.
- Lots of experience with different licensing features and licensing architectural practices around
- When reviewing try to acquire context how the MR effects the rest of the fe org and features.
Reasons Against
- Still learning more about graphql/apollo/vue best practices
- Still learning and improving test practices for components and integration specs.
- Have had a few FOSS issues go into master that needed to be reverted. (def learned my lesson)
- When swamped need to be better about putting up the red dot and commenting immediately of when i can actually take the time to review an MR.
Links to Non-Trival MRs I've Reviewed
- Update redirect behavior of Edit Release page
- Resolve "(Un)Assign Issue to/from Comment Author Action Visibility"
- Add a button to quickly assign users who have commented on an issue
- Consolidate issuable_header_warning for both MR and issue
- Toggle Epic Confidential
- MR widget instructions are unclear when merge trains are enabled
- Add a rudimentary Finite State Machine implementation
- Add frontend validation to "Restrict access by IP address" field in Group -> Settings -> General -> Permissions, LFS, 2FA
- Swimlanes - Fetch issues using GraphQL endpoint
- Updated blob rendering in case of a render error
- Add UI to load the full file for
renamed
-type files
Links to Non-Trivial MRs I've Written
- Fix toggling a task inside a collapsible section collapses all sections
- Add Toggle to Issue/MR
- Realtime Assignees First Iteration
- Add confidential and locked discussion vue components for issue header
- Add iteration title/value to Issue sidebar
- Add apollo to confidential in issue sidebar
- Connect confidential component to notes store
Links to Other Work that I Believe to be valuable
- Helped in leading the conversion from underscore to lodash
- Remove mixin from recommended approach in docs
- Migrate Vue Slot Attribute to use v-slot directive for Vue 3 Migration - In Progress
@gitlab-org/maintainers/frontend please chime in below with your thoughts, and approve this MR if you agree.
Once This MR is Merged
-
Create an access request for maintainer access to gitlab-org
. -
Create an access request to be added to the [at]frontend-maintainers
slack group -
Let a maintainer add you to gitlab-org/maintainers/frontend
-
Announce it everywhere -
Keep reviewing, start merging 🤘 😎 🤘
Edited by Denys Mishunov