Skip to content

Make Sstern a frontend maintainer

Scott Stern requested to merge sstern-maintainer into master

Reasons For

  • Experience with Graphql features on FE.
  • Experience working on security issues
  • Always learning and trying to improve personally to make my reviews and areas of the codebase I touch better.
  • Lots of experience with different licensing features and licensing architectural practices around
  • When reviewing try to acquire context how the MR effects the rest of the fe org and features.

Reasons Against

  • Still learning more about graphql/apollo/vue best practices
  • Still learning and improving test practices for components and integration specs.
  • Have had a few FOSS issues go into master that needed to be reverted. (def learned my lesson)
  • When swamped need to be better about putting up the red dot and commenting immediately of when i can actually take the time to review an MR.

Links to Non-Trival MRs I've Reviewed

Links to Non-Trivial MRs I've Written

Links to Other Work that I Believe to be valuable

@gitlab-org/maintainers/frontend please chime in below with your thoughts, and approve this MR if you agree.

Once This MR is Merged

  1. Create an access request for maintainer access to gitlab-org.
  2. Create an access request to be added to the [at]frontend-maintainers slack group
  3. Let a maintainer add you to gitlab-org/maintainers/frontend
  4. Announce it everywhere
  5. Keep reviewing, start merging 🤘 😎 🤘
Edited by Denys Mishunov

Merge request reports