Skip to content

Add toggle to issue/MR discussion sort order

Scott Stern requested to merge ss/sort-issue into master

What does this MR do?

Addresses the frontend first pass of #14588 (closed)

This is first pass on the frontend for sorting discussions in MR's and Issue pages under a FF. After this is merged in backend will work on adding the correct functionality to make this feature persists across users.

Repro:

  • rails c
  • Feature.enable(:sort_discussions)
  • Go to an MR and an Issue
  • Toggle between "Newest First" and "Oldest First"

Things to note:

  • Adding another button to the "Show All Activity" and the "Create Merge Request" Section is making the ui glitch a little bit while fetching some resources.

image

  • Style of the timeline feels off when we toggle to Newest First in terms of the timeline extending beyond the notes app, im not sure how UX wants to handle this.

image

Screenshots

2020-03-10_12.31.57

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Coung Ngo

Merge request reports