Consolidate issuable_header_warning for both MR and issue
What does this MR do?
- Make use of
issuable_header_warningcomponent for displaying the confidentality/locked icon in the header in a MR page. - Separate out
issuable_header_warningas a shared Vue component - Include
discussion_lockedfield in the noteable data when initializing the mr_notes store.
Screenshots
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Issue #19411 (closed)
Edited by euko