Skip to content

Add frontend validation to "Restrict access by IP address" field in Group -> Settings -> General -> Permissions, LFS, 2FA

What does this MR do?

See #227442 (closed)

Adds frontend validation to the "Restrict access by IP address" field to improve UX

Screenshots

Before

Screen_Recording_2020-08-10_at_8.33.57_AM

After

Screen_Recording_2020-08-10_at_8.31.55_AM

Local Testing

  1. Install a GitLab Silver License
  2. Create a new group
  3. Navigate to your group -> "Settings" -> "General" -> "Permissions, LFS, 2FA"

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Peter Hegman

Merge request reports