Reset templates cache key
What does this MR do?
This resets description templates cache key, thus making templates being reloaded and recached with the correct format. The problem appeared when we deployed !52360 (merged) (merged) where we should have changed the cache key as here we are filtering templates by project_id which is not yet present in the returned hash introduced in !52222 (diffs) but there the project_id
is always nil
Here is a production snippet run for Gitlab project
repository_cache = Gitlab::RepositoryCache.new(Project.find(278964).repository)
repository_cache.fetch(:merge_request_template_names_by_category)
=> {
"" =>[
{:name=>"Change Documentation Location", :id=>"Change Documentation Location", :key=>"Change Documentation Location", :project_id=>nil},
{:name=>"Documentation", :id=>"Documentation", :key=>"Documentation", :project_id=>nil},
{:name=>"New End To End Test", :id=>"New End To End Test", :key=>"New End To End Test", :project_id=>nil},
{:name=>"New Static Analysis Check", :id=>"New Static Analysis Check", :key=>"New Static Analysis Check", :project_id=>nil},
{:name=>"Security Release", :id=>"Security Release", :key=>"Security Release", :project_id=>nil}
]
}
You can note the :project_id=>nil
in the result, which makes the list of templates to be empty.
Screenshots (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Merge request reports
Activity
added backend label
Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
Category Reviewer Maintainer backend Pavel Shutsin ( @pshutsin
) (UTC+3, 1 hour ahead of@acroitor
)Mayra Cabrera ( @mayra-cabrera
) (UTC-6, 8 hours behind@acroitor
)If needed, you can retry the
danger-review
job that generated this comment.Generated by
🚫 DangerEdited by 🤖 GitLab Bot 🤖Setting label groupproject management based on
@acroitor
's group.added groupproject management label
Setting label(s) devopsplan sectiondev based on groupproject management.
added devopsplan sectiondev labels
added typebug label
added 245 commits
-
2ef79033...bb9e095a - 244 commits from branch
master
- f2fc0279 - Reset templates cache key
-
2ef79033...bb9e095a - 244 commits from branch
changed milestone to %13.9
marked the checklist item Changelog entry as completed
- Resolved by Alexandru Croitor
@pshutsin would you have time to take a quick look at this MR ?
assigned to @brytannia and unassigned @acroitor
assigned to @acroitor
on a short sync call @acroitor provided more details about this MR: we need to rename methods and corresponding Redis keys to invalidate current cache that doesn't have
project_id
.Changes looks good to me!
🚀 unassigned @brytannia
mentioned in issue #322078 (closed)
changed milestone to %13.10
added missed:13.9 label
assigned to @ashmckenzie
LGTM, thanks @acroitor and thanks @brytannia for the context
🙂 mentioned in commit 70f548cf
added workflowstaging label and removed workflowvalidation backlog label
removed missed:13.9 label
added workflowcanary label and removed workflowstaging label
mentioned in issue #322399 (closed)
added workflowproduction label and removed workflowcanary label
picked the changes into the branch
13-9-stable-ee-patch-1
with commit 1f77c453mentioned in commit 1f77c453
Automatically picked into !54919 (merged), will merge into
13-9-stable-ee
ready for13.9.1-ee
.mentioned in merge request !54919 (merged)
added releasedcandidate label
added Category:Team Planning label