Stop passing type to Feature methods

What does this MR do and why?

There's no need to pass the :type when calling Feature#enabled?/Feature#disabled? as the type is set in feature flag definition files and doesn't have any impact in these methods' behavior.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

• I have evaluated the MR acceptance checklist for this MR.

changed milestone to %16.5

added maintenancepipelines typemaintenance labels

assigned to @rymai

added backend label

added 1 commit

• b71be322 - Stop passing type to Feature methods

Compare with previous version

added rspec:slow test detected label

E2E Test Result Summary

allure-report-publisher generated test report!

e2e-test-on-gdk: test report for 343ad074

expand test summary

+------------------------------------------------------------------+
|                          suites summary                          |
+-------------+--------+--------+---------+-------+-------+--------+
|             | passed | failed | skipped | flaky | total | result |
+-------------+--------+--------+---------+-------+-------+--------+
| Create      | 54     | 0      | 7       | 0     | 61    | ✅     |
| Package     | 4      | 0      | 1       | 0     | 5     | ✅     |
| Plan        | 55     | 0      | 0       | 0     | 55    | ✅     |
| Govern      | 74     | 0      | 0       | 0     | 74    | ✅     |
| Data Stores | 23     | 0      | 0       | 0     | 23    | ✅     |
| Monitor     | 7      | 0      | 0       | 0     | 7     | ✅     |
| Analytics   | 2      | 0      | 0       | 0     | 2     | ✅     |
| Verify      | 31     | 0      | 0       | 0     | 31    | ✅     |
| Release     | 5      | 0      | 0       | 0     | 5     | ✅     |
| Manage      | 0      | 0      | 1       | 0     | 1     | ➖     |
+-------------+--------+--------+---------+-------+-------+--------+
| Total       | 255    | 0      | 9       | 0     | 264   | ✅     |
+-------------+--------+--------+---------+-------+-------+--------+

e2e-package-and-test: test report for 343ad074

expand test summary

+---------------------------------------------------------------------+
|                           suites summary                            |
+----------------+--------+--------+---------+-------+-------+--------+
|                | passed | failed | skipped | flaky | total | result |
+----------------+--------+--------+---------+-------+-------+--------+
| Data Stores    | 119    | 0      | 1       | 0     | 120   | ✅     |
| Govern         | 298    | 0      | 20      | 4     | 318   | ✅     |
| Create         | 549    | 2      | 67      | 8     | 618   | ❌     |
| Verify         | 138    | 0      | 27      | 6     | 165   | ✅     |
| Plan           | 249    | 0      | 10      | 3     | 259   | ✅     |
| Manage         | 40     | 0      | 10      | 1     | 50    | ✅     |
| Package        | 226    | 0      | 17      | 0     | 243   | ✅     |
| Systems        | 8      | 0      | 0       | 0     | 8     | ✅     |
| Monitor        | 36     | 0      | 13      | 0     | 49    | ✅     |
| ModelOps       | 0      | 0      | 6       | 0     | 6     | ➖     |
| Fulfillment    | 8      | 0      | 69      | 0     | 77    | ✅     |
| Analytics      | 7      | 0      | 0       | 0     | 7     | ✅     |
| GitLab Metrics | 2      | 0      | 1       | 0     | 3     | ✅     |
| Release        | 15     | 0      | 3       | 0     | 18    | ✅     |
| Configure      | 1      | 0      | 9       | 0     | 10    | ✅     |
| Secure         | 6      | 0      | 3       | 0     | 9     | ✅     |
| Growth         | 0      | 0      | 6       | 0     | 6     | ➖     |
+----------------+--------+--------+---------+-------+-------+--------+
| Total          | 1702   | 2      | 262     | 22    | 1966  | ❌     |
+----------------+--------+--------+---------+-------+-------+--------+

marked this merge request as draft

changed milestone to %16.6

added missed:16.5 label

added 6214 commits

• b71be322...3f3cbabb - 6213 commits from branch master
• 99e99578 - Stop passing type to Feature methods

Compare with previous version

	1 Warning
	10f1ee58: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines.

Reviewer roulette

Changes that require review have been detected!

Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:

Category	Reviewer	Maintainer
backend	@akotte (UTC+5.5, 4.5 hours ahead of author)	@stanhu (UTC-8, 9 hours behind author)

Please check reviewer's status!

• Reviewer is available!
• Reviewer is unavailable!

Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.

If needed, you can retry the danger-review job that generated this comment.

Generated by Danger

marked this merge request as ready

changed the description

@ayufan @tkuah Could you please review? Thanks!

changed milestone to %16.7

added Engineering Productivity label and removed missed:16.5 label

requested review from @ayufan and @tkuah

approved this merge request

@tkuah, thanks for approving this merge request.

This is the first time the merge request has been approved. To ensure we don't only run predictive pipelines, and we don't break master, a new pipeline will be started shortly.

Please wait for the pipeline to start before resolving this discussion and set auto-merge for the new pipeline. See merging a merge request for more details.