Add Metrics Dashboard GraphQL alert queries to FF
What does this MR do and why?
This MR gates the metrics dashboard graphql alert queries behind the remove_monitor_metrics
feature flag. The frontend feature that used this field was actually removed a very long time ago. But we also want to deprecate/remove any API access.
Related issue: Metrics: Delete API entrypoints & helpers (#397138 - closed) (one of many MRs)
Context for removal:
- The Metrics Dashboard feature is being removed in %16.0.
- Feature docs: https://docs.gitlab.com/ee/operations/metrics
- Removal issue: Monitor: Metrics Deprecation and Removal (&10107)
- Most of the metrics dashboard frontend is currently behind the
remove_monitor_metrics
flag, but the flag has not yet been enabled. It needs to be enabled by default in time for %16.0.- The entire frontend should be behind the flag in order to enable it by default, but the API can merge after - as long as we make all breaking changes within %16.0.
- Rollout issue: [Feature flag] Rollout of `remove_monitor_metrics` (#399248)
- Tracking issue: Metrics: hide deprecated modules behind a featu... (#399231 - closed)
- Enable-by-default MR: Set remove_monitor_metrics flag to true (!119989 - merged)
backend MRs to flag all metrics dashboard endpoints
All related- Add Metrics Dashboard annnotations API to FF (!120286 - merged)
- Add Metrics Dashboard starred dashboard API to FF (!120288 - merged)
- Add Metrics Dashboard templates viewer to FF (!120289 - merged)
- Add Metrics Dashboard environments API to FF (!120299 - merged)
- Add Metrics Dashboard settings API to FF (!120305 - merged)
- Add Metrics Dashboard GraphQL alert queries to FF (!120307 - merged)
- Add Metrics Dashboard embed pipeline to FF (!120310 - merged)
- Add Metrics Dashboard for internal dashboard en... (!120313 - merged)
- Add Metrics Dashboard base API to FF (!120316 - merged)
How to set up and validate locally
** pre-req: project with an environment
- Create a prometheus alert with the right attributes via the rails console
environment = Environment.last project = environment.project payload = JSON.parse({ "labels": { "gitlab_environment_name": environment.name }, "status": "firing", "startsAt": "2021-03-17T11:22:40Z", "annotations": { "title": "Testing that prometheus alerts do not re-acknowledge", "gitlab_y_label": "status" }, "generatorURL": "http://host?g0.expr=up" }.to_json) AlertManagement::ProcessPrometheusAlertService.new(project, payload).execute
- Use
http://gdk.test:3000/-/graphql-explorer
to query for alert details
Query | Response before | Response after |
---|---|---|
|
|
|
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
changed milestone to %16.0
assigned to @syasonik
- A deleted user
added documentation label
1 Message This merge request adds or changes documentation files. A review from the Technical Writing team before you merge is recommended. Reviews can happen after you merge. Documentation review
The following files require a review from a technical writer:
-
doc/api/graphql/reference/index.md
(Link to current live version)
The review does not need to block merging this merge request. See the:
-
Metadata for the
*.md
files that you've changed. The first few lines of each*.md
file identify the stage and group most closely associated with your docs change. - The Technical Writer assigned for that stage and group.
- Documentation workflows for information on when to assign a merge request for review.
Multiversion compatibility
This merge request updates GraphQL backend and frontend code.
To prevent an incident, ensure the updated frontend code is backwards compatible.
For more information, see the multiversion compatibility documentation.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Piotr Skorupa (
@pskorupa
) (UTC+2, 6 hours ahead of@syasonik
)Dylan Griffith (
@DylanGriffith
) (UTC+10, 14 hours ahead of@syasonik
)frontend Laura Meckley (
@lmeckley
) (UTC-6, 2 hours behind@syasonik
)Jose Ivan Vargas (
@jivanvl
) (UTC-6, 2 hours behind@syasonik
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger-
mentioned in merge request !120286 (merged)
mentioned in merge request !120288 (merged)
mentioned in merge request !120289 (merged)
mentioned in merge request !120299 (merged)
mentioned in merge request !120305 (merged)
mentioned in merge request !120309 (closed)
mentioned in merge request !120310 (merged)
mentioned in merge request !120313 (merged)
mentioned in merge request !120316 (merged)
- A deleted user
added frontend label
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 350205ac and 2ab89839
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.03 MB 4.03 MB - 0.0 % mainChunk 2.88 MB 2.88 MB - 0.0 %
Note: We do not have exact data for 350205ac. So we have used data from: abd62edb.
The target commit was too new, so we used the latest commit from master we have info on.
It might help to rerun thebundle-size-review
job
This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.Please look at the full report for more details
Read more about how this report works.
Generated by
DangerAllure report
allure-report-publisher
generated test report!e2e-review-qa:
test report for 2ab89839expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Plan | 50 | 0 | 1 | 0 | 51 | ✅ | | Govern | 24 | 0 | 0 | 1 | 24 | ❗ | | Verify | 10 | 0 | 0 | 0 | 10 | ✅ | | Data Stores | 22 | 0 | 0 | 0 | 22 | ✅ | | Create | 27 | 0 | 1 | 0 | 28 | ✅ | | Manage | 8 | 0 | 3 | 0 | 11 | ✅ | | Framework sanity | 9 | 0 | 1 | 0 | 10 | ✅ | | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 154 | 0 | 7 | 1 | 161 | ❗ | +------------------+--------+--------+---------+-------+-------+--------+
- Resolved by Rajendra Kadam
@hmehra Assigning this to you per !120310 (comment 1385992476)!
For backend maintainer, let's pick any of:
-
@ck3g
(Germany) -
@splattael
(Germany) -
@rkadam3
(India)
(whoever seems to have capacity or is in the "upcoming" timezone)
Edited by Sarah Yasonik -
requested review from @hmehra
- Resolved by Sarah Yasonik
@msedlakjakubowski Could you look at this MR for documentation?
(Feedback from the other metrics dashboard removals is already pre-incorporated.)
requested review from @msedlakjakubowski
added Technical Writing docsfeature twfinished workflowin review labels
removed review request for @msedlakjakubowski
@msedlakjakubowski
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
added pipeline:mr-approved label
Hi
@msedlakjakubowski
,GitLab Bot has added the Technical Writing label because a Technical Writer has approved or merged this MR.
This message was generated automatically. You're welcome to improve it.
mentioned in issue gitlab-org/monitor/respond#238 (closed)
requested review from @rkadam3
removed review request for @hmehra
added 1279 commits
-
3d662ea4...73d65409 - 1277 commits from branch
master
- b3303d32 - Add Metrics Dashboard GraphQL API to FF
- 2ab89839 - Fix docs phrasing
-
3d662ea4...73d65409 - 1277 commits from branch
enabled an automatic merge when the pipeline for b62414a3 succeeds
mentioned in commit 8b60047e
added workflowstaging-canary label and removed workflowin review label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added releasedcandidate label
added workflowpost-deploy-db-staging label and removed workflowproduction label
mentioned in issue gitlab-org/monitor/respond#241 (closed)
mentioned in merge request kubitus-project/kubitus-installer!2145 (merged)
mentioned in issue gitlab-org/monitor/respond#243 (closed)
mentioned in issue gitlab-org/monitor/respond#244 (closed)
mentioned in issue #397138 (closed)
mentioned in issue gitlab-org/monitor/respond#246 (closed)
mentioned in issue gitlab-com/www-gitlab-com#34038 (closed)
mentioned in issue gitlab-org/monitor/respond#247 (closed)
mentioned in issue gitlab-org/monitor/respond#250 (closed)
mentioned in issue gitlab-org/monitor/respond#251 (closed)
mentioned in issue gitlab-org/monitor/respond#252 (closed)
mentioned in issue gitlab-org/monitor/respond#254 (closed)
mentioned in issue gitlab-org/monitor/respond#259 (closed)
mentioned in issue gitlab-org/monitor/respond#255 (closed)
mentioned in issue gitlab-org/monitor/respond#260 (closed)
mentioned in issue gitlab-org/monitor/respond#263 (closed)
mentioned in issue gitlab-org/monitor/respond#264 (closed)
mentioned in issue gitlab-org/monitor/respond#266 (closed)