Skip to content

Add Metrics Dashboard for internal dashboard endpoints to FF

Sarah Yasonik requested to merge sy-flag-performance-monitoring-dashboard into master

What does this MR do and why?

This MR gates the metrics dashboard performance monitoring controller behind the remove_monitor_metrics feature flag. Frontend is done, but we also want to deprecate/remove any API-only access.

Related issue: Metrics: Delete API entrypoints & helpers (#397138 - closed), (one of many MRs)

Context for removal:

All related backend MRs to flag all metrics dashboard endpoints

How to set up and validate locally

The frontend MR disabling the UI for the the metrics dashboard has already merged. If you really want to manually test the before/after, you can remove the feature flag checks in lib/sidebars/projects/menus/monitor_menu.rb to expose the relevant UI fields to make auth easier.

Pre-req: project with a cluster -> You can mimic this following the instructions from cluster embeds removal

  1. In a project, navigate to Monitor > Metrics.
  2. Click the 3-dot menu & select Duplicate current dashboard. If the option isn't there, switch the dashboard to K8s Pod Health or Overview
  3. With this MR, there should be an error saving the dashboard, as the endpoint 404s

Screenshot_2023-05-10_at_8.11.44_PM

  1. For panel previews, it should be roughly the same, but selecting Create panel from the 3-dot menu

Screenshot_2023-05-10_at_8.21.05_PM

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Vitali Tatarintev

Merge request reports