Skip to content

Add Metrics Dashboard settings API to FF

Sarah Yasonik requested to merge sy-flag-metrics-dashboard-settings into master

What does this MR do and why?

This MR gates the metrics dashboard settings API options behind the remove_monitor_metrics feature flag. Frontend is done, but we also want to deprecate/remove any API access.

Related issue: Metrics: Delete API entrypoints & helpers (#397138 - closed) (one of many MRs)

Context for removal:

All related backend MRs to flag all metrics dashboard endpoints

How to set up and validate locally

The frontend MR disabling the UI for the settings has already merged. If you really want to manually test the before/after, you can remove the feature flag checks in app/views/projects/settings/operations/show.html.haml to expose the relevant UI fields to make auth easier.

  1. In a project, navigate to Settings > Monitor to monkey around with the inputs for metrics/grafana. With this MR, they should just be silently ignored with remove_monitor_metrics is enabled.

Screenshot_2023-05-10_at_4.58.24_PM

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Sarah Yasonik

Merge request reports