Skip to content

Add Metrics Dashboard starred dashboard API to FF

Sarah Yasonik requested to merge sy-flag-metrics-starred-dashboards into master

What does this MR do and why?

This MR gates the metrics dashboard starred dashboards API behind the remove_monitor_metrics feature flag. Frontend is done, but we also want to deprecate/remove any API access.

Related issue: Metrics: Delete API entrypoints & helpers (#397138 - closed) (one of many MRs)

Context for removal:

All related backend MRs to flag all metrics dashboard endpoints

How to set up and validate locally

Request Response before Response after
curl "http://gdk.test:3000/api/v4/projects/9/metrics/user_starred_dashboards?dashboard_path=config%2Fprometheus%2Fcommon_metrics.yml" \
  --header "Authorization: Bearer $TOKEN" \
  --request POST
{
  "id":1,
  "dashboard_path":"config/prometheus/common_metrics.yml",
  "user_id":1,
  "project_id":9
}    
{"message":"404 Not Found"
curl "http://gdk.test:3000/api/v4/projects/9/metrics/user_starred_dashboards?dashboard_path=config%2Fprometheus%2Fcommon_metrics.yml" \
  --header "Authorization: Bearer $TOKEN" \
  --request DELETE
{"deleted_rows":1}
{"message":"404 Not Found"}

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Vitali Tatarintev

Merge request reports