Remove welcome from onboarding step from non SaaS
Summary
Since we introduced the 'ensure onboarding' paradigm in GitLab SaaS, we have noticed an overlap of functionality with an older piece of code that has the affect of showing the self-managed GitLab instances the welcome page part of the onboarding for no apparent value.
Currently on self-managed the sign up flow goes:
- sign up
- verify account
- welcome page to collect role information on the user record in the database.
- explore projects page
discussion with SME
The following discussion from !118831 (merged) should be addressed:
-
@dstull started a discussion: (+2 comments)
@alexbuijs see the description of this issue for background and info...
To solve the issues for trial registrations dropping the params on the welcome page where the role is filled out, we are opting into setting our onboarding redirect setup here.
This will allow us to redirect to the welcome page with the correct params.
I see way back you implemented the required_signup_info method
I'm thinking if I implement this fix then that method becomes not needed.
However, it is in foss/ce and set to be required in the foss registrations controller.
Can you see any reason why we care to make any instance besides the .com(SaaS) instance record this value and therefore go to the welcome page? I looked at your commit there and I think I'd be ok to remove that
required_signup_info
and logic around it once I merge this change as a follow-up.Thoughts?
Plan
Remove the welcome page from the self-managed instance(CE and EE) sign-up flow(step 3 from above)