Skip to content

Add SaaS guard on onboarding controllers

Doug Stull requested to merge 411858-add-saas-guards-on-welcome into master

What does this MR do and why?

Add SaaS guard on onboarding controller

  • route should not be available to non SaaS installations

How to set up and validate locally

Non SaaS

  1. Ensure GDK is not setup to simulate SaaS
  2. Disable check_namespace_plan in rails console
    • ApplicationSetting.first.update(check_namespace_plan: false)
  3. Restart GDK
  4. Attempt to navigate to any of the controller actions in this change and see it be denied.

SaaS (no behavior change)

  1. Ensure GDK is setup to simulate SaaS
  2. Enable check_namespace_plan in rails console
    • ApplicationSetting.first.update(check_namespace_plan: true)
  3. Restart GDK
  4. Attempt to navigate to any of the controller actions in this change and notice access to them is the same.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #411858 (closed)

Edited by Doug Stull

Merge request reports