Remove role required before action
What does this MR do and why?
Remove role required before action
- CE no longer need to fill out the welcome form.
- EE will still be directed to welcome page, but will eventually be removed via next MR in !129528 (merged)
- EE with SaaS is forced to fill it out via ensure_onboarding paradigm
Screenshots or screen recordings
See screenshots on #411858 (closed) an further description
How to set up and validate locally
coverage in spec/features/users/signup_spec.rb
and ee/spec/features/registrations/saas
show full process - one way to validate seen below
- Register as a new user.
- Confirm email by finding the confirmation path from last User created in
rails console
Rails.application.routes.url_helpers.user_confirmation_path(confirmation_token: User.last.confirmation_token)
- Verify landing in welcome page after verification/sign up.
- Attempt to go to root path (/)
- Validate not redirected back to welcome. If you are, it is because you are setup to emulate SaaS and you should turn that off to verify here.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #411858 (closed)
Merge request reports
Activity
changed milestone to %Backlog
assigned to @dstull
- A deleted user
added backend label
2 Warnings This MR changes code in ee/
, but its Changelog commit is missing theEE: true
trailer. Consider adding it to your Changelog commits.featureaddition and featureenhancement merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the Technical Writer counterpart.
For more information, see:
- The Handbook page on merge request types.
- The definition of done documentation.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Aakriti Gupta (
@aakriti.gupta
) (UTC+5.5, 9.5 hours ahead of@dstull
)Drew Blessing (
@dblessing
) (UTC-5, 1 hour behind@dstull
)test for spec/features/*
Aakriti Gupta (
@aakriti.gupta
) (UTC+5.5, 9.5 hours ahead of@dstull
)Maintainer review is optional for test for spec/features/*
~"group::authentication and authorization" Reviewer review is optional for ~"group::authentication and authorization" Jessie Young (
@jessieay
) (UTC+9, 13 hours ahead of@dstull
)Please check reviewer's status!
Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangermentioned in issue #414971 (closed)
- Resolved by Doug Stull
@dstull Some end-to-end (E2E) tests should run based on the stage label.
Please start the
trigger-omnibus-and-follow-up-e2e
job in theqa
stage and ensure tests in thefollow-up-e2e:package-and-test-ee
pipeline pass before this MR is merged. (E2E tests are computationally intensive and don't run automatically for every push/rebase, so we ask you to run this job manually at least once.)To run all E2E tests, apply the pipeline:run-all-e2e label and run a new pipeline.
E2E test jobs are allowed to fail due to flakiness. See current failures at the latest pipeline triage issue.
Once done, apply the
emoji on this comment.For any questions or help, reach out on the internal #quality Slack channel.
Allure report
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for 7cfac1cdexpand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Govern | 34 | 0 | 0 | 0 | 34 | ✅ | | Create | 38 | 0 | 0 | 2 | 38 | ❗ | | Manage | 12 | 0 | 1 | 0 | 13 | ✅ | | Plan | 47 | 0 | 0 | 0 | 47 | ✅ | | Data Stores | 20 | 0 | 0 | 0 | 20 | ✅ | | Verify | 8 | 0 | 0 | 0 | 8 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 159 | 0 | 1 | 2 | 160 | ❗ | +-------------+--------+--------+---------+-------+-------+--------+
mentioned in issue #422538 (closed)
added 343 commits
-
317270ee...44151ce4 - 342 commits from branch
master
- 7cfac1cd - Remove role required before action
-
317270ee...44151ce4 - 342 commits from branch
- Resolved by Jarka Košanová
- Resolved by Jarka Košanová
- Resolved by Jarka Košanová
- Resolved by Jarka Košanová
- Resolved by Jarka Košanová
- Resolved by Jarka Košanová
- Resolved by Jarka Košanová
changed milestone to %16.4
marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed
- Resolved by Jarka Košanová
@eugielimpin can you review backend and test here? (great pick due to your experience in registration)
Afterwards if you can pass it onto a ~"group::authentication and authorization" member for maintainer review that would be great as they have a mandatory approval on this MR.
requested review from @eugielimpin
added workflowin review label and removed workflowin dev label
mentioned in issue #419423 (closed)
- Resolved by Jarka Košanová
- Resolved by Jarka Košanová
Confirmed working locally:
requested review from @jarka and removed review request for @eugielimpin
@eugielimpin
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
added pipeline:mr-approved label
enabled an automatic merge when the pipeline for 33803656 succeeds
mentioned in commit b390f9ea
added workflowstaging-canary label and removed workflowin review label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
mentioned in issue gitlab-com/www-gitlab-com#13797 (closed)