Skip to content
Snippets Groups Projects

Remove role required before action

Merged Doug Stull requested to merge 411858-remove-role-required-redirect into master

What does this MR do and why?

Remove role required before action

  • CE no longer need to fill out the welcome form.
  • EE will still be directed to welcome page, but will eventually be removed via next MR in !129528 (merged)
  • EE with SaaS is forced to fill it out via ensure_onboarding paradigm

Screenshots or screen recordings

See screenshots on #411858 (closed) an further description

How to set up and validate locally

coverage in spec/features/users/signup_spec.rb and ee/spec/features/registrations/saas show full process - one way to validate seen below

  1. Register as a new user.
  2. Confirm email by finding the confirmation path from last User created in rails console
    • Rails.application.routes.url_helpers.user_confirmation_path(confirmation_token: User.last.confirmation_token)
  3. Verify landing in welcome page after verification/sign up.
  4. Attempt to go to root path (/)
  5. Validate not redirected back to welcome. If you are, it is because you are setup to emulate SaaS and you should turn that off to verify here.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #411858 (closed)

Edited by Doug Stull

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Doug Stull
  • Doug Stull
  • Doug Stull
  • Doug Stull
  • Doug Stull
  • Doug Stull
  • Doug Stull changed milestone to %16.4

    changed milestone to %16.4

  • Doug Stull marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed

    marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed

  • Doug Stull changed the description

    changed the description

  • Doug Stull requested review from @eugielimpin

    requested review from @eugielimpin

  • Doug Stull marked this merge request as ready

    marked this merge request as ready

  • Doug Stull added workflowin review label and removed workflowin dev label

    added workflowin review label and removed workflowin dev label

  • mentioned in issue #419423 (closed)

  • Eugie Limpin
  • Eugie Limpin
  • Eugie Limpin approved this merge request

    approved this merge request

  • Eugie Limpin requested review from @jarka and removed review request for @eugielimpin

    requested review from @jarka and removed review request for @eugielimpin

  • :wave: @eugielimpin, thanks for approving this merge request.

    This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.

    For more info, please refer to the following links:

  • Jarka Košanová resolved all threads

    resolved all threads

  • Jarka Košanová approved this merge request

    approved this merge request

  • Jarka Košanová enabled an automatic merge when the pipeline for 33803656 succeeds

    enabled an automatic merge when the pipeline for 33803656 succeeds

  • Jarka Košanová mentioned in commit b390f9ea

    mentioned in commit b390f9ea

  • added workflowstaging label and removed workflowcanary label

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading