Convert .com? checks in the registration flow to ::Gitlab::Saas.feature_available?
Summary
Today we use a .com?
check to know if we are on SaaS or not during certain places in the registration flow. We should instead rely on the ::Gitlab::Saas.feature_available?
check as it encapsulates the concern of if something is subscriptions related or not and everything in the registration flow where we have these checks is geared towards that subscription concept.
Plan
-
Convert the Onboarding::Status#enabled?
method to use this logic - !129423 (merged) -
Switch broadcast message hide logic to use during sign in/sign up - see !128630 (diffs, comment 1503067188) - !129423 (merged) -
app/services/users/signup_service.rb
should switch over to use this too once it moves toee
after welcome controller moves via #411858 (closed) - !133135 (merged) -
move app/services/users/signup_service.rb
toee
- !133334 (merged) -
convert controllers in registration that currently use the new check - !129423 (merged)
Edited by Doug Stull