2019-12-09 - Triage report for "group::source code"

Hi, @jramsay @m_gill @andr3 @nick.thomas

This is a group or stage level triage package that aims to summarize the feature proposals and bugs which have not been scheduled or triaged. For more information please refer to the handbook:

  • https://about.gitlab.com/handbook/engineering/quality/triage-operations/index.html#triage-packages

Scheduling the workload is a collaborative effort by the Product Managers and Engineering Managers for that group. Please work together to provide a best estimate on priority and milestone assignments. For each issue please:

  • Determine if the issue should be closed if it is no longer relevant or a duplicate.
  • If it is still relevant please assign either a best estimate versioned milestone, the %Backlog or the %Awaiting further demand milestone.
  • Specifically for ~bug, if there is no priority or clarity on a versioned milestone, please add a Priority label. Priority labels have an estimate SLO attached to them and help team members and the wider community understand roughly when it will be considered to be scheduled.
    • https://docs.gitlab.com/ee/development/contributing/issue_workflow.html#priority-labels
  • Once a milestone has been assigned please check off the box for that issue.
  • Please work with your team to complete the list by the due date set.

Feature Proposal Section

For the following feature proposals. Please either close or assign either a versioned milestone, the %Backlog or the %Awaiting further demand milestone.

Unscheduled feature with customer

  • #37942 Instance- or group-wide setting for remove_source_branch_after_merge customer, devopscreate, feature, groupsource code, merge requests, settings
  • #37292 Allow to pass merge_when_pipeline_succeeds=true when creating merge request via the API api, customer, devopscreate, feature, groupsource code, merge requests
  • #37090 (closed) Allow rails to send certificate for 2-way SSL backend, customer, devopscreate, feature, groupsource code
  • #36918 Provide "show more results" option when results set limit is reached approvals, customer, devopscreate, feature, groupsource code, merge requests
  • #36613 Allow distinct approvers for merge rules approvals, customer, devopscreate, feature, groupsource code
  • #36485 Allow specifying rule when approving merge requests approvals, customer, devopscreate, feature, groupsource code
  • #36398 (closed) Configurable MR Diff Limit api, customer, devopscreate, feature, groupsource code, merge requests
  • #35565 Verified commits push rule check customer, devopscreate, feature, groupsource code, settings
  • #35266 Enforece merge method at group and instance level Category:Source Code Management, customer, devopscreate, feature, groupsource code
  • #35097 (closed) "Code owner approval" does not honor "Allowed to push" rule ~"Category:Code Review", Enterprise Edition, ~"P3", ~"S3", approvals, customer, devopscreate, feature, groupsource code, merge requests
  • #26152 Improve progress reporting of repository mirroring Create [DEPRECATED], customer, devopscreate, feature, groupsource code, ~"mirror", repository
  • #5010 (closed) META: Code review flow which doesn't rely on manual assignment Create [DEPRECATED], Enterprise Edition, GitLab Premium, UX, customer, devopscreate, direction, feature, groupsource code, merge requests
  • #21014 (closed) Add ability to filter out merge requests opened by current user Create [DEPRECATED], customer, devopscreate, feature, groupsource code, merge requests
  • #20637 (closed) Dismiss todos upon merge or closure of associated Merge Request Create [DEPRECATED], customer, devopscreate, feature, groupsource code, merge requests, todos
  • #4498 Set arbitrary "Mirror user" for Repository Mirroring Create [DEPRECATED], Enterprise Edition, customer, devopscreate, feature, groupsource code, ~"mirror", repository, settings

Unscheduled feature (non-customer)

  • #38228 (closed) Add api for issues related to a merge request api, awaiting feedback, devopscreate, feature, groupsource code, merge requests
  • #38224 (closed) There is no syntax highlighting for CODEOWNERS files. devopscreate, feature, groupsource code, highlight
  • #37995 (closed) Rollback / migrate external merge request diffs from object storage to database Object Storage, ~"devops", devopscreate, feature, groupsource code, internal customer, merge requests
  • #37994 Modify branch protection level while creating new branch through API api, devopscreate, feature, groupsource code
  • #37846 Docs feedback: Markdown Doc : How to refer a branch ? devopscreate, feature, groupsource code, markdown
  • #37500 (closed) Ability to select multiple lines when suggesting code change devopscreate, feature, groupsource code, merge requests
  • #37433 (closed) In MR review, allow for marking a file as "Reviewed" devopscreate, diff, feature, groupsource code, merge requests
  • #37356 Raise issues directly via commit messages devopscreate, feature, groupsource code
  • #37275 MR diffs downloaded directly from the gitlab server with the option proxy_download: false, although they should be downloaded from S3 server directly Object Storage, devopscreate, feature, groupsource code
  • #37236 (closed) Notify only developers involved in an MR devopscreate, feature, groupsource code, merge requests, notifications
  • #37235 (closed) Display list of merge requests requiring my approval approvals, devopscreate, feature, groupsource code, merge requests
  • #37122 Notify maintainers when bug referenced in code has changed status devopscreate, feature, groupsource code
  • #37046 Locally reproducable release source archives devopscreate, feature, groupsource code, repository
  • #37042 (closed) Button for "collapse all" in merge request changes devopscreate, feature, groupsource code, merge requests
  • #37013 (closed) Unable to rebase via the UI when MR is WIP UX, devopscreate, feature, groupsource code, merge requests

Bug Section

For the following bugs. Please either close or assign either a versioned milestone, the %Backlog or the %Awaiting further demand milestone and ensure that a priority label is set.

Heatmap for all bugs

Bugs for their priority and severity label are counted here. Every bug should have severity and priority labels applied. Please take a look at the bugs which fall into the columns indicating that the priority or severity labels are currently missing.

~S1 ~S2 ~S3 ~S4 ~"No severity"
~P1 0 3 0 0 0
~P2 1 33 12 2 0
~P3 0 8 295 21 2
~P4 0 0 99 212 0
~"No priority" 0 10 26 23 97

Unscheduled frontend ~bug with customer

  • #37794 (closed) Maintainers can select private group in MR Approvals but the group doesn't persist UX, approvals, ~"bug", customer, devopscreate, frontend, groupsource code
  • #34197 (closed) Minimizing diffs by clicking the downward facing arrow does not trigger the collapseDiff() functionality. ~"S3", ~"bug", customer, devopscreate, frontend, groupsource code
  • #34156 (closed) When rebasing an MR that has approval rules, the "The source branch HEAD has recently changed" message is intermittently shown in error ~"bug", customer, devopscreate, frontend, groupsource code, merge requests
  • #33867 (closed) Impossible to comment on a diff with a former symlink ~"S2", ~"bug", customer, devopscreate, frontend, groupsource code
  • #33849 (closed) Number of files listed on merge request changes tab incorrect when truncated ~"P3", ~"S3", ~"bug", customer, devopscreate, frontend, groupsource code, merge requests
  • #33598 (closed) Mirroring Repository with Pull creates a Push as well ~"S4", ~"bug", customer, devopscreate, frontend, groupsource code
  • #23852 (closed) Diff comments do not show up on changes tab with parallel view, but are visible on discussions tab ~"Accepting merge requests", ~"Category:Code Review", Create [DEPRECATED], ~"bug", customer, devopscreate, diff, frontend, groupsource code, merge requests, mr refactor, regression, regression:11.1, reproduced on GitLab.com

Unscheduled frontend ~bug (non-customer)

  • #37769 (closed) Sourcegraph removes whitespaces between buttons in file header UI polish, ~"bug", devopscreate, frontend, groupsource code, regression, regression:12.5
  • #37497 (closed) Polling for MR notes from commits doesn't work properly ~"bug", devopscreate, frontend, groupsource code
  • #37465 (closed) Copying from merge request diff is broken browser:firefox, ~"bug", devopscreate, diff, frontend, groupsource code, merge requests, regression, regression:12.5, reproduced on GitLab.com
  • #37342 (closed) UX Bug: Use of Custom Groups in Protected Branches is too hard to discover naturally UX, ~"UX Bug", ~"UX Feature Discoverability", ~"bug", devopscreate, frontend, groupsource code, repository
  • #37072 (closed) Sourcegraph popover is still active on other tabs UX, ~"bug", devopscreate, frontend, groupsource code
  • #36532 (closed) Leaving a comment in a file in a merge request should not expand comment threads that you have manually collapsed in the same file ~"P4", ~"S4", ~"bug", devopscreate, diff, frontend, groupsource code, merge requests, reproduced on GitLab.com
  • #36457 (closed) Incorrect highlighted line ~"S4", UX, ~"bug", devopscreate, frontend, groupsource code, repository
  • #36337 (closed) Underscore in file name not visible across gitlab in chrome Resolution 1920x1080 UI polish, ~"bug", devopscreate, frontend, groupsource code
  • #36040 (closed) (confidential) ~"(confidential)"
  • #35950 (closed) Merge Request UI does not update if Merge Request was updated via API ~"S3", ~"bug", devopscreate, frontend, groupsource code
  • #35815 (closed) Merge Request File Browser: File tool-tip shows path with ellipsis ~"S3", ~"bug", devopscreate, frontend, groupsource code
  • #35120 (closed) Embedded links in dependency files are incorrectly escaped ~"P2", ~"S3", ~"bug", devopscreate, frontend, groupsource code, regression, regression:12.4, repository, reproduced on GitLab.com, rich blob viewer
  • #35098 (closed) 422 unprocessable entity when creating mr ~"S3", ~"bug", devopscreate, frontend, groupsource code, merge requests
  • #34662 (closed) Review comment disappears when leaving a second comment on same line ~"bug", devopscreate, diff, frontend, groupsource code, internal customer, merge requests, reproduced on GitLab.com
  • #34446 (closed) Merge button in merge request does not update all UI components ~"S4", UI polish, UX, ~"bug", devopscreate, frontend, groupsource code, merge requests

Unscheduled ~bug with customer

  • #35779 (closed) Can't push using Deploy Key after update from 12.3.x to 12.4.1 (This action cannot be performed by internal users, Your account has been blocked) ~"bug", customer, devopsmanage, groupsource code
  • #35221 (closed) Can't create a child branch with certain parent namespace if previously created - error is "Invalid reference name" ~"P2", ~"S2", ~"bug", customer, devopscreate, found:gitlab.com, groupsource code, repository, reproduced on GitLab.com

Unscheduled ~bug (non-customer)

  • #38030 (closed) [Protected branch allowed to merge] Maintainer can merge even if set to "No one" ~"S4", ~"bug", devopscreate, groupsource code
  • #37941 (closed) Importing a github project requires DNS resolution even when behind a proxy ~"bug", devopscreate, groupsource code
  • #37904 (closed) Revoked (and expired?) GPG subordinate keys are shown in GitLab UI ~"S4", ~"UX Bug", ~"bug", devopscreate, gpg, groupsource code
  • #37797 (closed) Hook validation warning ~"bug", devopscreate, groupsource code
  • #37454 (closed) Already merged MRs reappearing ~"Category:Code Review", ~"S3", ~"bug", devopscreate, groupsource code, merge requests
  • #37444 (closed) The comparison results are incorrect ~"S3", ~"bug", devopscreate, groupsource code
  • #37419 (closed) Can not open the folder with name started with '@' ~"S3", ~"bug", devopscreate, groupsource code
  • #37024 (closed) Todos API endpoint v4 giving "500 Internal Server Error" because of an entry. ~"bug", devopscreate, groupsource code, todos
  • #37008 Merge request diff comments missing / vanishing ~"S3", awaiting feedback, ~"bug", devopscreate, groupsource code
  • #36692 (closed) Forking fails with "Source project cannot be found." ~"S4", awaiting feedback, ~"bug", devopscreate, forking, groupsource code
  • #35937 (closed) Merge Request returned without any attributes for state=locked in api/v4/projects/6/merge_requests?state=locked&target_branch=something api, awaiting feedback, ~"bug", devopscreate, groupsource code, merge requests
  • #24320 (closed) Do not start a discussion on commit comments if the source is a system note Create [DEPRECATED], ~"P4", ~"S4", ~"bug", devopscreate, groupsource code, merge requests
  • #24314 (closed) Race condition in auto-merging Create [DEPRECATED], ~"P3", ~"S3", auto updated, awaiting feedback, backend, ~"bug", devopscreate, groupsource code, merge requests
  • #24274 (closed) GDK: Gitlab::GitalyClient::TooManyInvocationsError on GET /api/v4/groups Gitaly n+1, ~"P4", ~"S4", api, ~"bug", devopscreate, groupsource code
  • #24265 (closed) Deletion of an empty file in a merge request creates an collapsed diff that cant be expanded Create [DEPRECATED], ~"P4", ~"S4", ~"bug", devopscreate, diff, groupsource code, merge requests

Heatmap for ~missed-SLO bugs

~S1 ~S2 ~S3 ~S4
~P1 0 1 0 0
~P2 0 22 4 1
~P3 0 0 2 0
~P4 0 0 0 0


This is a group level triage package that aims to collate the latest bug reports (for frontend and otherwise) and feature proposals. For more information please refer to the handbook:

  • https://about.gitlab.com/handbook/engineering/quality/triage-operations/index.html#triage-packages
Edited Dec 09, 2019 by Nick Thomas
Assignee Loading
Time tracking Loading