Skip to content

Leaving a comment in a file in a merge request should not expand comment threads that you have manually collapsed in the same file

Problem to solve

Open a MR and leave a comment on a file. Collapse that discussion thread. Leave another comment on a different line in that file. The first discussion thread will un-collapse.

Intended users

A software engineer trying to review code.

Further details

If a comment thread is particularly long this will also screw up the page scrolling disrupting your place in the MR.

Proposal

If a comment is manually collapsed, do not expand it when a new comment is made.

Permissions and Security

No permission or security issues.

Documentation

No documentation update needed.

Testing

Write a test case for leaving a comment on a file which has already collapsed discussion threads.

What does success look like, and how can we measure that?

A discussion thread collapse feature that behaves how users expect it to.

What is the type of buyer?

Everyone: this behavior is expected.

Links / references

Edited by Tyler Yates