Ability to have multiple blocking approval groups/people
We currently use phabricator for our code reviews, and one of the more useful features it has is the ability to mark a reviewer as "blocking", meaning the change is not ready to be released until that specific person approves it. This is extremely important and useful to us, because our release workflow for one of our products requires changes to be signed off on by at least one person from two or more groups. Gitlab supports approval groups now, but no way to add multiple groups to a review; nor does it have the ability to mark a reviewer as blocking.
The proposal to add blocking comments kinda would work for this, but honestly, it's not an ideal solution.
One of several options:
- Add the ability to mark a reviewer as blocking
- Allow adding multiple approval groups with the requirement to need at least one approval per group
Links / references
Add ability to mark a reviewer as blocking for an MR. A merge request with a blocking approver won't be ready to merge until that specific person approves it.