Include non-code owners as suggested approvers when creating an MR

Problem to solve

This issue proposes follow-up work to #5382 (moved).

There is a scenario where approvers from outside of the code-owners spectrum should be suggested.

A concrete example is when the UX Designer associated with the original issue should be suggested as approval.

Further details

This would prevent certain non-obvious approvers to be added, which would be more effective than simply adding that UX designers should be added as approvers to the documentation.

Proposal

On top of adding suggested approvers based on the code-owners relationship, we should find a way to add other kinds of approvers.

Suggestion 1:

  • Add all assignees of the original issue that haven't contributed with commits

Suggestion 2:

  • Have a way to specify groups that need to have at least one approver.
  • If some groups are not represented by the initial set of suggested approvers, suggest adding the entire group as approver (which might act as a reminder that user needs to add apropriate approver).

What does success look like, and how can we measure that?

Less MRs will be created without assigning all relevant approvers.

Links / references

Assignee Loading
Time tracking Loading