Make Jose Vargas a frontend maintainer for GitLab and GitLab-UI
Trainee issue: #6915 (closed)
Links to Non-Trival MRs I've Reviewed
| MR | Changes | Notes |
|---|---|---|
| feat: Add annotations tooltip for Time Series charts | 521 , 69 | Some small suggestions from Nathan Friend |
| feat: Add annotations config | 373 , 58 | One nitpick from Martin Wortschack |
| [Part-2] Show requirements list for the project | 679 , 14 | One suggestion from Martin Wortschack |
| Show commits by author | 584 , 2 | Small suggestions from Kushal Pandya |
| Update Active checkbox component to use toggle | 208 , 48 | Couple of comments from Phil Hughes |
| Load expanded dashboard when certain URL parameters match the panel | 90 , 136 | No further comments from Mike Greiling |
| feat: Add annotation markers | 246 , 129 | No further comments from Kushal Pandya |
| Add annotations config generator | 209 , 49 | No further comments from Kushal Pandya |
| Refactor monitoring dashboard to allow dashboard data refresh | 246 , 225 | No further comments from Kushal Pandya |
MRs with architectural suggestions
| MR | Notes |
|---|---|
| Show commits by author | Noted a vue component that contained jQuery code while the implementation was sound it was requested to refactor the related code so vue components didn't have to use jQuery |
| Load expanded dashboard when certain URL parameters match the panel | Requested a change regarding how a component was handling the logic that should be a part of a vuex action. A vue expert agreed with the approach |
Links to Non-Trivial MRs I've Written
| MR | Changes | Notes |
|---|---|---|
| Add edit custom metric link to metrics dashboard - MVC | 98 , 3 | One small comment from Martin Wortschack |
| Add support for stacked column charts | 206 , 0 | Some small comments from Natalia Tepluhina regarding how we handle asynchronous testing |
| Add self monitoring admin section | 887 , 0 | Couple of comments from Fatih Acet, nothing major |
| Migrate the monitoring dashboard store to vuex | 631 , 6078 | Couple of comments from Fatih Acet regards actionifying some mutation calls, the amount of deletions are due to deprecating a bunch of mocked data. |
| Move non EE dashboard specs to jest | 899 , 1 | Couple of comments from Martin Wortschack |
| Add tests to cover multiple time series | 483 , 377 | No further comments from Mike Greiling |
| Add percentile value support to single stat panel types | 67 , 5 | No further comments from Fatih Acet |
Links to Non-Trivial MRs I've Written (Broken down from one feature)
Feature Epic: Variables in Dashboard MVC1
| Issue 1 MRs: Use metrics dashboard URL query param to populate PromQL Query | Changes | Notes |
|---|---|---|
| Filter out custom variables from Url | 133 , 2 | Feature MR, It has questions about the use of the API and test coverage from Paul Slaughter |
| Add docs for the query variables from URL feature | Docs MR |
| Issue 2 MRs: Add text variable input field to metrics dashboard | Changes | Notes |
|---|---|---|
| add text variable input from variables | 287 , 22 | Some small comments from Martin Wortschack |
| Extend queryToObject function to remove undefined | 10 , 2 | No further comments from Andrew Fontaine |
| Remove border-bottom from form-group | 4 , 0 | No further comments from Martin Wortschack |
| Issue 3 MRs: Generated chart URL links contain the variables and are rendered appropriately when embedding in markdown | Changes | Notes |
|---|---|---|
| Ensure links generated by the copy link feature contain variables | 37 , 16 | No further comments from Kushal Pandya |
Once This MR is Merged
-
Create an access request for maintainer access to gitlab-org. -
Let a maintainer add you to gitlab-org/maintainers/frontend -
Announce it everywhere -
Keep reviewing, start merging 🤘 😎 🤘
Edited by Jose Ivan Vargas