Make Illya Klymov a Frontend Maintainer
After 3+ months of being a trainee maintainer, I would like to propose myself as a candidate for becoming a Frontend Maintainer. I believe that the quality of reviews and the MRs I've authored is sufficient for maintainer
My trainee FE maintainer issue: #6236 (closed)
Links to Non-Trival MRs I've Reviewed
I was involved into reviewing multiple design management MRs (thanks @ntepluhina for opportunity), performing both early and "final" reviews. These MRs are big and contain a lot of discussions and were changed significantly based on my comments:
- gitlab-org/gitlab!14648 (merged)
- gitlab-org/gitlab!15034 (merged)
- gitlab-org/gitlab!15119 (merged)
- gitlab-org/gitlab!23148 (merged)
Another big thing was a refactoring of Geo Replicable UI components, which started as single MR and was split to multiple ones:
Links to Non-Trivial MRs I've Written
During my year I've tried always to pay attention to global problems and possible improvements we have on the frontend side.
-
Upgrade Vue test utils to 1.0.0-beta.30. Epic with 18 MRs fixing tons of different issues in our tests codebase which were blocking us for more than 9 months to upgrade our Vue testing framework
-
Filters. The most complex (8 pajamas of 5, self-evaluated) component I've ever written with Vue. I've worked on this component for multiple sprints without proper initial requirements. This series forced me to learn a lot about iteration value
- Iteration 1: initial research
-
Iteration 2: Iteration on new version of filters (with is / is not support)
- chore(filters): Add initial value support to suggestions list
- chore(filters): Introduce filtered search token segment component
- chore(filters): Prepare filtered search component for new tokens
- Introduce new token to filtered search
- Refactor term to use token segment
- chore(filters): Update filters to use new tokens
- chore(filters): remove obsolete parts
- Iteration 3: Syncing with draft spec & bugfixes
-
Clean unnecessary 'localVue' uses in Jest tests. Epic with 26 MRs
@gitlab-org/maintainers/frontend please chime in below with your thoughts, and approve this MR if you agree.
Once This MR is Merged
-
Create an access request for maintainer access to gitlab-org
. -
Let a maintainer add you to gitlab-org/maintainers/frontend
-
Announce it everywhere -
Keep reviewing, start merging 🤘 😎 🤘
Closes #6236 (closed)