Skip to content

WIP: Generalize Geo Replicable UI Components

Zack Cuddy requested to merge 208470_01-generalize-geo-replicable-component into master

Why WIP

Split up MR for readability and MVC

Current Proposed Split Up:

What does this MR do?

This sets the stage for #208470 (closed)

Currently, the UI components for Geo Replicable Items is isolated to Geo Designs Only. As we move forward, it will be easier if we have a generalized place in the UI to house different replicable data types, without spinning up additional UI components when possible.

This MR takes the Geo Designs Components and "generalizes" them.

  • Geo Designs => Geo Replicable
  • Geo Design => Geo Replicable Item
  • All Actions are renamed to replace design with replicable
  • All variables are renamed to replace design with replicable
  • All files are renamed from geo_designs_* => geo_replicable_*
  • Updates API to expect a replicable parameter to do network requests
  • Remove un-used design specific documentation link

Screenshots

Component Tests
before Tests_Before
after Tests_After

GIF

All Existing Functionality Still Working: All_Functionality

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Zack Cuddy

Merge request reports