Trainee FE maintainer (GitLab) - Illya Klymov
Generic guidelines
Basic setup
-
Read the code review page in the handbook and the code review guidelines. -
Understand how to become a maintainer and add yourself as a trainee maintainer on the team page.
When you're ready to make it official
When reviews have accumulated, and recent reviews consistently fulfill maintainer responsibilities, any maintainer can take the next step. The trainee should also feel free to discuss their progress with their manager or any maintainer at any time.
-
Create a merge request for team page proposing yourself as a maintainer. -
Create a merge request for CODEOWNERS, adding yourself accordingly, and ask a maintainer to review it. -
Keep reviewing, start merging 🤘
Review highlights
I was involved into reviewing multiple design management MRs (thanks @ntepluhina for opportunity), performing both early and "final" reviews. These MRs are big and contain a lot of discussions and were changed significantly based on my comments:
- gitlab-org/gitlab!14648 (merged)
- gitlab-org/gitlab!15034 (merged)
- gitlab-org/gitlab!15119 (merged)
- gitlab-org/gitlab!23148 (merged)
Another big thing was a refactoring of Geo Replicable UI components, which started as single MR and was split to multiple ones:
Own MR Highlights
During my year I've tried always to pay attention to global problems and possible improvements we have on the frontend side.
-
Upgrade Vue test utils to 1.0.0-beta.30. Epic with 18 MRs fixing tons of different issues in our tests codebase which were blocking us for more than 9 months to upgrade our Vue testing framework
-
Filters. The most complex (8 pajamas of 5, self-evaluated) component I've ever written with Vue. I've worked on this component for multiple sprints without proper initial requirements. This series forced me to learn a lot about iteration value
- Iteration 1: initial research
-
Iteration 2: Iteration on new version of filters (with is / is not support)
- chore(filters): Add initial value support to suggestions list
- chore(filters): Introduce filtered search token segment component
- chore(filters): Prepare filtered search component for new tokens
- Introduce new token to filtered search
- Refactor term to use token segment
- chore(filters): Update filters to use new tokens
- chore(filters): remove obsolete parts
- Iteration 3: Syncing with draft spec & bugfixes
-
Clean unnecessary 'localVue' uses in Jest tests. Epic with 26 MRs
Latest MRs
According to handbook, one of requirements of being maintainer
The MRs they've written consistently make it through reviewer and maintainer review without significant required changes.
This is a list of my latest MRs with self-evaluated complexity (1 to 5), and level of concerns raised (0 to 5) by reviewers and maintainer
MR | Complexity | Level of concern | Details |
---|---|---|---|
Remove "Please ensure your account's recovery settings are up to date." message at self-managed instances" | Merged as-is | ||
chore(ci): Fix CSS order in storyshots | Estimated as |
||
feat(filters): Fill operator part if only one operator exists | |||
Resolve "SAML/SSO/GMA toggles appear disabled when they're not" | Tiny non-blocking change about variable naming | ||
Improve UX for Group SAML Configuration page | Minor suggestions about using classList.toggle and variable naming |