Proto: extend consistency checks for scoru constants

Context

Closes #2980 (closed).

The checks comes from my understanding of the constants and I tried to give a explanation of the values in the different commit messages.

Manually testing the MR

We could obviously write a test that test the check itself by starting a chain with the wrong constants, but I don't know if it makes a lot of sense. Although, I don't know if that's doable but I could try to write tests for start a smart contract rollup with constants which does not respect these constraints and see how it breaks the invariants.

Checklist

• n/a Document the interface of any function added or modified (see the coding guidelines)
• n/a Document any change to the user interface, including configuration parameters (see node configuration)
• Provide automatic testing (see the testing guide).
• n/a For new features and bug fixes, add an item in the appropriate changelog (docs/protocols/alpha.rst for the protocol and the environment, CHANGES.rst at the root of the repository for everything else).
• Select suitable reviewers using the Reviewers field below.
• Select as Assignee the next person who should take action on that MR

src/proto_alpha/lib_client/mockup.ml

@@ -60,7 +60,6 @@ module Protocol_constants_overrides = struct
     max_available_messages : int option;
     stake_amount : Tez.t option;
     commitment_period_in_blocks : int option;
-    commitment_storage_size_in_bytes : int option;
     max_lookahead_in_blocks : int32 option;
     max_active_outbox_levels : int32 option;
     max_outbox_messages_per_level : int option;
@@ -192,7 +191,6 @@ module Protocol_constants_overrides = struct
           c.max_available_messages,
           c.stake_amount,
           c.commitment_period_in_blocks,
-          c.commitment_storage_size_in_bytes,
           c.max_lookahead_in_blocks,
           c.max_active_outbox_levels,
           c.max_outbox_messages_per_level ))
@@ -202,7 +200,6 @@ module Protocol_constants_overrides = struct
              sc_rollup_max_available_messages,
              sc_rollup_stake_amount,
              sc_rollup_commitment_period_in_blocks,
-             sc_rollup_commitment_storage_size_in_bytes,
              sc_rollup_max_lookahead_in_blocks,
              sc_rollup_max_active_outbox_levels,
              sc_rollup_max_outbox_messages_per_level ) ->
@@ -213,21 +210,18 @@ module Protocol_constants_overrides = struct
           max_available_messages = sc_rollup_max_available_messages;
           stake_amount = sc_rollup_stake_amount;
           commitment_period_in_blocks = sc_rollup_commitment_period_in_blocks;
-          commitment_storage_size_in_bytes =
-            sc_rollup_commitment_storage_size_in_bytes;
           max_lookahead_in_blocks = sc_rollup_max_lookahead_in_blocks;
           max_active_outbox_levels = sc_rollup_max_active_outbox_levels;
           max_outbox_messages_per_level =
             sc_rollup_max_outbox_messages_per_level;
         })
-      (obj10
+      (obj9
          (opt "sc_rollup_enable" bool)
          (opt "sc_rollup_origination_size" int31)
          (opt "sc_rollup_challenge_window_in_blocks" int31)
          (opt "sc_rollup_max_available_messages" int31)
          (opt "sc_rollup_stake_amount" Tez.encoding)
          (opt "sc_rollup_commitment_period_in_blocks" int31)
-         (opt "sc_rollup_commitment_storage_size_in_bytes" int31)
          (opt "sc_rollup_max_lookahead_in_blocks" int32)
          (opt "sc_rollup_max_active_outbox_levels" int32)
          (opt "sc_rollup_max_outbox_messages_per_level" int31))
@@ -488,8 +482,6 @@ module Protocol_constants_overrides = struct
             stake_amount = Some parametric.sc_rollup.stake_amount;
             commitment_period_in_blocks =
               Some parametric.sc_rollup.commitment_period_in_blocks;
-            commitment_storage_size_in_bytes =
-              Some parametric.sc_rollup.commitment_storage_size_in_bytes;
             max_lookahead_in_blocks =
               Some parametric.sc_rollup.max_lookahead_in_blocks;
             max_active_outbox_levels =
@@ -577,7 +569,6 @@ module Protocol_constants_overrides = struct
           max_available_messages = None;
           stake_amount = None;
           commitment_period_in_blocks = None;
-          commitment_storage_size_in_bytes = None;
           max_lookahead_in_blocks = None;
           max_active_outbox_levels = None;
           max_outbox_messages_per_level = None;
@@ -1040,10 +1031,6 @@ module Protocol_constants_overrides = struct
                Option.value
                  ~default:c.sc_rollup.commitment_period_in_blocks
                  o.sc_rollup.commitment_period_in_blocks;
-             commitment_storage_size_in_bytes =
-               Option.value
-                 ~default:c.sc_rollup.commitment_storage_size_in_bytes
-                 o.sc_rollup.commitment_storage_size_in_bytes;
              max_lookahead_in_blocks =
                Option.value
                  ~default:c.sc_rollup.max_lookahead_in_blocks