Proto: extend consistency checks for scoru constants
Context
Closes #2980 (closed).
The checks comes from my understanding of the constants and I tried to give a explanation of the values in the different commit messages.
Manually testing the MR
We could obviously write a test that test the check itself by starting a chain with the wrong constants, but I don't know if it makes a lot of sense. Although, I don't know if that's doable but I could try to write tests for start a smart contract rollup with constants which does not respect these constraints and see how it breaks the invariants.
Checklist
- n/a Document the interface of any function added or modified (see the coding guidelines)
- n/a Document any change to the user interface, including configuration parameters (see node configuration)
-
Provide automatic testing (see the testing guide). - n/a For new features and bug fixes, add an item in the appropriate changelog (
docs/protocols/alpha.rst
for the protocol and the environment,CHANGES.rst
at the root of the repository for everything else). -
Select suitable reviewers using the Reviewers
field below. -
Select as Assignee
the next person who should take action on that MR