Switch to enabling patroni by default with new patroni role
What does this MR do?
Switch to enabling patroni by default with new patroni role Throw an error early in reconfigure if someone is trying to use repgmr with PG12
Related issues
Part of #5888 (closed)
Closes: #5921 (closed)
Checklist
See Definition of done.
For anything in this list which will not be completed, please provide a reason in the MR discussion
Required
-
Merge Request Title, and Description are up to date, accurate, and descriptive -
MR targeting the appropriate branch -
MR has a green pipeline on GitLab.com -
Pipeline is green on dev.gitlab.org if the change is touching anything besides documentation or internal cookbooks -
trigger-packagehas a green pipeline running against latest commit
Expected (please provide an explanation if not completing)
-
Test plan indicating conditions for success has been posted and passes -
Documentation created/updated -
Tests added -
Integration tests added to GitLab QA -
Equivalent MR/issue for the GitLab Chart opened
Test Plan
-
Test fresh install patroni role - get patroni -
Test fresh install explicit repmgr - get PG 12 error -
Test fresh install explicit repmgr with PG 11 - gets repmgr
Merge request reports
Activity
changed milestone to %13.7
added devopssystems groupdistribution typebug labels
added sectioncore platform label
1 Warning 
You've made some changes at the locations which contain user facing configuration.
That's OK as long as you're refactoring existing code and not adding any new
configuration. If you are adding new user facing configuration, consider adding
to gitlab.rb.template located in files/gitlab-config-template/gitlab.rb.template .
Otherwise, please consider adding the ~"feature::maintenance" label in that case.1 Message 
Please add the workflowready for review label once you think the MR is ready to for an initial review. Merge requests are handled according to the workflow documented in our handbook and should receive a response within the limit documented in our First-response SLO.
If you don't receive a response, please mention
@gitlab-org/distribution, or one of our Project MaintainersGenerated by
Edited by 🤖 GitLab Bot 🤖added 1 commit
- 33ab3047 - Deal with the fact that repmgrd is enabled by default
changed milestone to %13.8
removed typebug label
added typemaintenance label
added typefeature label
added 1 commit
- 0be3e28c - Make patroni the default rather than repmgr for postgresql_role
-
The
Trigger:ee-packagejob from pipeline https://gitlab.com/gitlab-org/omnibus-gitlab/-/pipelines/231572293 triggered https://gitlab.com/gitlab-org/build/omnibus-gitlab-mirror/-/pipelines/231591268 downstream. -
The
Trigger:qa-testjob from pipeline https://gitlab.com/gitlab-org/build/omnibus-gitlab-mirror/-/pipelines/231591268 triggered https://gitlab.com/gitlab-org/gitlab-qa-mirror/-/pipelines/231608681 downstream.