Switch to enabling patroni by default with new patroni role
What does this MR do?
Switch to enabling patroni by default with new patroni role Throw an error early in reconfigure if someone is trying to use repgmr with PG12
Related issues
Part of #5888 (closed)
Closes: #5921 (closed)
Checklist
See Definition of done.
For anything in this list which will not be completed, please provide a reason in the MR discussion
Required
-
Merge Request Title, and Description are up to date, accurate, and descriptive -
MR targeting the appropriate branch -
MR has a green pipeline on GitLab.com -
Pipeline is green on dev.gitlab.org if the change is touching anything besides documentation or internal cookbooks -
trigger-package
has a green pipeline running against latest commit
Expected (please provide an explanation if not completing)
-
Test plan indicating conditions for success has been posted and passes -
Documentation created/updated -
Tests added -
Integration tests added to GitLab QA -
Equivalent MR/issue for the GitLab Chart opened
Test Plan
-
Test fresh install patroni role - get patroni -
Test fresh install explicit repmgr - get PG 12 error -
Test fresh install explicit repmgr with PG 11 - gets repmgr
Merge request reports
Activity
changed milestone to %13.7
added devopssystems groupdistribution typebug labels
added sectioncore platform label
1 Warning You've made some changes at the locations which contain user facing configuration.
That's OK as long as you're refactoring existing code and not adding any new
configuration. If you are adding new user facing configuration, consider adding
to gitlab.rb.template located in files/gitlab-config-template/gitlab.rb.template .
Otherwise, please consider adding the ~"feature::maintenance" label in that case.1 Message Please add the workflowready for review label once you think the MR is ready to for an initial review. Merge requests are handled according to the workflow documented in our handbook and should receive a response within the limit documented in our First-response SLO.
If you don't receive a response, please mention
@gitlab-org/distribution
, or one of our Project MaintainersGenerated by
DangerEdited by 🤖 GitLab Bot 🤖added 1 commit
- 33ab3047 - Deal with the fact that repmgrd is enabled by default
changed milestone to %13.8
removed typebug label
added typemaintenance label
added typefeature label
added 1 commit
- 0be3e28c - Make patroni the default rather than repmgr for postgresql_role
The
gitlab-qa
downstream pipeline failed! .
added workflowready for review label
unassigned @twk3
- Resolved by DJ Mountney
@twk3 Do you think it makes sense to let this revert to a standalone postgresql role when repmgr support gets removed, and create a separate
patroni
role?There's definitely a demand for a standalone postgresql role
added 46 commits
-
0be3e28c...cd682a1a - 45 commits from branch
master
- 775f5e39 - Merge remote-tracking branch 'origin/master' into repmgr-guardrails
-
0be3e28c...cd682a1a - 45 commits from branch
The
Trigger:ee-package
job from pipeline https://gitlab.com/gitlab-org/omnibus-gitlab/-/pipelines/235911368 triggered https://gitlab.com/gitlab-org/build/omnibus-gitlab-mirror/-/pipelines/235924502 downstream.The
Trigger:qa-test
job from pipeline https://gitlab.com/gitlab-org/build/omnibus-gitlab-mirror/-/pipelines/235924502 triggered https://gitlab.com/gitlab-org/gitlab-qa-mirror/-/pipelines/235946841 downstream.The
gitlab-qa
downstream pipeline passed. .
assigned to @rmarshall
added workflowin review label and removed workflowready for review label
- Resolved by Balasankar 'Balu' C
Downloading the built package is not working for me, so kicked off https://dev.gitlab.org/gitlab/omnibus-gitlab/-/pipelines/181536 to build a package I can use in pipelines.
Once that is done, review will begin.
assigned to @twk3
- Resolved by DJ Mountney
- Resolved by DJ Mountney
added 1 commit
- e75f7d3b - Use a new patroni role instead of changing the postgres role
The
Trigger:ee-package
job from pipeline https://gitlab.com/gitlab-org/omnibus-gitlab/-/pipelines/237754539 triggered https://gitlab.com/gitlab-org/build/omnibus-gitlab-mirror/-/pipelines/237821068 downstream.The
Trigger:qa-test
job from pipeline https://gitlab.com/gitlab-org/build/omnibus-gitlab-mirror/-/pipelines/237821068 triggered https://gitlab.com/gitlab-org/gitlab-qa-mirror/-/pipelines/237838100 downstream.The
gitlab-qa
downstream pipeline failed! .
unassigned @twk3