Skip to content
Snippets Groups Projects

Auditing for changes to event streaming destinations

Merged Max Woolf requested to merge 344664-audit-event-streaming into master
All threads resolved!

What does this MR do and why?

  • Adds audit events for adding, deleting and updating audit streaming destinations.
  • Updates documentation.

Screenshots

Screenshot_2021-11-18_at_11.49.51

How to set up and validate locally

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #344664 (closed)

Edited by Max Woolf

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • A deleted user added backend documentation labels

    added backend documentation labels

  • 1 Message
    :book: This merge request adds or changes documentation files. A review from the Technical Writing team before you merge is recommended. Reviews can happen after you merge.

    Documentation review

    The following files require a review from a technical writer:

    • doc/administration/audit_events.md

    The review does not need to block merging this merge request. See the:

    Reviewer roulette

    Changes that require review have been detected!

    Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:

    Category Reviewer Maintainer
    backend George Koltsov (@georgekoltsov) (UTC+0, same timezone as @mwoolf) Dmitry Gruzd (@dgruzd) (UTC+3, 3 hours ahead of @mwoolf)

    To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

    To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

    Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.

    If needed, you can retry the danger-review job that generated this comment.

    Generated by :no_entry_sign: Danger

  • Max Woolf requested review from @eread

    requested review from @eread

  • Max Woolf requested review from @huzaifaiftikhar1

    requested review from @huzaifaiftikhar1

  • Max Woolf added 1 commit

    added 1 commit

    • 8bce1db7 - Auditing for changes to event streaming destinations

    Compare with previous version

  • Evan Read
  • Evan Read approved this merge request

    approved this merge request

  • :wave: @eread, thanks for approving this merge request.

    This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.

    For more info, please refer to the following links:

  • Evan Read removed review request for @eread

    removed review request for @eread

  • Evan Read mentioned in merge request !74750 (merged)

    mentioned in merge request !74750 (merged)

  • Max Woolf added 354 commits

    added 354 commits

    Compare with previous version

  • Max Woolf resolved all threads

    resolved all threads

  • Max Woolf added twfinished label and removed twdoing label

    added twfinished label and removed twdoing label

  • Huzaifa Iftikhar
  • Huzaifa Iftikhar
  • Huzaifa Iftikhar
  • Huzaifa Iftikhar
  • Huzaifa Iftikhar removed review request for @huzaifaiftikhar1

    removed review request for @huzaifaiftikhar1

  • Max Woolf added 1 commit

    added 1 commit

    • e545352d - Auditing for changes to event streaming destinations

    Compare with previous version

  • Max Woolf changed the description

    changed the description

  • Max Woolf added 392 commits

    added 392 commits

    Compare with previous version

  • Max Woolf requested review from @huzaifaiftikhar1

    requested review from @huzaifaiftikhar1

  • Max Woolf added 1 commit

    added 1 commit

    • 81a15af4 - Auditing for changes to event streaming destinations

    Compare with previous version

  • Max Woolf added 418 commits

    added 418 commits

    Compare with previous version

  • Max Woolf added 1 commit

    added 1 commit

    • b74693d7 - Auditing for changes to event streaming destinations

    Compare with previous version

  • Huzaifa Iftikhar
  • Huzaifa Iftikhar removed review request for @huzaifaiftikhar1

    removed review request for @huzaifaiftikhar1

  • Max Woolf added 1 commit

    added 1 commit

    • aedf4a27 - Auditing for changes to event streaming destinations

    Compare with previous version

  • Max Woolf added 1 commit

    added 1 commit

    • 8dc24eca - Auditing for changes to event streaming destinations

    Compare with previous version

  • Max Woolf requested review from @huzaifaiftikhar1

    requested review from @huzaifaiftikhar1

  • Huzaifa Iftikhar
  • Huzaifa Iftikhar requested review from @reprazent

    requested review from @reprazent

  • Huzaifa Iftikhar removed review request for @huzaifaiftikhar1

    removed review request for @huzaifaiftikhar1

  • removed Next Up label

  • Bob Van Landuyt
  • Bob Van Landuyt removed review request for @reprazent

    removed review request for @reprazent

  • Max Woolf added 1 commit

    added 1 commit

    • 79a50b6f - Auditing for changes to event streaming destinations

    Compare with previous version

  • Max Woolf requested review from @reprazent

    requested review from @reprazent

  • removed workflowin dev label

  • Bob Van Landuyt approved this merge request

    approved this merge request

  • Nice! Thank you very much @mwoolf. Nothing more to add.

  • Bob Van Landuyt resolved all threads

    resolved all threads

  • Bob Van Landuyt enabled an automatic merge when the pipeline for 28b150b2 succeeds

    enabled an automatic merge when the pipeline for 28b150b2 succeeds

  • Bob Van Landuyt mentioned in commit 5017e232

    mentioned in commit 5017e232

  • added workflowcanary label and removed workflowstaging label

  • added workflowproduction label and removed workflowcanary label

  • mentioned in issue #373955 (closed)

  • Please register or sign in to reply
    Loading