Auditing for changes to event streaming destinations
What does this MR do and why?
- Adds audit events for adding, deleting and updating audit streaming destinations.
- Updates documentation.
Screenshots
How to set up and validate locally
- Create a group.
- Create an audit event streaming destination. (https://docs.gitlab.com/ee/administration/audit_event_streaming.html#add-a-new-event-streaming-destination)
- Change an audit event streaming desination.
- Destroy an audit event streaming destination.
- View the audit events for the group.
- Assert that the events have been created succesfully and accurately.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #344664 (closed)
Merge request reports
Activity
changed milestone to %14.6
assigned to @mwoolf
- Resolved by Max Woolf
- A deleted user
added backend documentation labels
1 Message This merge request adds or changes documentation files. A review from the Technical Writing team before you merge is recommended. Reviews can happen after you merge. Documentation review
The following files require a review from a technical writer:
doc/administration/audit_events.md
The review does not need to block merging this merge request. See the:
-
Metadata for the
*.md
files that you've changed. The first few lines of each*.md
file identify the stage and group most closely associated with your docs change. - The Technical Writer assigned for that stage and group.
- Documentation workflows for information on when to assign a merge request for review.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend George Koltsov ( @georgekoltsov
) (UTC+0, same timezone as@mwoolf
)Dmitry Gruzd ( @dgruzd
) (UTC+3, 3 hours ahead of@mwoolf
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangerremoved [deprecated] Accepting merge requests label
requested review from @eread
- Resolved by Bob Van Landuyt
@huzaifaiftikhar1 Could you review the backend changes please?
requested review from @huzaifaiftikhar1
added 1 commit
- 8bce1db7 - Auditing for changes to event streaming destinations
- Resolved by Max Woolf
@eread
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.
For more info, please refer to the following links:
added Technical Writing twdoing typemaintenance labels and removed typefeature label
removed review request for @eread
mentioned in merge request !74750 (merged)
added 354 commits
-
8bce1db7...16a9ff55 - 353 commits from branch
master
- d75a9c80 - Merge branch 'master' into '344664-audit-event-streaming'
-
8bce1db7...16a9ff55 - 353 commits from branch
added twfinished label and removed twdoing label
- Resolved by Huzaifa Iftikhar
- Resolved by Huzaifa Iftikhar
- Resolved by Huzaifa Iftikhar
- Resolved by Huzaifa Iftikhar
- Resolved by Huzaifa Iftikhar
- Resolved by Huzaifa Iftikhar
- Resolved by Huzaifa Iftikhar
removed review request for @huzaifaiftikhar1
added 1 commit
- e545352d - Auditing for changes to event streaming destinations
added 392 commits
-
e545352d...1a9f179a - 391 commits from branch
master
- 294fad65 - Merge branch 'master' into '344664-audit-event-streaming'
-
e545352d...1a9f179a - 391 commits from branch
requested review from @huzaifaiftikhar1
added 1 commit
- 81a15af4 - Auditing for changes to event streaming destinations
added 418 commits
-
81a15af4...5a6f3da8 - 417 commits from branch
master
- 2a894cae - Auditing for changes to event streaming destinations
-
81a15af4...5a6f3da8 - 417 commits from branch
added 1 commit
- b74693d7 - Auditing for changes to event streaming destinations
- Resolved by Huzaifa Iftikhar
- Resolved by Huzaifa Iftikhar
removed review request for @huzaifaiftikhar1
added 1 commit
- aedf4a27 - Auditing for changes to event streaming destinations
added 1 commit
- 8dc24eca - Auditing for changes to event streaming destinations
requested review from @huzaifaiftikhar1
- Resolved by Max Woolf
requested review from @reprazent
removed review request for @huzaifaiftikhar1
removed Next Up label
- Resolved by Bob Van Landuyt
removed review request for @reprazent
added 1 commit
- 79a50b6f - Auditing for changes to event streaming destinations
requested review from @reprazent
removed workflowin dev label
Nice! Thank you very much @mwoolf. Nothing more to add.
enabled an automatic merge when the pipeline for 28b150b2 succeeds
mentioned in commit 5017e232
added workflowstaging-canary label
added workflowstaging label and removed workflowstaging-canary label
added workflowcanary label and removed workflowstaging label
added workflowproduction label and removed workflowcanary label
added docsfeature label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label
mentioned in issue #373955 (closed)