danger-review
Passed Started
by
@mwoolf
Max Woolf
1Running with gitlab-runner 14.5.0-rc1 (7dde9ca7)2 on green-3.shared-gitlab-org.runners-manager.gitlab.com/default EuhiQzPR3 feature flags: FF_USE_FASTZIP:true6Using Docker executor with image registry.gitlab.com/gitlab-org/gitlab-build-images:ruby-2.7.patched-golang-1.16-git-2.33-lfs-2.9-chrome-89-node-14.15-yarn-1.22-postgresql-11-graphicsmagick-1.3.36 ...7Authenticating with credentials from job payload (GitLab Registry)8Pulling docker image registry.gitlab.com/gitlab-org/gitlab-build-images:ruby-2.7.patched-golang-1.16-git-2.33-lfs-2.9-chrome-89-node-14.15-yarn-1.22-postgresql-11-graphicsmagick-1.3.36 ...9Using docker image sha256:3a40e98627a637c94cf5701bc550d5809d87260254f803f6187b319d0c602427 for registry.gitlab.com/gitlab-org/gitlab-build-images:ruby-2.7.patched-golang-1.16-git-2.33-lfs-2.9-chrome-89-node-14.15-yarn-1.22-postgresql-11-graphicsmagick-1.3.36 with digest registry.gitlab.com/gitlab-org/gitlab-build-images@sha256:82f2ae89e7de8c2de4c619f020e7ba4d4d1ccd7b26a74ea85371a8ee0d6ca0e0 ...11Running on runner-euhiqzpr-project-278964-concurrent-0 via runner-euhiqzpr-shared-gitlab-org-1637824954-3362d0d1...13$ eval "$CI_PRE_CLONE_SCRIPT"14Fetching changes with git depth set to 20...15Initialized empty Git repository in /builds/gitlab-org/gitlab/.git/16Created fresh repository.17remote: Enumerating objects: 108246, done. 18remote: Counting objects: 100% (108246/108246), done. 19remote: Compressing objects: 100% (75873/75873), done. 20remote: Total 108246 (delta 44003), reused 73605 (delta 28322), pack-reused 0 21Receiving objects: 100% (108246/108246), 112.93 MiB | 27.66 MiB/s, done.22Resolving deltas: 100% (44003/44003), done.24 * [new ref] 28b150b26350aa724109ab0ebd4e13cb86f27fd0 -> refs/pipelines/41606434725Checking out 28b150b2 as refs/merge-requests/74632/merge...26Skipping Git submodules setup28Checking cache for ruby-gems-v1-7...29Downloading cache.zip from https://storage.googleapis.com/gitlab-com-runners-cache/project/278964/ruby-gems-v1-7 30Successfully extracted cache31Checking cache for node-modules-test-v1-7...32Downloading cache.zip from https://storage.googleapis.com/gitlab-com-runners-cache/project/278964/node-modules-test-v1-7 33Successfully extracted cache35Using docker image sha256:3a40e98627a637c94cf5701bc550d5809d87260254f803f6187b319d0c602427 for registry.gitlab.com/gitlab-org/gitlab-build-images:ruby-2.7.patched-golang-1.16-git-2.33-lfs-2.9-chrome-89-node-14.15-yarn-1.22-postgresql-11-graphicsmagick-1.3.36 with digest registry.gitlab.com/gitlab-org/gitlab-build-images@sha256:82f2ae89e7de8c2de4c619f020e7ba4d4d1ccd7b26a74ea85371a8ee0d6ca0e0 ...36$ source scripts/utils.sh37$ bundle_install_script "--with danger"38Bundler version 2.1.439production:development40Settings are listed in order of priority. The top value will be used.41path42Set for the current user (/root/.bundle/config): "/builds/gitlab-org/gitlab/vendor"43clean44Set for the current user (/root/.bundle/config): "true"45without46Set via BUNDLE_WITHOUT: [:production, :development]47install_flags48Set via BUNDLE_INSTALL_FLAGS: "--jobs=$(nproc) --retry=3 --quiet"49$ bundle install --jobs=$(nproc) --retry=3 --quiet --with danger && bundle check50[DEPRECATED] The `--with` flag is deprecated because it relies on being remembered across bundler invocations, which bundler will no longer do in future versions. Instead please use `bundle config set with 'danger'`, and stop using this flag51The Gemfile's dependencies are satisfied52==> 'bundle install --jobs=$(nproc) --retry=3 --quiet --with danger && bundle check' succeeded in 2 seconds.53$ bundle pristine pg54Installing pg 1.2.3 with native extensions55==> 'bundle pristine pg' succeeded in 8 seconds.56$ run_timed_command "retry yarn install --frozen-lockfile"57$ retry yarn install --frozen-lockfile58yarn install v1.22.1059[1/5] Validating package.json...60[2/5] Resolving packages...61success Already up-to-date.62$ node ./scripts/frontend/postinstall.js63success Dependency postinstall check passed.64Done in 1.06s.65==> 'retry yarn install --frozen-lockfile' succeeded in 1 seconds.66$ if [ -z "$DANGER_GITLAB_API_TOKEN" ]; then # collapsed multi-line command67$ bundle exec danger --fail-on-errors=true --verbose68danger/ci_templates/Dangerfile:3: warning: already initialized constant Danger::Dangerfile::TEMPLATE_MESSAGE69danger/gitaly/Dangerfile:3: warning: previous definition of TEMPLATE_MESSAGE was here70Results:71Messages:72- [ ] This merge request adds or changes documentation files. A review from the Technical Writing team before you merge is **recommended**. Reviews can happen after you merge.73Markdown:74## Documentation review75The following files require a review from a technical writer:76* `doc/administration/audit_events.md`77The review does not need to block merging this merge request. See the:78- [Metadata for the `*.md` files](https://docs.gitlab.com/ee/development/documentation/#metadata) that you've changed. The first few lines of each `*.md` file identify the stage and group most closely associated with your docs change.79- The [Technical Writer assigned](https://about.gitlab.com/handbook/engineering/technical-writing/#designated-technical-writers) for that stage and group.80- [Documentation workflows](https://docs.gitlab.com/ee/development/documentation/workflow.html) for information on when to assign a merge request for review.81## Reviewer roulette82Changes that require review have been detected!83Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:84| Category | Reviewer | Maintainer |85| -------- | -------- | ---------- |86| ~backend | [George Koltsov](https://gitlab.com/georgekoltsov) (`@georgekoltsov`) (UTC+0, same timezone as `@mwoolf`) | [Dmitry Gruzd](https://gitlab.com/dgruzd) (`@dgruzd`) (UTC+3, 3 hours ahead of `@mwoolf`) |87To spread load more evenly across eligible reviewers, Danger has picked a candidate for each88review slot, based on their timezone. Feel free to89[override these selections](https://about.gitlab.com/handbook/engineering/projects/#gitlab)90if you think someone else would be better-suited91or use the [GitLab Review Workload Dashboard](https://gitlab-org.gitlab.io/gitlab-roulette/) to find other available reviewers.92To read more on how to use the reviewer roulette, please take a look at the93[Engineering workflow](https://about.gitlab.com/handbook/engineering/workflow/#basics)94and [code review guidelines](https://docs.gitlab.com/ee/development/code_review.html).95Please consider assigning a reviewer or maintainer who is a96[domain expert](https://about.gitlab.com/handbook/engineering/projects/#gitlab) in the area of the merge request.97Once you've decided who will review this merge request, assign them as a reviewer!98Danger does not automatically notify them for you.99**If needed, you can retry the [`danger-review` job](https://gitlab.com/gitlab-org/gitlab/-/jobs/1818323819) that generated this comment.**100==> 'bundle exec danger --fail-on-errors=true --verbose' succeeded in 7 seconds.102Not uploading cache ruby-gems-v1-7 due to policy103Not uploading cache node-modules-test-v1-7 due to policy105Job succeeded