Add a template to deploy using HashiCorp Waypoint
What does this MR do?
Today HashiCorp released Waypoint for HCL management of build, release and deploy. This MR adds a template to GitLab for folks who want to use Waypoint to deploy into their environments.
A working copy of the file can be found here: https://gitlab.com/brendan-demo/waypoint
This is as part of the overall response to Waypoint's release you can read more about here in this internal-only doc
Screenshots
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Merge request reports
Activity
marked the checklist item Documentation (if required) as completed
added citemplates documentation labels
2 Warnings This merge request does not have any assignee yet. Setting an assignee clarifies who needs to take action on the merge request at any given time. This merge request does not refer to an existing milestone. 1 Message This merge request adds or changes documentation files. A review from the Technical Writing team before you merge is recommended. Reviews can happen after you merge. Documentation review
The following files require a review from a technical writer:
doc/ci/examples/README.md
The review does not need to block merging this merge request. See the:
- Technical Writers assignments for the appropriate technical writer for this review.
- Documentation workflows for information on when to assign a merge request for review.
Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited, or the chosen person is unavailable.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not automatically notify them for you.
Category Reviewer Maintainer citemplates Erick Bajao ( @iamricecake
) (UTC+8)Shinya Maeda ( @shinya.maeda
) (UTC+7)If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by 🤖 GitLab Bot 🤖mentioned in issue everyonecancontribute/general#54 (closed)
1 --- 2 title: Add Hashicorp Waypoint CI template 3 merge_request: changed this line in version 6 of the diff
@brendan hey, this old MR didn't ping the team (we only get pinged for documentation MRs that come from the community) and so no one has picked it up. Is this work still valid?
@aqualls yes I think it is!
Based on the content, I think this falls under devopsverify and maybe grouppipeline execution. I'll tag in @marcel.amirault - he handles the docs for some Verify groups.
Note: the page will need its metadata updated...
@aqualls Thanks for the ping! I also happen to be a citemplates maintainer as well, so we can handle both reviews as once!
@brendan Thanks a lot, this LGTM! I'll approve, but we have to remove the changelog entry (this MR was created back when we still needed individual changelog files). The changelog details now go into the commit message itself: https://docs.gitlab.com/ee/development/changelog.html.
It's probably best to just squash all the commits together (dropping the changelog commit), and give it a new commit message with the changelog line. After you do that, please forward it to the maintainer suggested by roulette for merge!
Hi @brendan - I wanted to follow-up to see if rebasing helped resolve the conflicts here for this MR? Thank you!
/cc @marcel.amirault
@brendan The main issue is that we need to remove
changelogs/unreleased/brendan-add-waypoint.yml
from this MR, and addChangelog: added
to the end of the first commit's message, and then we can merge. See https://docs.gitlab.com/ee/development/changelog.html#overviewIf you need help with this, just let me know and I can do it for you
Edited by Marcel Amirault
added Technical Writing devopsverify grouppipeline execution labels
assigned to @brendan
requested review from @marcel.amirault
added sectionops label
changed milestone to %14.5
added docsfeature twdoing labels
removed review request for @marcel.amirault
@marcel.amirault
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.
For more info, please refer to the following links:
added typemaintenance label
changed milestone to %14.6
added missed:14.5 label
changed milestone to %14.7
added missed:14.6 label
changed milestone to %14.8
added missed:14.7 label
changed milestone to %14.9
added missed:14.8 label
changed milestone to %14.10
added missed:14.9 label
mentioned in issue gitlab-org/quality/triage-reports#6932 (closed)
changed milestone to %15.0
added missed:14.10 label