danger-review
Passed Started
by
@brendan

Brendan O'Leary
1Running with gitlab-runner 13.5.0 (ece86343)2 on prm-com-gitlab-org ae3bfce25Using Docker executor with image registry.gitlab.com/gitlab-org/gitlab-build-images:danger ...6Authenticating with credentials from job payload (GitLab Registry)7Pulling docker image registry.gitlab.com/gitlab-org/gitlab-build-images:danger ...8Using docker image sha256:82e1d1ddcb729231a0388b2ca7986d477b341d2123fb6543d36a6e60bdbf57b1 for registry.gitlab.com/gitlab-org/gitlab-build-images:danger with digest registry.gitlab.com/gitlab-org/gitlab-build-images@sha256:53149a0bcdd67f40967833dabcef02867dbaad476df19c4ef373458a290b0090 ...10Running on runner-ae3bfce2-project-278964-concurrent-0 via runner-ae3bfce2-prm-1603281158-3118d56d...12$ eval "$CI_PRE_CLONE_SCRIPT"13Downloading archived master...14Connecting to storage.googleapis.com (172.217.193.128:443)15saving to '/tmp/gitlab.tar.gz'16gitlab.tar.gz 3% |* | 41.7M 0:00:25 ETA17gitlab.tar.gz 27% |******** | 303M 0:00:05 ETA18gitlab.tar.gz 55% |***************** | 608M 0:00:02 ETA19gitlab.tar.gz 82% |************************** | 901M 0:00:00 ETA20gitlab.tar.gz 100% |********************************| 1099M 0:00:00 ETA21'/tmp/gitlab.tar.gz' saved22Extracting tarball into /builds/gitlab-org/gitlab...23Fetching changes with git depth set to 20...24Reinitialized existing Git repository in /builds/gitlab-org/gitlab/.git/25Created fresh repository.26Checking out 446e5fbb as refs/merge-requests/45314/head...27Skipping Git submodules setup29Checking cache for yarn-v1-3...30Downloading cache.zip from https://storage.googleapis.com/gitlab-com-runners-cache/project/278964/yarn-v1-3 31Successfully extracted cache33$ source ./scripts/utils.sh34$ run_timed_command "retry yarn install --frozen-lockfile"35$ retry yarn install --frozen-lockfile36yarn install v1.21.137[1/5] Validating package.json...38[2/5] Resolving packages...39[3/5] Fetching packages...40warning sha.js@2.4.10: Invalid bin entry for "sha.js" (in "sha.js").41info fsevents@2.1.3: The platform "linux" is incompatible with this module.42info "fsevents@2.1.3" is an optional dependency and failed compatibility check. Excluding it from installation.43[4/5] Linking dependencies...44warning " > linkifyjs@2.1.9" has unmet peer dependency "react@>= 0.14.0".45warning " > linkifyjs@2.1.9" has unmet peer dependency "react-dom@>= 0.14.0".46warning " > monaco-yaml@2.4.1" has incorrect peer dependency "monaco-editor@^0.19.2".47warning "@gitlab/eslint-plugin > eslint-plugin-jest > @typescript-eslint/experimental-utils > @typescript-eslint/typescript-estree > tsutils@3.17.1" has unmet peer dependency "typescript@>=2.8.0 || >= 3.2.0-dev || >= 3.3.0-dev || >= 3.4.0-dev || >= 3.5.0-dev || >= 3.6.0-dev || >= 3.6.0-beta || >= 3.7.0-dev || >= 3.7.0-beta".48warning " > eslint-import-resolver-jest@2.1.2" has unmet peer dependency "eslint-plugin-import@>=1.4.0".49warning " > eslint-import-resolver-webpack@0.12.1" has unmet peer dependency "eslint-plugin-import@>=1.4.0".50warning "vue-jest > ts-jest@26.4.1" has unmet peer dependency "typescript@>=3.8 <5.0".51[5/5] Building fresh packages...52$ node ./scripts/frontend/postinstall.js53success Dependency postinstall check passed.54Done in 67.28s.55==> 'retry yarn install --frozen-lockfile' succeeded in 67 seconds.56$ danger --fail-on-errors=true --verbose57WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.58WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.59WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.60WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.61WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.62WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.63WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.64WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.65WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.66WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.67WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.68WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.69WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.70WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.71WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.72WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.73WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.74WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.75WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.76WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.77WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.78WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.79WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.80WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.81WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.82WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.83WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.84WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.85Results:86Warnings:87- [ ] This merge request does not have any assignee yet. Setting an assignee clarifies who needs to take action on the merge request at any given time.88- [ ] This merge request does not refer to an existing milestone.89Messages:90- [ ] This merge request adds or changes documentation files. A review from the Technical Writing team before you merge is **recommended**. Reviews can happen after you merge.91Markdown:92## Documentation review93The following files require a review from a technical writer:94* `doc/ci/examples/README.md`95The review does not need to block merging this merge request. See the:96- [Technical Writers assignments](https://about.gitlab.com/handbook/engineering/technical-writing/#designated-technical-writers) for the appropriate technical writer for this review.97- [Documentation workflows](https://docs.gitlab.com/ee/development/documentation/workflow.html) for information on when to assign a merge request for review.98## Reviewer roulette99Changes that require review have been detected! A merge request is normally100reviewed by both a reviewer and a maintainer in its primary category (e.g.101~frontend or ~backend), and by a maintainer in all other categories.102To spread load more evenly across eligible reviewers, Danger has picked a candidate for each103review slot, based on their timezone. Feel free to104[override these selections](https://about.gitlab.com/handbook/engineering/projects/#gitlab)105if you think someone else would be better-suited, or the chosen person is unavailable.106To read more on how to use the reviewer roulette, please take a look at the107[Engineering workflow](https://about.gitlab.com/handbook/engineering/workflow/#basics)108and [code review guidelines](https://docs.gitlab.com/ee/development/code_review.html).109Please consider assigning a reviewer or maintainer who is a110[domain expert](https://about.gitlab.com/handbook/engineering/projects/#gitlab) in the area of the merge request.111Once you've decided who will review this merge request, mention them as you112normally would! Danger does not automatically notify them for you.113| Category | Reviewer | Maintainer |114| -------- | -------- | ---------- |115| ~"ci::templates" | [Erick Bajao](https://gitlab.com/iamricecake) (`@iamricecake`) (UTC+8) | [Shinya Maeda](https://gitlab.com/shinya.maeda) (`@shinya.maeda`) (UTC+7) |116**If needed, you can retry the [`danger-review` job](https://gitlab.com/gitlab-org/gitlab/-/jobs/804451435) that generated this comment.**118Not uploading cache yarn-v1-3 due to policy120Job succeeded