Rename log file for Secret push protection

Related issue: #462289 (closed)

What does this MR do and why?

We are renaming the log events file used for Secret Push Protection feature from secret-detection.log to secret_push_protection.log. This is done to better reflect the feature's name.

Context: The feature was recently renamed from Pre-receive Secret Detection to Secret Push Protection.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

N/A

How to set up and validate locally

1. Enable Secret push protection feature

pry(main)> Gitlab::CurrentSettings.update!(pre_receive_secret_detection_enabled: true) # to ensure feature is enabled instance-wide
pry(main)> project = Project.find(PROJECT_ID)
pry(main)> Feature.enable(:pre_receive_secret_detection_push_check, project) 

OR apply this patch to disable checks

diff --git a/ee/lib/gitlab/checks/secrets_check.rb b/ee/lib/gitlab/checks/secrets_check.rb
index 00b6743998d7..810354d7889e 100644
--- a/ee/lib/gitlab/checks/secrets_check.rb
+++ b/ee/lib/gitlab/checks/secrets_check.rb
@@ -93,8 +93,7 @@ def validate!
       # GitLab.com projects. For progress, follow
       # https://gitlab.com/groups/gitlab-org/-/epics/12729
       def run_pre_receive_secret_detection?
-        Gitlab::CurrentSettings.current_application_settings.pre_receive_secret_detection_enabled &&
-          (enabled_for_gitlabcom_project? || enabled_for_dedicated_project?)
+        true
       end
 
       def enabled_for_gitlabcom_project?

2. In the GDK setup, locate the new log file name at gitlab/log/secret_push_protection.log

assigned to @djadmin

added devopssecure groupsecret detection sectionsec labels

added pipelinetier-1 label

mentioned in issue #462289 (closed)

added backend documentation labels

	1 Message
	This merge request adds or changes documentation files. A review from the Technical Writing team before you merge is recommended. Reviews can happen after you merge.

Documentation review

The following files require a review from a technical writer:

• doc/administration/logs/index.md (Link to current live version)

The review does not need to block merging this merge request. See the:

• Metadata for the *.md files that you've changed. The first few lines of each *.md file identify the stage and group most closely associated with your docs change.
• The Technical Writer assigned for that stage and group.
• Documentation workflows for information on when to assign a merge request for review.

Reviewer roulette

Category	Reviewer	Maintainer
backend	@aluthra2 (UTC+5.5, same timezone as author)	@pedropombeiro (UTC+2, 3.5 hours behind author)

Please check reviewer's status!

• Reviewer is available!
• Reviewer is unavailable!

Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.

If needed, you can retry the danger-review job that generated this comment.

Generated by Danger

Proper labels assigned to this merge request. Please ignore me.

@djadmin - please see the following guidance and update this merge request.

	1 Error
	Please add typebug typefeature, or typemaintenance label to this merge request.

added maintenancerefactor typemaintenance labels

resolved all threads

changed milestone to %17.2

changed the description

@serenafang would you review this change please?

requested review from @serenafang

approved this merge request

added pipeline:mr-approved label

added pipelinetier-3 label and removed pipelinetier-1 label

Before you set this MR to auto-merge

This merge request will progress on pipeline tiers until it reaches the last tier: pipelinetier-3. We will trigger a new pipeline for each transition to a higher tier.

Before you resolve this discussion, please check the following:

• You are the last maintainer of this merge request
• The latest pipeline for this merge request is pipelinetier-3 (You can find which tier it is in the pipeline name)
• This pipeline is recent enough (created in the last 8 hours)

If all the criteria above apply, please resolve this discussion and the set auto-merge for this merge request.

See pipeline tiers and merging a merge request for more details.

E2E Test Result Summary

allure-report-publisher generated test report!

e2e-test-on-gdk: test report for 9493002b

expand test summary

+------------------------------------------------------------------+
|                          suites summary                          |
+-------------+--------+--------+---------+-------+-------+--------+
|             | passed | failed | skipped | flaky | total | result |
+-------------+--------+--------+---------+-------+-------+--------+
| Govern      | 6      | 0      | 0       | 0     | 6     | ✅     |
| Create      | 5      | 0      | 0       | 0     | 5     | ✅     |
| Monitor     | 2      | 0      | 0       | 0     | 2     | ✅     |
| Plan        | 7      | 0      | 2       | 0     | 9     | ✅     |
| Data Stores | 1      | 0      | 0       | 0     | 1     | ✅     |
| Package     | 3      | 0      | 1       | 0     | 4     | ✅     |
| Verify      | 1      | 0      | 0       | 0     | 1     | ✅     |
+-------------+--------+--------+---------+-------+-------+--------+
| Total       | 25     | 0      | 3       | 0     | 28    | ✅     |
+-------------+--------+--------+---------+-------+-------+--------+

e2e-test-on-cng: test report for 9493002b

expand test summary

+------------------------------------------------------------------+
|                          suites summary                          |
+-------------+--------+--------+---------+-------+-------+--------+
|             | passed | failed | skipped | flaky | total | result |
+-------------+--------+--------+---------+-------+-------+--------+
| Govern      | 77     | 0      | 9       | 0     | 86    | ✅     |
| Create      | 135    | 0      | 15      | 0     | 150   | ✅     |
| Fulfillment | 2      | 0      | 24      | 0     | 26    | ✅     |
| Verify      | 55     | 0      | 11      | 0     | 66    | ✅     |
| Monitor     | 8      | 0      | 12      | 0     | 20    | ✅     |
| Package     | 23     | 0      | 15      | 0     | 38    | ✅     |
| Plan        | 79     | 0      | 6       | 0     | 85    | ✅     |
| Data Stores | 34     | 0      | 9       | 0     | 43    | ✅     |
| Manage      | 2      | 0      | 8       | 0     | 10    | ✅     |
| Release     | 5      | 0      | 1       | 0     | 6     | ✅     |
| Analytics   | 2      | 0      | 0       | 0     | 2     | ✅     |
| Configure   | 0      | 0      | 3       | 0     | 3     | ➖     |
| ModelOps    | 0      | 0      | 1       | 0     | 1     | ➖     |
| Growth      | 0      | 0      | 2       | 0     | 2     | ➖     |
| Ai-powered  | 0      | 0      | 1       | 0     | 1     | ➖     |
| Secure      | 3      | 0      | 1       | 0     | 4     | ✅     |
+-------------+--------+--------+---------+-------+-------+--------+
| Total       | 425    | 0      | 118     | 0     | 543   | ✅     |
+-------------+--------+--------+---------+-------+-------+--------+

approved this merge request

requested review from @ahmed.hemdan