ActivityService should not be called during password update spec
What does this MR do and why?
Solves gitlab-org/quality/engineering-productivity/master-broken-incidents#6616 (closed)
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
Before | After |
---|---|
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
Merge request reports
Activity
assigned to @sgarg_gitlab
mentioned in incident gitlab-org/quality/engineering-productivity/master-broken-incidents#6616 (closed)
- A deleted user
added backend label
3 Warnings 2f5c0ea2: The commit subject must contain at least 3 words. For more information, take a look at our Commit message guidelines. 109217a1: The commit subject must contain at least 3 words. For more information, take a look at our Commit message guidelines. This merge request does not refer to an existing milestone. 1 Message CHANGELOG missing: If this merge request needs a changelog entry, add the
Changelog
trailer to the commit message you want to add to the changelog.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Category Reviewer Maintainer backend @radbatnag
(UTC+8, 2.5 hours ahead of author)
@tkuah
(UTC+12, 6.5 hours ahead of author)
Please check reviewer's status!
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by Ghost Useradded pipelinetier-1 label
requested review from @abdwdd
requested review from @manojmj
- Resolved by 🤖 GitLab Bot 🤖
Proper labels assigned to this merge request. Please ignore me.
@sgarg_gitlab
- please see the following guidance and update this merge request.1 Error Please add typebug typefeature, or typemaintenance label to this merge request. Edited by 🤖 GitLab Bot 🤖
added bugfunctional groupauthentication typebug labels and removed backend label
added devopsgovern sectionsec labels
- Resolved by Smriti Garg
- Resolved by Smriti Garg
- Resolved by Manoj M J
Thanks @sgarg_gitlab, I am good with this solution for the sake of pipeline stability.
My only worry is that this is not a permanent fix - right now we are skipping hitting
ActivityService
just to make the specs pass.My request would be that we also follow-up in this space and fix the real issue, as mentioned in gitlab-org/quality/engineering-productivity/master-broken-incidents#6616 (comment 1924215597), either through
User
reload or some other manner that's a more sustainable fix.@rymai WDYT?
- A deleted user
added backend label