{"id":280722900,"iid":144174,"description":"## What does this MR do and why? This adds Danger checks and diff suggestions for feature flag definition files, depending on the FF type. I also enabled the Danger check locally as the feature flag definition file can actually be checked locally. | Screenshot 1 | Screenshot 2 | Screenshot 3 | | ------ | ------ | ------ | | ![Screenshot_2024-04-30_at_12.06.12](/uploads/2d136ce69d3b9eaa8c57388ab8175d74/Screenshot_2024-04-30_at_12.06.12.png) | ![Screenshot_2024-04-30_at_12.06.26](/uploads/bd9856b34472f859f59a5bb1cddb43b5/Screenshot_2024-04-30_at_12.06.26.png) | ![Screenshot_2024-04-30_at_12.06.35](/uploads/750d04b6ceee021e920bccca94b98293/Screenshot_2024-04-30_at_12.06.35.png) | ## How to set up and validate locally You can create a FF definition file and run the `pre-push` Lefthook hook: ``` lefthook run pre-push ``` Related to https://gitlab.com/gitlab-org/gitlab/-/issues/428751.","title":"Add Danger checks for feature flag YAML definition files","merge_params":{"force_remove_source_branch":"1","auto_merge_strategy":"merge_when_pipeline_succeeds","should_remove_source_branch":true,"commit_message":"Merge branch '428751-follow-up-from-add-rollout-issue-link' into 'master' Add Danger checks for feature flag YAML definition files See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/144174 Merged-by: Peter Leitzen Approved-by: Tyler Amos Approved-by: Etienne Baqué Approved-by: Peter Leitzen Reviewed-by: Rémy Coutable Reviewed-by: Peter Leitzen Reviewed-by: Tyler Amos Reviewed-by: Etienne Baqué Co-authored-by: Rémy Coutable ","squash_commit_message":"Add Danger checks for feature flag YAML definition files Signed-off-by: Rémy Coutable ","sha":"17772f74558e14ea4ea439e2de73257c0057ce4e"},"state":"merged","source_branch":"428751-follow-up-from-add-rollout-issue-link","target_branch":"master","source_branch_path":"/gitlab-org/gitlab/-/tree/428751-follow-up-from-add-rollout-issue-link","target_branch_path":"/gitlab-org/gitlab/-/tree/master","diff_head_sha":"17772f74558e14ea4ea439e2de73257c0057ce4e","create_note_path":"/gitlab-org/gitlab/notes?target_id=280722900&target_type=merge_request","preview_note_path":"/gitlab-org/gitlab/-/preview_markdown?target_id=144174&target_type=MergeRequest","can_receive_suggestion":true,"create_issue_to_resolve_discussions_path":null,"new_blob_path":null,"current_user":{"can_create_note":false,"can_update":false,"can_create_confidential_note":false},"is_project_archived":false,"project_id":278964,"require_password_to_approve":false}