Add Danger checks for feature flag YAML definition files
What does this MR do and why?
This adds Danger checks and diff suggestions for feature flag definition files, depending on the FF type.
I also enabled the Danger check locally as the feature flag definition file can actually be checked locally.
| Screenshot 1 | Screenshot 2 | Screenshot 3 |
|---|---|---|
 |
 |
 |
How to set up and validate locally
You can create a FF definition file and run the pre-push Lefthook hook:
lefthook run pre-pushRelated to #428751 (closed).
Merge request reports
Activity
changed milestone to %16.9
added maintenancepipelines typemaintenance labels
assigned to @rymai
mentioned in issue #428751 (closed)
mentioned in epic &5325
added Engineering Productivity label
changed milestone to %16.10
added 966 commits
-
e1ebdb6c...f2fa6a6c - 964 commits from branch
master - 439b7e44 - Add Danger checks for feature flag YAML definition files
- 2f80a821 - Introduce a dummy feature flag to test Danger
-
e1ebdb6c...f2fa6a6c - 964 commits from branch
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@57e97e4b
E2E Test Result Summary
allure-report-publishergenerated test report!e2e-test-on-gdk:
expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Verify | 31 | 0 | 1 | 30 | 32 | ✅ | | Create | 110 | 1 | 9 | 94 | 120 | ❌ | | Govern | 66 | 0 | 0 | 43 | 66 | ✅ | | Plan | 54 | 0 | 2 | 47 | 56 | ✅ | | Data Stores | 31 | 0 | 0 | 22 | 31 | ✅ | | Analytics | 2 | 0 | 0 | 1 | 2 | ✅ | | Package | 19 | 0 | 12 | 19 | 31 | ✅ | | Monitor | 8 | 0 | 0 | 7 | 8 | ✅ | | Release | 5 | 0 | 0 | 5 | 5 | ✅ | | Manage | 0 | 0 | 1 | 0 | 1 | ➖ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 326 | 1 | 25 | 268 | 352 | ❌ | +-------------+--------+--------+---------+-------+-------+--------+e2e-package-and-test:
expand test summary
+---------------------------------------------------------------------+ | suites summary | +----------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +----------------+--------+--------+---------+-------+-------+--------+ | Plan | 246 | 0 | 13 | 0 | 259 | ✅ | | Govern | 271 | 0 | 22 | 0 | 293 | ✅ | | Fulfillment | 5 | 3 | 75 | 0 | 83 | ❌ | | Verify | 138 | 0 | 27 | 0 | 165 | ✅ | | Create | 548 | 0 | 93 | 0 | 641 | ✅ | | Monitor | 36 | 0 | 13 | 0 | 49 | ✅ | | Package | 226 | 0 | 17 | 0 | 243 | ✅ | | Systems | 8 | 0 | 0 | 0 | 8 | ✅ | | Data Stores | 116 | 0 | 31 | 0 | 147 | ✅ | | Manage | 39 | 0 | 11 | 0 | 50 | ✅ | | GitLab Metrics | 2 | 0 | 1 | 0 | 3 | ✅ | | Analytics | 7 | 0 | 0 | 0 | 7 | ✅ | | Configure | 1 | 0 | 9 | 0 | 10 | ✅ | | Secure | 6 | 0 | 3 | 0 | 9 | ✅ | | Release | 15 | 0 | 3 | 0 | 18 | ✅ | | ModelOps | 0 | 0 | 3 | 0 | 3 | ➖ | | Growth | 0 | 0 | 6 | 0 | 6 | ➖ | +----------------+--------+--------+---------+-------+-------+--------+ | Total | 1664 | 3 | 327 | 0 | 1994 | ❌ | +----------------+--------+--------+---------+-------+-------+--------+Edited by Ghost Useradded 229 commits
-
2f80a821...cfc0b476 - 227 commits from branch
master - 03eb8c89 - Add Danger checks for feature flag YAML definition files
- a5057446 - Introduce a dummy feature flag to test Danger
-
2f80a821...cfc0b476 - 227 commits from branch
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@5b5d080c
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@7c0c233a
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@403dfe02
