Add sharding keys for code_review_workflow

Add sharding keys for feature category code_review_workflow.

These tables have been identified as cell local tables.

All cell local tables require a sharding key.

A sharding key has been automatically selected for these tables. The sharding key was chosen because it is a NOT NULL column referencing either projects or namespaces.

Additionally, gitlab_schema has been set to gitlab_main_cell for any tables didn't use this schema already. For these tables we have also added allow_cross_joins, allow_cross_transactions and allow_cross_foreign_keys. These will silence any existing violations, allowing the pipeline to pass without requiring further changes. In the future, we'll remove these allow_... statements and fix any violations as they arise. You can read more about this in the documentation for multiple databases

We have assigned a random backend engineer from groupcode review to review these changes. Please confirm that each table should indeed be cell local, and that the selected column is an appropriate sharding key. When you are finished, please request a review from the database maintainer suggested by Danger.

If you have any questions or concerns, reach out to @tigerwnz or @DylanGriffith.

This change was generated by gitlab-housekeeper

added automation:gitlab-housekeeper-authored database groupcode review maintenancescalability labels

requested review from @kerrizor

added typemaintenance label

added devopscreate sectiondev labels

added 1 commit

• f0ad99cc - Add sharding keys for code_review_workflow

Compare with previous version

added databasereview pending label

	2 Warnings
	f0ad99cc: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines.
	This merge request does not have any assignee yet. Setting an assignee clarifies who needs to take action on the merge request at any given time.

Reviewer roulette

Category	Reviewer	Maintainer
database	@dskim_gitlab (UTC+11)	@OmarQunsulGitlab (UTC+1)

Please check reviewer's status!

• Reviewer is available!
• Reviewer is unavailable!

Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.

If needed, you can retry the danger-review job that generated this comment.

Generated by Danger

E2E Test Result Summary

allure-report-publisher generated test report!

e2e-test-on-gdk: test report for f6fa2e1c

expand test summary

+------------------------------------------------------------------+
|                          suites summary                          |
+-------------+--------+--------+---------+-------+-------+--------+
|             | passed | failed | skipped | flaky | total | result |
+-------------+--------+--------+---------+-------+-------+--------+
| Create      | 57     | 0      | 12      | 0     | 69    | ✅     |
| Plan        | 4      | 0      | 0       | 0     | 4     | ✅     |
| Package     | 0      | 0      | 1       | 0     | 1     | ➖     |
| Govern      | 3      | 0      | 0       | 0     | 3     | ✅     |
| Monitor     | 4      | 0      | 0       | 0     | 4     | ✅     |
| Data Stores | 2      | 0      | 0       | 0     | 2     | ✅     |
+-------------+--------+--------+---------+-------+-------+--------+
| Total       | 70     | 0      | 13      | 0     | 83    | ✅     |
+-------------+--------+--------+---------+-------+-------+--------+

e2e-package-and-test: test report for f6fa2e1c

expand test summary

+------------------------------------------------------------------+
|                          suites summary                          |
+-------------+--------+--------+---------+-------+-------+--------+
|             | passed | failed | skipped | flaky | total | result |
+-------------+--------+--------+---------+-------+-------+--------+
| Create      | 548    | 0      | 78      | 18    | 626   | ✅     |
| Monitor     | 8      | 0      | 0       | 0     | 8     | ✅     |
| Package     | 0      | 0      | 2       | 0     | 2     | ➖     |
| Plan        | 8      | 0      | 0       | 0     | 8     | ✅     |
| Govern      | 6      | 0      | 0       | 0     | 6     | ✅     |
| Data Stores | 4      | 0      | 0       | 0     | 4     | ✅     |
+-------------+--------+--------+---------+-------+-------+--------+
| Total       | 574    | 0      | 80      | 18    | 654   | ✅     |
+-------------+--------+--------+---------+-------+-------+--------+

added automation:bot-authored label

Making a note that this relates to Code Review: Add sharding keys to all your cell... (#440140).

mentioned in epic &12795

approved this merge request

resolved all threads

@kerrizor, thanks for approving this merge request.

This is the first time the merge request has been approved. To ensure we don't only run predictive pipelines, and we don't break master, please start a new pipeline before merging.

Please wait for the pipeline to start before resolving this discussion and set auto-merge for the new pipeline. See merging a merge request for more details.

added pipeline:mr-approved label

resolved all threads

added 2755 commits

• f0ad99cc...89d61215 - 2754 commits from branch master
• f6fa2e1c - Merge branch 'master' into 'determine-sharding-key-feature-category-code_review_workflow'

Compare with previous version

@tigerwnz @manojmj I've resolved the conflict from !144636 (merged) -- could either/both of you review/confirm?

requested review from @tigerwnz and @manojmj