Skip to content

Re-migrate more auth related qa-selectors

Sanad Liaquat requested to merge qa-shl-re-migrate-manage-qa-selectors into master

What does this MR do and why?

This is a re-submission of !135327 (merged) which was reverted in !135898 (merged) due to an incident

This MR has a lesser file changes than the earlier MR as those files were migrated in other MRs.

To ensure the issue doesn't happen again, we:

  1. Added data-testid: 'login-page' to the login page while keeping the data-qa-selector: 'login_page' around. We will remove data-qa-selector: 'login_page' once this MR is through to production.
  2. Added a validation to check if the tests are actually running against canary when gitlab_canary=true cookie is set.

Original description:

Migrate more data-qa-selector used by e2e specs for groupauthentication and groupauthorization as part of gitlab-org/quality/quality-engineering/team-tasks#1735

Related task: gitlab-org/quality/quality-engineering/team-tasks#1822 (closed)

Work item: gitlab-org/quality/quality-engineering/team-tasks#1823 (closed)

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Sanad Liaquat

Merge request reports