Phase out `data-qa-selector` and replace it with `data-testid`
Phase out data-qa-selector
and replace it with data-testid
attributes
As per #1741 (closed) task from issue #1735
Here is a small MR showing example changes including using an existing testid - gitlab-org/gitlab!122910 (diffs)
There is also an example in the change MR itself - gitlab-org/gitlab!121266 (diffs) (see security_configuration vue files)
I’m here to help/review etc. The plan is to deprecate and remove data-qa-selector
entirely.
Details:
- Use kebab-case for testid
testid="kebab-case-attribute"
- Use strings for page elements -
element :push_the_button
becomeselement 'push-the-button'
Remaining selector codebase directories:
Remaining selectors by location:
-
app/assets/javascripts/analytics/shared/components - @willmeek - gitlab-org/gitlab!137803 (merged) -
app/assets/javascripts/authentication - @willmeek - gitlab-org/gitlab!137803 (merged) -
app/assets/javascripts/badges - @willmeek - gitlab-org/gitlab!138352 (merged) -
app/assets/javascripts/blob/filepath_form/components - @willmeek - gitlab-org/gitlab!137803 (merged) -
app/assets/javascripts/ci - @a_mcdonald - gitlab-org/gitlab!137831 (merged) -
app/assets/javascripts/ci_secure_files/components - @a_mcdonald - gitlab-org/gitlab!138439 (merged) -
app/assets/javascripts/ci_settings_pipeline_triggers/components - @a_mcdonald - gitlab-org/gitlab!138439 (merged) -
app/assets/javascripts/clusters_list/components - @willmeek - gitlab-org/gitlab!138352 (merged) -
app/assets/javascripts/content_editor/components/bubble_menus - @a_mcdonald - gitlab-org/gitlab!138439 (merged) -
app/assets/javascripts/deploy_tokens/components - @willmeek - gitlab-org/gitlab!138352 (merged) -
app/assets/javascripts/error_tracking/components - @willmeek - gitlab-org/gitlab!138352 (merged) -
app/assets/javascripts/environments/components - @treagitlab - gitlab-org/gitlab!138376 (merged) -
app/assets/javascripts/groups/components - @treagitlab - gitlab-org/gitlab!138376 (merged) -
app/assets/javascripts/groups_projects/components - @treagitlab - gitlab-org/gitlab!138376 (merged) -
app/assets/javascripts/import_entities/import_groups/components - @treagitlab - gitlab-org/gitlab!138376 (merged) -
app/assets/javascripts/integrations - @a_mcdonald - gitlab-org/gitlab!139186 (merged) -
app/assets/javascripts/language_switcher/components - @a_mcdonald - gitlab-org/gitlab!139186 (merged) -
app/assets/javascripts/members/components - @a_mcdonald - gitlab-org/gitlab!139740 (merged) -
app/assets/javascripts/nav/components - @willmeek - Removed as per gitlab-org/gitlab!138062 (diffs) -
app/assets/javscripts/packages_and_registries - @willmeek gitlab-org/gitlab!138816 (merged) -
app/assets/javascripts/pages/import/ - @willmeek gitlab-org/gitlab!138816 (merged) -
app/assets/javascripts/pages/admin/application_settings/general/components - @willmeek gitlab-org/gitlab!138816 (merged) -
app/assets/javascripts/pages/projects/forks/new/components - @willmeek gitlab-org/gitlab!138816 (merged) -
app/assets/javascripts/pages/shared/wikis/components @john.mcdonnell gitlab-org/gitlab!137917 (merged) -
app/assets/javascripts/performance_bar/components @john.mcdonnell gitlab-org/gitlab!137880 (merged) -
app/assets/javascripts/projects/components/shared @dchevalier2 gitlab-org/gitlab!138839 (merged) -
app/assets/javascripts/sidebar/components/labels/label_select_vue - @treagitlab gitlab-org/gitlab!138996 (merged) -
app/assets/javascripts/super_sidebar/components - @treagitlab gitlab-org/gitlab!138996 (merged) -
app/assets/javascripts/vue_merge_request_widget @jay_mccure -
app/assets/javascripts/vue_shared/alert_details/components/system_notes @sliaquat => gitlab-org/gitlab!138894 (merged) -
app/assets/javascripts/vue_shared/components - @treagitlab gitlab-org/gitlab!138996 (merged) -
app/assets/javascripts/vue_shared/security_configuration/components - @treagitlab gitlab-org/gitlab!138996 (merged) -
app/helpers - @willmeek - gitlab-org/gitlab!139120 (merged) -
app/views/admin/ @sliaquat => gitlab-org/gitlab!138894 (merged) -
app/views/groups/ - @willmeek - gitlab-org/gitlab!139120 (merged) -
app/views/layouts - @treagitlab gitlab-org/gitlab!139173 (merged) -
app/views/profiles @dchevalier2 gitlab-org/gitlab!138841 (merged) -
app/views/projects - @treagitlab gitlab-org/gitlab!139173 (merged) -
app/views/search/results - @treagitlab gitlab-org/gitlab!140271 (merged) -
app/views/shared - @treagitlab gitlab-org/gitlab!140271 (merged) -
ee/app/helpers - @willmeek - gitlab-org/gitlab!139813 (merged) -
ee/app/views/admin @sliaquat => gitlab-org/gitlab!138894 (merged) -
ee/app/views/groups - @willmeek - gitlab-org/gitlab!139813 (merged) -
ee/app/views/ldap_group_links - @willmeek - gitlab-org/gitlab!139903 (merged) - REBASED -
ee/app/views/projects - @willmeek - gitlab-org/gitlab!139903 (merged) - REBASED -
ee/app/views/registrations/groups - @willmeek - gitlab-org/gitlab!139912 (merged) - IN REVIEW -
ee/app/views/shared - @willmeek - gitlab-org/gitlab!139912 (merged) - IN REVIEW -
ee/spec/helpers - @willmeek - gitlab-org/gitlab!139912 (merged) - IN REVIEW -
lib/search - @willmeek - gitlab-org/gitlab!139912 (merged) - IN REVIEW -
spec/frontend/authentication/password/components - @willmeek - gitlab-org/gitlab!139929 (diffs) - IN REVIEW -
spec/frontend/error_tracking/components - @willmeek - migrated by gitlab-org/gitlab!138352 (diffs) -
spec/frontend/header_search - @willmeek removed by gitlab-org/gitlab@f33dc5ff -
spec/frontend/members - @willmeek - gitlab-org/gitlab!139929 (diffs) - IN REVIEW -
spec/frontend/projects/components/shared - @dchevalier2 migrated by gitlab-org/gitlab@6e8aa9e2 -
spec/frontend/vue_shared/components/form - @willmeek - gitlab-org/gitlab!140220 (merged) - IN REVIEW -
spec/frontend/fixtures/static - @willmeek - gitlab-org/gitlab!140220 (merged) - IN REVIEW -
spec/frontend/vue_merge_request_widget/components/widget/snapshots @jay_mccure -
spec/frontend/nav/components - @willmeek - gitlab-org/gitlab!140220 (merged) - IN REVIEW -
spec/frontend/admin/signup_restrictions/components - @willmeek - gitlab-org/gitlab!140220 (merged) -
spec/helpers - @willmeek - gitlab-org/gitlab!140220 (merged) - IN REVIEW -
doc/development/ - @willmeek - gitlab-org/gitlab!140220 (merged) - IN REVIEW -
ee/app/assets/javascripts/approvals/components - @willmeek gitlab-org/gitlab!141393 (merged) - IN REVIEW -
ee/app/assets/javascripts/geo_settings/components - @treagitlab gitlab-org/gitlab!140386 (merged) -
ee/app/assets/javascripts/geo_site_form/components - @treagitlab gitlab-org/gitlab!140386 (merged) -
ee/app/assets/javascripts/groups/settings/access_restriction_field - @willmeek - gitlab-org/gitlab!139813 (merged) -
ee/app/assets/javascripts/merge_checks/components @jay_mccure -
ee/app/assets/javascripts/registrations/groups/new/components - @nprabakaran - gitlab-org/gitlab!140317 (merged) - IN REVIEW -
ee/app/assets/javascripts/saml_sso/components - @willmeek - gitlab-org/gitlab!139813 (merged) -
ee/app/assets/javascripts/security_configuration/components - @nprabakaran - gitlab-org/gitlab!140317 (merged) - IN REVIEW -
ee/app/assets/javascripts/security_dashboard/components - @nprabakaran - gitlab-org/gitlab!140317 (merged) - IN REVIEW -
ee/app/assets/javascripts/security_orchestration/components/policy_editor - @nprabakaran - gitlab-org/gitlab!140317 (merged) -
ee/app/assets/vue_merge_request_widget/extensions/security_reports - @treagitlab gitlab-org/gitlab!140386 (merged) -
ee/app/assets/vue_shared - @nprabakaran - gitlab-org/gitlab!140317 (merged) - IN REVIEW -
ee/app/helpers/groups - @willmeek - gitlab-org/gitlab!139813 (merged) -
ee/spec/frontend - covered by gitlab-org/gitlab!139929 (diffs) and gitlab-org/gitlab!140317 (comment 1720210473) -
lib/sidebars/admin/menus - @nprabakaran - gitlab-org/gitlab!140323 (merged) -
qa/qa/ee/page/component @dchevalier2 gitlab-org/gitlab!138836 (merged) -
qa/qa/mobile/ @dchevalier2 gitlab-org/gitlab!137583 (merged) -
qa/qa/page @willmeek - NOTE element will need merged last - gitlab-org/gitlab!141904 (merged) - IN REVIEW -
qa/spec/page @willmeek NOTE element will need merged last - gitlab-org/gitlab!141904 (merged) - IN REVIEW -
GitLab UI - @willmeek gitlab-org/gitlab-ui!3896 (merged)
Edited by Will Meek