Unify end-to-end test framework data QA selector to align with feature specs for easibility
Problem
Developers are used to writing capybara at the feature level. They get confused with our QA framework. It has come up before that we should unify the selectors used in both feature and e2e specs.
Proposal
Replace data-qa-*
used in E2E tests with data-testid
in following steps:
- Add support for using
data-testid
attribute in e2e test framework - gitlab-org/gitlab!120750 (merged) - Update documentation to encourage using
data-testid
in E2E tests - Phase out
data-qa-selector
and replace it withdata-testid
attribute | Issue - Add a rubocop rule to disallow
data-qa-selector
- gitlab-org/gitlab!142556
Communicate changes
Pushed out to a future iteration
- Migrate
data-qa-*
todata-test-*
and update docs
Edited by Will Meek