Enable AvoidCreate cop for spec/lib/sidebars
What does this MR do and why?
Related #414635 (closed)
Follow up on !122198 (comment 1414273472)
Enable AvoidCreate cop for spec/lib/sidebars
and ee/spec/lib/sidebars
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
Before | After |
---|---|
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
changed milestone to %16.1
assigned to @alinamihaila
added typemaintenance label
- A deleted user
added backend label
1 Warning 5c970f2e: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Patrick Cyiza (
@jpcyiza
) (UTC+2, 1 hour behind@alinamihaila
)Mark Chao (
@lulalala
) (UTC+8, 5 hours ahead of@alinamihaila
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangermentioned in merge request !122771 (merged)
- Resolved by Peter Leitzen
@ddieulivol could you please review this when you have the chance?
There is a follow up for fixing quick offences in ee/spec/lib/sidebars in !122771 (merged)
If all good, we can assign maybe for maintainer review to
@splattael
Thank you!
Edited by Alina Mihaila
requested review from @ddieulivol
added 1 commit
- 5c2996d6 - Fix AvoidCreate offences in spec/lib/sidebars
added rspec profiling label
requested review from @splattael and removed review request for @ddieulivol
- Resolved by Peter Leitzen
- Resolved by Peter Leitzen
added 1 commit
- 5c970f2e - Fix AvoidCreate offences in spec/lib/sidebars
mentioned in merge request !122885 (merged)
marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed
mentioned in commit ca7dc52d
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label