Skip to content
Snippets Groups Projects

Enable AvoidCreate cop for spec/lib/sidebars

Merged Alina Mihaila requested to merge am-enable-AvoidCreate-for-spec-lib-sidebars into master
All threads resolved!

What does this MR do and why?

Related #414635 (closed)

Follow up on !122198 (comment 1414273472)

Enable AvoidCreate cop for spec/lib/sidebars and ee/spec/lib/sidebars

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Alina Mihaila

Merge request reports

Merged results pipeline #891072712 passed

Merged results pipeline passed for ee1d9621

Approved by

Merged by Peter LeitzenPeter Leitzen 1 year ago (Jun 7, 2023 12:55pm UTC)

Merge details

  • Changes merged into master with ca7dc52d (commits were squashed).
  • Deleted the source branch.

Pipeline #892440956 passed

Pipeline passed for ca7dc52d on master

10 environments impacted.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Alina Mihaila added 1 commit

    added 1 commit

    • 164d8525 - Use let instead of let_it_be

    Compare with previous version

  • Alina Mihaila added 1 commit

    added 1 commit

    • 5c970f2e - Fix AvoidCreate offences in spec/lib/sidebars

    Compare with previous version

  • Alina Mihaila mentioned in merge request !122885 (merged)

    mentioned in merge request !122885 (merged)

  • Alina Mihaila changed the description

    changed the description

  • Peter Leitzen approved this merge request

    approved this merge request

  • Peter Leitzen resolved all threads

    resolved all threads

  • Peter Leitzen marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed

    marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed

  • Alina Mihaila changed the description

    changed the description

  • merged

  • Peter Leitzen mentioned in commit ca7dc52d

    mentioned in commit ca7dc52d

  • added workflowstaging label and removed workflowcanary label

  • Please register or sign in to reply
    Loading