Skip to content

Am fix avoid create for spec lib sidebars

Alina Mihaila requested to merge am-fix-AvoidCreate-for-spec-lib-sidebars into master

What does this MR do and why?

Related #414635 (closed)

Follow-up !122766 (merged)

Fixed some quick offences in spec/lib/sidebars

Before

Finished in 51.87 seconds (files took 14.37 seconds to load)
791 examples, 0 failures

Randomized with seed 39887

[TEST PROF INFO] Time spent in factories: 00:12.739 (23.28% of total time)
[TEST PROF INFO] Factories usage

 Total: 227
 Total top-level: 189
 Total time: 00:12.739 (out of 01:01.885)
 Total uniq factories: 16

   total   top-level     total time      time per call      top-level time               name

     101         101        0.4976s            0.0049s             0.4976s            license
      45          41        2.1118s            0.0469s             1.8951s               user
      25          21        7.9135s            0.3165s             7.3676s            project
      25           0        1.2794s            0.0512s             0.0000s          namespace
       6           6        0.2466s            0.0411s             0.2466s zentao_integration
       5           5        0.3261s            0.0652s             0.3261s confluence_integration
       3           3        0.4303s            0.1434s             0.4303s              issue
       3           3        0.5888s            0.1963s             0.5888s      merge_request
       3           0        0.0180s            0.0060s             0.0000s     work_item_type
       3           3        0.7264s            0.2421s             0.7264s  shimo_integration
       2           2        0.2151s            0.1076s             0.2151s harbor_integration
       2           2        0.3970s            0.1985s             0.3970s       abuse_report
       1           0        0.0031s            0.0031s             0.0000s namespace_ci_cd_settings
       1           0        0.0038s            0.0038s             0.0000s namespace_settings
       1           1        0.0434s            0.0434s             0.0434s              group
       1           1        0.0055s            0.0055s             0.0055s dependency_proxy_group_setting

After


Finished in 49.19 seconds (files took 13.55 seconds to load)
791 examples, 0 failures

Randomized with seed 13948

[TEST PROF INFO] Time spent in factories: 00:11.805 (22.69% of total time)
[TEST PROF INFO] Factories usage

 Total: 203
 Total top-level: 168
 Total time: 00:11.805 (out of 00:58.977)
 Total uniq factories: 16

   total   top-level     total time      time per call      top-level time               name

     101         101        0.4751s            0.0047s             0.4751s            license
      27          23        1.3915s            0.0515s             0.8454s               user
      23          19        8.0197s            0.3487s             7.4124s            project
      23           0        1.2081s            0.0525s             0.0000s          namespace
       6           6        0.2505s            0.0417s             0.2505s zentao_integration
       5           5        0.3546s            0.0709s             0.3546s confluence_integration
       3           3        0.4003s            0.1334s             0.4003s  shimo_integration
       3           3        0.5905s            0.1968s             0.5905s      merge_request
       2           2        0.7761s            0.3881s             0.7761s       abuse_report
       2           2        0.1345s            0.0672s             0.1345s harbor_integration
       2           2        0.5234s            0.2617s             0.5234s              issue
       2           0        0.0174s            0.0087s             0.0000s     work_item_type
       1           1        0.0389s            0.0389s             0.0389s              group
       1           0        0.0032s            0.0032s             0.0000s namespace_ci_cd_settings
       1           1        0.0034s            0.0034s             0.0034s dependency_proxy_group_setting
       1           0        0.0033s            0.0033s             0.0000s namespace_settings

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Alina Mihaila

Merge request reports