Fix AvoidCreate offenses in ee/spec/lib/sidebars

What does this MR do and why?

Related #414635 (closed)

Fix AvoidCreate offenses in ee/spec/lib/sidebars

Small improvement by replacing create with build_stubbed

Finished in 15.16 seconds (files took 11.95 seconds to load)
159 examples, 0 failures

Randomized with seed 14040

[TEST PROF INFO] Time spent in factories: 00:01.701 (9.98% of total time)
[TEST PROF INFO] Factories usage

 Total: 42
 Total top-level: 35
 Total time: 00:01.701 (out of 00:24.061)
 Total uniq factories: 7

   total   top-level     total time      time per call      top-level time               name

      19          19        0.0868s            0.0046s             0.0868s            license
      12          12        0.6117s            0.0510s             0.6117s               user
       3           3        0.1663s            0.0554s             0.1663s              group
       3           0        0.0136s            0.0045s             0.0000s namespace_settings
       3           0        0.0098s            0.0033s             0.0000s namespace_ci_cd_settings
       1           1        0.8369s            0.8369s             0.8369s            project
       1           0        0.0380s            0.0380s             0.0000s          namespace

After

Finished in 14.66 seconds (files took 12.51 seconds to load)
159 examples, 0 failures

Randomized with seed 11034

[TEST PROF INFO] Time spent in factories: 00:01.510 (9.01% of total time)
[TEST PROF INFO] Factories usage

 Total: 36
 Total top-level: 29
 Total time: 00:01.510 (out of 00:23.522)
 Total uniq factories: 7

   total   top-level     total time      time per call      top-level time               name

      19          19        0.0851s            0.0045s             0.0851s            license
       6           6        0.4522s            0.0754s             0.4522s               user
       3           3        0.1853s            0.0618s             0.1853s              group
       3           0        0.0122s            0.0041s             0.0000s namespace_settings
       3           0        0.0083s            0.0028s             0.0000s namespace_ci_cd_settings
       1           1        0.7883s            0.7883s             0.7883s            project
       1           0        0.0388s            0.0388s             0.0000s          namespace

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before	After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

• I have evaluated the MR acceptance checklist for this MR.

changed milestone to %16.1

added Engineering Productivity backend maintenancerefactor static code analysis typemaintenance labels

assigned to @alinamihaila

mentioned in merge request !122766 (merged)

Reviewer roulette

Changes that require review have been detected!

Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:

Category	Reviewer	Maintainer
backend	Kasia Misirli (@Kasia_Misirli) (UTC+2, 1 hour behind @alinamihaila)	Mayra Cabrera (@mayra-cabrera) (UTC-6, 9 hours behind @alinamihaila)

To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.

If needed, you can retry the danger-review job that generated this comment.

Generated by Danger

added rspec profiling label

changed the description

deleted the am-enable-AvoidCreate-for-spec-lib-sidebars branch. This merge request now targets the master branch

changed title from Fix AvoidCreate offenses to Fix AvoidCreate offenses in ee/spec/lib/sidebars

changed the description

added 1 commit

• f4f01074 - Fix AvoidCreate offenses

Compare with previous version

@Kasia_Misirli could you please review this when you have the chance? Thank you!

requested review from @Kasia_Misirli

approved this merge request

requested review from @mayra-cabrera and removed review request for @Kasia_Misirli

approved this merge request

resolved all threads

enabled an automatic merge when the pipeline for af883da9 succeeds

Thanks @alinamihaila! LGTM setting MWPS

merged

mentioned in commit 8ef000ae

added workflowstaging-canary label

added workflowcanary label and removed workflowstaging-canary label

added workflowstaging label and removed workflowcanary label

added workflowproduction label and removed workflowstaging label

added workflowpost-deploy-db-staging label and removed workflowproduction label

added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label

added releasedcandidate label

added releasedpublished label and removed releasedcandidate label