Follow-up from "Add spec for legacy key overrides"

The following discussion from !155968 (merged) should be addressed:

• @ashmckenzie started a discussion:

  suggestion (nitpick): As we only have a single it defined for this context, we generally have the before logic included as part of the it:

              it 'uses the legacy key' do
                stub_file_read(Gitlab::UsageDataCounters::HLLRedisCounter::KEY_OVERRIDES_PATH,
                  content: 'an_event-filter:[label:foo]: a_legacy_key')

  It's somewhat covered in https://docs.gitlab.com/ee/development/testing_guide/best_practices.html#subject-and-let-variables, but perhaps we could add an explicit example for before?

  This can be handled in a follow-up Issue however

changed the description

@ashmckenzie, Please add a group or category label to identify issue ownership.

You can refer to the Features by Group handbook page for guidance.

If you are unsure about the correct group, please do not leave the issue without a group label, and refer to GitLab's shared responsibility functionality guidelines for more information on how to triage this kind of issue.

This message was generated automatically. You're welcome to improve it.

assigned to @ashmckenzie

changed milestone to %17.2

added groupsource code maintenancerefactor typemaintenance labels

added Category:Source Code Management devopscreate sectiondev labels

mentioned in merge request !156707 (merged)

added workflowin review label

Closing now that Remove unnecessary before block (!156707 - merged) has been merged.

closed