When using the /unassign_reviewer quick action in rich text editor the dropdown suggests all MR participants (including bots and some random groups as the screenshot below shows), even if you are the only reviewer assigned. This is different from the plain text editor which filtered only current reviewers.
Similarly, /unassign lists all MR participants, and /unlabel lists all labels, whereas it should only list currently assigned users or labels.
As mentioned in this comment as well the quick action does not include the @ by default which is 1 extra key stroke for users.
Proposed Solution:
Create parity between plain text editor and rich text editor
when using the unassign review action in the rich text editor ensure that only the assigned reviews can be unassigned. Include the @ by default during this action as well.
There is a similar parity needed for /unassign, /unlabel as well. I will update the issue
Himanshu Kapoorchanged title from Create parity in /unassign_reviewer between rich text editor and plain text editor to Create parity in unassign quick actions between rich text editor and plain text editor
changed title from Create parity in /unassign_reviewer between rich text editor and plain text editor to Create parity in unassign quick actions between rich text editor and plain text editor
Himanshu Kapoorchanged the descriptionCompare with previous version
@mmacfarlane Even though this issue is related to #406722 (closed), its not that easy to fix. Currently we don't have a way to "look behind" and see what quick action was used since the users dropdown is independent of the quick actions dropdown.
Updating the weight to 3 since it needs some research on how it can be solved. Perhaps using some event emitting. Anyways I think it will not make it in %16.5, even though #406722 (closed) will (MR !133699 (merged)).
@mmacfarlane This is still in dev so it won't make it in 16.6, but the good news is that I implemented a new autocomplete module that helps us maintain complete parity regarding autocomplete items between both the editors in !136437 (merged).
In addition to this bug, the MR also fixes the below issues:
Brilliant work @himkp When the MR is merged and verified could you close out the issues for the bugs it fixes with workflowcomplete and milestone %16.7 please? That way they'll all feature in the Release Post and folks will know what milestone they were fixed in!
Do you think we'll be able to complete this in %16.7 or is %16.8 more likely? Just trying to balance that we are also working on Work Items.
They are already complete and fixed in the MR. Just need to prepare it to send for review. Should be able to do it this week. Added milestone %16.7 as well.