Skip to content

Resolve "Recover reverted fixes to Merge Request refactor regressions"

André Luís requested to merge 49854-recover-mr-regression-fixes-safe into master

What does this MR do?

Recovers the fixes we had to revert to remove any possible cause for the performance degradation that caused 11.1.3 to be aborted.

Recovered by this MR

Please check when each of these have been reviewed thoroughly. See next point.

Are there points in the code the reviewer needs to double check?

Do deep performance profiling on:

  1. rendering the Changes tab on small as well as large (+5000 changes) MRs.
  2. posting notes
  3. resolving discussions

Rule of thumb: this cannot be worse than what is in master. It should even be quicker when posting comment since we are recovering !20779 (merged).

Why was this MR needed?

We had to remove the fixes to no block 11.2 RC1.

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/49242 and https://gitlab.com/gitlab-org/gitlab-ce/issues/49343 and https://gitlab.com/gitlab-org/gitlab-ce/issues/48876 and https://gitlab.com/gitlab-org/gitlab-ce/issues/48877 and #48817 (closed) and #48602 (closed) and #49843 (closed)

Edited by André Luís

Merge request reports