Skip to content

Resolve ""Jump to first/next unresolved discussion" jumps to resolved discussions"

André Luís requested to merge 48817-fix-mr-changes-discussion-navigation into master

What does this MR do?

It solves the broken navigation buttons to jump to first unresolved discussion and also jump to next unresolved discussion.

Also no longer displays link to "next unresolved discussion" on the last discussion on the page (depending on which view you're in).

Are there points in the code the reviewer needs to double check?

Keen on checking if this doesn't worsen memory footprint that much for REALLY large MRs, with hundreds of discussions.

Why was this MR needed?

It was broken.

Screenshots (if relevant)

Screen_Shot_2018-07-06_at_14.17.18

Screen_Shot_2018-07-06_at_14.14.28

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

Closes #48817 (closed)

Closes #48602 (closed)

Edited by André Luís

Merge request reports