Database Group Triage for week ending 2023-11-17

About

This issue is used by groupdatabase to triage issues and make sure they get properly assigned and prioritized. Each week, a bot will look up the old issue, pick the next assignee in the list, and submit a new issue with a list of any issues that may need attention from the team.

Last week's issue

Process

• Review any issues identified for triage
• Review any issues with undefined types
• Post any questions or pressing issues to the database group meeting doc
• Post a comment on the database group status issue

  For triage this week there were 1 issues in need of triage, 4 issues without throughput labels, and 5 other database issues reviewed. <link to this issue>

Issues needing triage (Labeled databasetriage)

For each issue below:

1. If the issue needs further investigation, spend up to 1 hour of investigating or fixing the issue.
2. If the issue is a typebug, assign it one of severity1, severity2, severity3, or severity4
3. Document any findings you make in a comment on the issue, and if the issue still needs additional work or refinement, consider looping in @alexives and @rogerwoo to help with scheduling and priority.
4. If the issue is incomplete, labeled ~"workflow::scheduled", and will take more than an hour to fix, remove databasetriage

• Raise errors from define_batchable_model when used with composite primary keys

Issues with Undefined Type

For each issue below:

1. Assess if the issue is appropriately assigned to groupdatabase, if not add the correct group label.
2. Add the proper work type label, or if the issue is a request for support, redirect the user to our support resources with the following message:

   Hey @author. Based on the information given, this request for support is out of the scope of the issue tracker (which is for new bug reports and feature proposals). Unfortunately, I won't be able to help get it resolved. However, for support requests we have several resources that you can use to find help and support from the Community, including:
   * [Technical Support for Paid Tiers](https://about.gitlab.com/support/)
   * [Community Forum](https://forum.gitlab.com/)
   * [Reference Documents and Videos](https://about.gitlab.com/get-help/#references)
   
   Please refer to our [Support page](https://about.gitlab.com/support/) for more information.
   
   If you believe this was closed in error, please feel free to re-open the issue.
   
   /label ~"support request"
   /close

3. If the issue needs further investigation, add databasetriage and spend up to 1 hour of investigating the issue.
4. Document any findings you make in a comment on the issue, and if the issue still needs additional work or refinement, consider looping in @alexives and @rogerwoo to help with scheduling and priority.

• [Asynch Discussion] Team Naming
• [Feature flag] Enable skip_code_generation_instruction_extraction
• upgrade from 16.4.1 to 16.5.1 fails due to postgres key issue
• Load balancer feature flag to force replicas to stay in load balancing despite significant lag

Recent issues labeled database

For each issue below:

1. If the issue has no group label, consider if it should be addressed by groupdatabase and if so label it.
2. If the issue has a group, and you think they may need assistance from us:
   • If the issue needs further investigation, add databasetriage and spend up to 1 hour of investigating the issue.
   • Document any findings you make in a comment on the issue, and if the issue still needs additional work or refinement, consider looping in @alexives and/or @rogerwoo

• groupcompliance Add database validations for audit_events_amazon_s3_configurations
• grouptenant scale index_merge_requests_on_project_id synchronous database index(es) addition/removal
• groupacquisition Follow-up from "Remove ignored column from in_product_marketing_emails"
• grouppipeline authoring Column ci_sources_pipelines indexes do not exist and upgrade to 16.5 fails
• grouptenant scale Finalize async index index_security_findings_on_project_id

Recent mentions of @gitlab-org/database-team

For each mention below:

1. If the item already has an adequate response, move on to the next
2. If the mention is from someone looking to provide feedback on database review, and nobody has responded yet, set up a coffee chat with them and make a note in the thread that you did. Record feedback in the feedback issue.
3. If you know how to respond to the comment, post a response
4. If you don't know how, redirect with a specific mention to someone who may be able to respond

• @rogerwoo mentioned the team on [Asynch Discussion] Team Naming
• @splattael mentioned the team on Upgrade gitlab-styles to 11.0.0

Customer Issue Hand-offs

For each issue below:

1. If the item already has a back and forth, check in with the @l.rosa to see if what needs to be handed off
2. Consider if it's right for our team and if not, ask the support rep to follow up with the correct team.
3. If the item is right for our team, spend some time accessing it and trying to assist.
4. If you need help, and the request seems pressing, ask in the team channel if there's someone who can help dig into it.

• GitLab 15.11 DB migration workaround is not working for customer~"Help group::Database"
• Migration fails with "migrations_paths setting for ci database must be db/ci_migrate"~"Help group::Database", severity3
• The standby database is in a "running" state, but the standby leader itself is stuck in recovery~"Help group::Database", groupgeo

Review Recent Postgres Checkup

For each database:

1. Are there new queries in the top queries (See: K003 Top-15 Queries by total_time) compared to a previous report?
2. If there are new queries, Spend up to 30 minutes trying to understand their sources
3. If there are new queries, file an issue and assign to the team that owns the query, or if unable to source, then the team that owns the table

• Review recent Primary Checkup for new Top Queries
• Review recent CI Checkup for new Top Queries

@alexives if @mattkasa isn't available this week, please reassign to @praba.m7n cc @rogerwoo